[Bug]: herd isolate-node ignores --site and writes .nvmrc into the current folder
还没有人认领这个 Issue。
评估
调研方向
从 cli/app.php:1592 和 cli/Valet/Site.php:1303-1306 开始，追踪 --site 如何选择目标路径；并与 cli/app.php:1619 中对 unisolate-node 的处理进行比较。还要检查 bin/herd:148，这里的 shell hook 会检查 --site=。完成标准是：隔离操作将 .nvmrc 写入指定站点的文件夹；未知站点会返回错误；hook 能处理文档中说明的参数顺序，且不会更改当前文件夹的 Node 版本。
由索引模型根据 Issue 内容生成。
描述
Platform
macOS
Operating system version
macOS 27.0.1 (26A434)
System architecture
ARM64 (M1, M2, etc)
Herd Version
2.0.2 (Build: 71)
PHP Version
n/a (Node 26.12.0 through Herd's nvm; global PHP is 8.5.10)
Bug description
herd isolate-node 26 --site=example ignores --site. The docs show this form for sites whose name doesn't match their folder, but the .nvmrc lands in the current folder instead of the site's, overwriting any .nvmrc already there. It still says "The site is now using Node 26." and exits 0, even for a site that doesn't exist.
herd unisolate-node --site=example does look in the site's folder, so it says it worked and leaves the stray .nvmrc behind.
Because nvm and Herd's shell hook pick up .nvmrc from parent folders, running it from ~/Herd would switch Node for every site below it without its own .nvmrc (I saw the hook switch after a cd into a subfolder). From the hook's code it would also nvm install a missing version; I didn't test that.
Expected: the .nvmrc goes into the site's folder, and an unknown site name gives an error.
Cause (herd.phar 2.0.2): isolate-node always passes getcwd() to Site::isolateNode() (cli/app.php:1592), which uses that path whenever it's set (cli/Valet/Site.php:1303-1305), so the site lookup at :1306 never runs. unisolate-node passes no path (app.php:1619), so it finds the site.
Possible fix: pass null instead of getcwd() when --site is set (app.php:1592, and :1580 for the form without a version).
Also: bin/herd:148 only checks $2 for --site=, so with the docs' argument order (and for --help) it runs nvm use in the current folder as well.
Thanks for the quick fixes on #1770 and #1771.
Steps to reproduce
- Herd 2.0.2 with any installed Node version (26 here) and a linked or parked site
examplethat has no.nvmrc. - From a folder that isn't a site:
mkdir ~/herd-test && cd ~/herd-test, thenherd isolate-node 26 --site=example. ls -A ~/herd-test ~/Herd/example: the.nvmrcis in~/herd-test, not in the site's folder, andherd isolated-nodedoesn't list the site.herd unisolate-node --site=example: it says it worked, but~/herd-test/.nvmrcis still there.- Clean up with
rm ~/herd-test/.nvmrc.
Relevant log output
# Paths changed for privacy. For the linked-site part I ran herd.phar against a copy of my Herd config, so my real setup stayed untouched.
# Same behaviour with a stock .zshrc (only Herd's own lines) and with no shell config at all.
$ cd ~/herd-test
$ herd isolate-node --site=example 26
The site is now using Node 26.
$ ls -A ~/herd-test
.nvmrc
$ cat ~/herd-test/.nvmrc
26
$ ls -A ~/Herd/example
$ herd isolated-node
+------+--------------+
| Path | Node Version |
+------+--------------+
$ herd unisolate-node --site=example
The site is now using the default Node version.
$ ls -A ~/herd-test
.nvmrc
# The docs' argument order, with a site name that doesn't exist:
$ cd ~/herd-test2
$ herd isolate-node 26 --site=nosuchsite
The site is now using Node 26.
Found '~/herd-test2/.nvmrc' with version <26>
Now using node v26.12.0 (npm v11.20.0)
$ echo $?
0
- 主要语言
- 没有语言数据
- 星标
- 124
- 派生
- 1
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
beyondcode/herd-community 的其他 Issue
-
fixed-in-next-release macOS
难度 2/5 1-3 小时 新手友好度 83/100
beyondcode/herd-community#1771 ·
-
[Bug]: PHP 8.3 php.ini missing auto_prepend_file and herd-ext extension lines (dump() undefined)未关闭macOS
难度 2/5 1-3 小时 新手友好度 68/100
beyondcode/herd-community#1693 ·
-
macOS
难度 2/5 1-3 小时 新手友好度 72/100
beyondcode/herd-community#1602 ·
-
[Bug]: herd php:update hangs indefinitely on Windows when background PHP processes hold file locks未关闭windows
难度 4/5 3-5 天 新手友好度 42/100
beyondcode/herd-community#1775 ·
-
windows
难度 2/5 1-3 小时 新手友好度 58/100
beyondcode/herd-community#1772 · 1 条评论 · 1 个 reaction ·
查看 beyondcode/herd-community 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 78/100
-
GLM 5.3: the Converse cache verdict requires written == read and now prints False on a healthy run未关闭
难度 2/5 1-3 小时 新手友好度 78/100
aws-samples/sample-per-model-bedrock#407 ·
维护者通常 1 天内回复
-
DuckDB 2.0 breaks to_pyarrow_batches可能已有人在做 @DG47 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 76/100
ibis-project/ibis#12196 ·
维护者通常 1 天内回复
-
[BUG] rag: sentence content can cross the reported sentence boundaries可能已有人在做 @LJK-ikun 今天认领。 未关闭bug
难度 2/5 1-3 小时 新手友好度 75/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 73/100
维护者通常 1 天内回复