Add entity info key to indicate if exportable entities are stored as json instead of DB
还没有人认领这个 Issue。
评估
调研方向
Start with hook_entity_info() and _entity_plus_defaults_rebuild(), which are the entry points named in the issue, then inspect EntityPlusControllerExportable and the existing schema_fields_sql checks. Define and consume an indicator for JSON-stored exportable entities so cache clear and module enable/disable do not require a dummy base table; verify the behavior with a JSON-stored entity such as rules_config.
由索引模型根据 Issue 内容生成。
描述
It would be helpful to add a key to the array returned by hook_entity_info() to indicate that an exportable entity (aka "configuration entity") is stored as a json config file instead of in the database. This would allow us to avoid some fatal errors such as the one that happens in _entity_plus_defaults_rebuild() in the if statement that checks for $info['schema_fields_sql']['base table']. Since the entity is stored as json, it doesn't define hook_schema() and it doesn't have $info['schema_fields_sql']['base table']
This key could be called 'json storage'. If TRUE, then we could avoid the error I described above by skipping the if statement. Plus this may also provide other benefits (for example to Entity UI).
Some background on this:
_entity_plus_defaults_rebuild() (called _entity_defaults_rebuild in D7) was added a long time ago in D7. Before it, exportable entities could be defined in code, and would not be store in the database unless they were overridden. After the patch, this function stored all "in code" exportable entities to the database on cache clear or module enable/disable.
The problem I'm facing is that I'm working on the module Entity Plus CMI to create a Rules submodule. This submodule would save/load Rules configurations from json instead of database, making them available to the CMI api of Backdrop. Entity Plus CMI overrides EntityPlusControllerExportable. The main difference between exportable entities stored in the DB and those stored in config is that the second one doesn't use hook_schema(). Rather, it's "fields" are defined by including the fields to be read/saved in hook_entity_property_info().
This is working great, except that, when _entity_plus_defaults_rebuild()runs upon cache clear, we get a fatal error because the info for the entity doesn't contain $info['schema_fields_sql']['base table']. As a temporary fix, I have manually created a "dummy" array element called schema_fields_sql and a subarray base table in the entity definition array to fool that function.
Eventually, if we defined this key, providing a dummy info array element would be unnecessary, and it will provide other benefits to the Entity Plus code. It would allow to seamlessly move configuration entities such as rules_config and others (e.g. those provided by Search API) to config.
- 主要语言
- PHP
- 星标
- 3
- 派生
- 11
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
backdrop-contrib/entity_plus 的其他 Issue
-
难度 1/5 1 小时以内 新手友好度 65/100
backdrop-contrib/entity_plus#140 ·
-
难度 3/5 1-2 天 新手友好度 35/100
backdrop-contrib/entity_plus#177 ·
-
难度 2/5 1-3 小时 新手友好度 45/100
backdrop-contrib/entity_plus#170 · 1 条评论 · 2 个 reaction ·
-
难度 4/5 3-5 天 新手友好度 35/100
backdrop-contrib/entity_plus#168 · 1 条评论 ·
-
难度 3/5 1-2 天 新手友好度 45/100
backdrop-contrib/entity_plus#157 ·
查看 backdrop-contrib/entity_plus 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 2 天内回复
-
UX
难度 2/5 1-3 小时 新手友好度 72/100
ProfessionalWiki/NeoWiki#1573 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
-
难度 2/5 1-3 小时 新手友好度 68/100
-
bug
难度 2/5 1-3 小时 新手友好度 68/100
endoflife-date/endoflife.date#11194 ·
维护者通常 1 天内回复