ApiClient creates a new httpx.AsyncClient per JWKS / OIDC fetch with no timeout and no single-flight, causing "Unknown auth error" storms under load

未关闭
#85 1 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
48/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
冷清
技术栈
python

调研方向

从 src/auth0_api_python/utils.py 开始,通过 utils.fetch_jwks、utils.fetch_oidc_metadata 和 InMemoryCache.get 跟踪 ApiClient._fetch_jwks 和 _fetch_oidc_metadata。检查 verify_request 如何到达这些缓存未命中路径,以及如何使用 httpx.AsyncClient。完成的标准是:JWKS 和 OIDC 的重新获取能够避免所报告的客户端、超时和并发请求失败行为,同时不改变成功身份验证的语义。

由索引模型根据 Issue 内容生成。

描述

bug
Checklist
  • I have looked into the Readme and Examples, and have not found a suitable solution or answer.
  • I have looked into the API documentation and have not found a suitable solution or answer.
  • I have searched the issues and have not found a suitable solution or answer.
  • I have searched the Auth0 Community forums and have not found a suitable solution or answer.
  • I agree to the terms within the Auth0 Code of Conduct.
Description

ApiClient._fetch_jwks and _fetch_oidc_metadata (via
utils.fetch_jwks / utils.fetch_oidc_metadata) construct a brand-new
httpx.AsyncClient() on every cache miss with no explicit timeout
configured, and there is no single-flight protection around the
refetch path. Combined, these turn routine cache expiry into a
self-inflicted outage under any non-trivial concurrency.

Reproduction
  1. Stand up a FastAPI service that calls ApiClient.verify_request
    on every authenticated route.
  2. Drive ≥ ~30 RPS of authenticated requests against it (we hit it
    on a 4 vCPU ECS Fargate task during a k6 load test).
  3. Wait for the in-memory JWKS cache to expire — by default Auth0
    returns Cache-Control: max-age=600, so this happens every ~10
    minutes under steady load.
  4. Observe a sudden burst of httpx.ConnectTimeout chained out of
    ApiClient._fetch_jwks, surfacing to callers as opaque "Unknown
    auth error" 5xx responses on every authenticated route until the
    herd subsides. Sentry trace shows
    auth0_api_python.errors.UnknownAuth0Exception
    httpx.ConnectTimeout.
Additional context

In src/auth0_api_python/utils.py

async def fetch_jwks(jwks_uri, custom_fetch=None):
    ...
    async with httpx.AsyncClient() as client:   # 1
        resp = await client.get(jwks_uri)       # 2
        ...
  1. No connection pooling across calls. A fresh client is created
    and torn down per fetch. Every cache miss = a fresh TCP + TLS
    handshake to https://<tenant>.auth0.com/. Under load this
    exhausts ephemeral source-port budget on the host and slows
    everything else on the box.
  2. No explicit timeout. httpx.AsyncClient() with no timeout=
    uses httpx's default 5-second connect/read/write/pool budget. On a
    stressed event loop or a slow Auth0 region that 5s budget is
    routinely blown, raising httpx.ConnectTimeout /
    httpx.ReadTimeout. Those bubble up into _fetch_jwks and the
    caller sees ConnectTimeout chained to UnknownAuth0Exception
    not a 401, not a 503, just an opaque "unknown auth error".
  3. No single-flight on refetch. When the in-memory cache expires
    (InMemoryCache.get returns None), every concurrent request
    that reaches _fetch_jwks simultaneously fires its own outbound
    JWKS fetch. N requests in flight at the moment of expiry = N
    concurrent JWKS calls to Auth0. Auth0 throttles some of them, the
    others time out per (1) and (2), and any request that lost the
    race fails auth.

The same three problems apply verbatim to fetch_oidc_metadata and
_fetch_oidc_metadata.

auth0-api-python version

1.0.0b8

Python version

3.11

主要语言
Python
星标
4
派生
9
PR 合并指标
30 天内没有已合并 PR

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

auth0/auth0-api-python 的其他 Issue

查看 auth0/auth0-api-python 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。