SecureCredentialsManager serves expired access tokens for up to an hour after the autumn DST transition

未关闭
#1,113 1 条评论 1 个 reaction 已指派 1 人 在 GitHub 查看

维护者通常 1 天内回复

@utkrishtsahu 已经在做这个了。

开始于 2026年11月4日。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
57/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
android, kotlin

调研方向

Start with GsonProvider and the SecureCredentialsManager.saveCredentials and continueGetCredentials paths named in the report; inspect the existing credentials manager tests for date serialization and expiry checks. Reproduce the repeated-hour round trip using the supplied date format and compare the saved and restored expiresAt. Done means expiry survives the save/load round trip across the DST transition and the manager refreshes an expired token.

由索引模型根据 Issue 内容生成。

描述

bug
Checklist
Description

GsonProvider configures Gson with

private const val DATE_FORMAT = "yyyy-MM-dd'T'HH:mm:ss.SSS'Z'"
...
.setDateFormat(DATE_FORMAT)

The Z is a quoted literal and no TimeZone is set, so Date values are serialized as local wall-clock time that looks like UTC. SecureCredentialsManager.saveCredentials stores gson.toJson(credentials), and continueGetCredentials later does gson.fromJson(json, OptionalCredentials::class.java) and uses credentials.expiresAt.time to decide whether the access token is still valid (willExpire).

On the night daylight saving time ends, the local hour between 02:00 and 03:00 occurs twice. An expiresAt that falls in the first occurrence (summer time) is written as, for example, 2026-10-25T02:35:16.000Z. When it is parsed back, SimpleDateFormat resolves the ambiguous wall time to standard time, which is one hour later (shown below on OpenJDK 17; the production data from Android devices shows the same one-hour shift). The manager therefore believes the access token is valid for one more hour and keeps returning it. With minTtl = 300 the SDK only refreshes after real expiry + 55 minutes. Every API call in that hour fails with 401, while getCredentials reports success, so an app that trusts it keeps sending the stale token.

Note that hasValidCredentials is not affected: it reads the epoch value stored separately under KEY_EXPIRES_AT. Only the decision inside continueGetCredentials uses the date that went through the JSON round trip, so the two checks disagree during that hour.

Expected: expiresAt survives the save/load round tripST transitions. Storing epoch milliseconds, or settingthe Gson date format's time zone to UTC (and using a real X/Z pattern), would fix it.

This is distinct from auth0/auth0-flutter#286 and auth0/auth0-flutter#427, which fixed the plugin's conversion of expiresAt for Dart but
not the native round trip inside `SecureCredentialsManarts: #695, #757.

Reproduction

Round trip with the SDK's exact format (OpenJDK 17, zonded 2026-10-25 01:00 UTC):

import java.text.SimpleDateFormat; import java.util.*;
public class DstTest { public static void main(String[]
  TimeZone.setDefault(TimeZone.getTimeZone("Europe/Amsterdam"));
  SimpleDateFormat f = new SimpleDateFormat("yyyy-MM-dde.US); // GsonProvider.DATE_FORMAT
  SimpleDateFormat utc = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss'Z'", Locale.US); utc.setTimeZone(TimeZone.getTimeZone("UTC"));
  long base = 1792886400L * 1000; // 2026-10-25T00:00:0
  for (long o : new long[]{-60_000L, 0L, 2116_000L, 3540_000L, 3600_000L, 5640_000L}) {
    Date d = new Date(base + o); String s = f.format(d)
    System.out.printf("real=%s stored=\"%s\" parsedBack=%s shiftMin=%+d%n",
        utc.format(d), s, utc.format(back), (back.getTi0);
  }
}}

Output:

real=2026-10-24T23:59:00Z stored="2026-10-25T01:59:00.000Z" parsedBack=2026-10-24T23:59:00Z shiftMin=+0
real=2026-10-25T00:00:00Z stored="2026-10-25T02:00:00.000Z" parsedBack=2026-10-25T01:00:00Z shiftMin=+60
real=2026-10-25T00:35:16Z stored="2026-10-25T02:35:16.000Z" parsedBack=2026-10-25T01:35:16Z shiftMin=+60
real=2026-10-25T00:59:00Z stored="2026-10-25T02:59:00.000Z" parsedBack=2026-10-25T01:59:00Z shiftMin=+60
real=2026-10-25T01:00:00Z stored="2026-10-25T02:00:00.000Z" parsedBack=2026-10-25T01:00:00Z shiftMin=+0
real=2026-10-25T01:34:00Z stored="2026-10-25T02:34:00.000Z" parsedBack=2026-10-25T01:34:00Z shiftMin=+0

Every expiry inside the repeated hour comes back one hour late; everything else is unchanged.

Expected steps on a device (derived from the production observation, not yet re-run in a lab):

  1. Set the device zone to any zone that observes DST and the date to shortly before the autumn transition.
  2. Log in so that the access token's expiresAt falls inside the repeated hour (first occurrence).
  3. After that time has passed, call credentialsManager.getCredentials().
  4. It returns the expired access token instead of refreshing, until roughly expiresAt + 1h - minTtl.

The round trip above reproduces consistently; on devices it is only observable on the transition night.

Additional context

Observed in production on 2026-10-25 via auth0_flutter 2.6.2 (which depends on com.auth0.android:auth0:3.21.0): between 00:00 and 01:55 UTC, about 1,100 Android devices sent expired access tokens to our API every 15 seconds and received 401s. Each device was stuck for 50 to 55 minutes (token lifetime 144 min, minTtl 300 s). Only tokens expiring between 00:00 and 01:00 UTC (02:00 to 03:00 local, the repeated hour) were affected; the Auth0 tenant log shows the corresponding dip in refresh-token exchanges and no failures. The same code is present on main and in 4.2.0.

Auth0.Android version

3.21.0 (via auth0_flutter 2.6.2); GsonProvider unchanged in 4.2.0

Android version(s)

13, 14

主要语言
Kotlin
星标
303
派生
182
平均合并
18 小时 42 分钟
30 天内合并 PR
36

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

auth0/Auth0.Android 的其他 Issue

查看 auth0/Auth0.Android 的全部 Issue

相似的 Issue

更多 Kotlin Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。