[Question] [Feature Request] __matmul__, Internal Type Hinting
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 25/100
- Issue 类型
- 功能
- 描述清晰度
- 需要澄清
- 活跃度
- 停滞
- 技术栈
- python
调研方向
首先检查 arrayfire.Array、set_backend()、clibrary.get() 和 af.get_devicr_info() 周围的 Python 绑定,然后查看现有公共方法是如何公开和测试的。在进行任何更改之前,明确项目是否需要 matmul、运行时封装器和静态类型提示。对于选定的公共 API,当范围达成一致、类型定义保持一致且行为得到验证时,即视为完成。
由索引模型根据 Issue 内容生成。
描述
I wanted to add support for @ operation in python. The __matmult__ operation, that's how it's overloaded, in the arrayfire.Array class.
It's a simple monkey patch on user code. But it'd be nice if it was official.
I went to my local source code and added it, but I wanted to start learning the internal more and maybe do some contribution. Just wondering if it's not redundant or unwanted.
I saw that the internal Python types aren't hinted properly.
The set_backend() takes a string, but that's primitive obsession. It should take a string litteral list.
from typing import Literal
backend: Literal["cuda", "opencl", "cpu"]
Or it should take an Enum.
And other functions.
or clibrary.get() returns a None. That's just due to Lazy Loading.
But a Typed Python interface could exist. Some wrapper python class might be needed so that the type of the exposed code is visible.
All of this would help learning by simply using the autocomplete features of the IDE or text editor.
I hope each backend offers at least some common interface. It should, as the goal of arrayfire is hardware agnostism.
So, every method should be discoverable by the linter at "code editing" time. Just put _ and __ if it's really private.
So get().af wouldn't cause false linting errors.
Anyway, I might get into it if I have time. It seems like a nice contribution, and a nitpick of mine.
the typing package nd TYPE/CHECKING, and simple wrappers are quite powerful.
However, I know that you might not want to expose internal details at all, and so might have purposly not the type hinting of everything. But it's also possible that doing so is just a tedious boilerplate. I'd be fine with doing said tedious boilerplate to make it easier to use and understand.
So, if it's by choice that there isn't any type hinting and wrapper, then I won't do it. But If it's something you'd be interested in, I might do some work on it.
Also there was a bug with af.get_devicr_info(), it seems to give the default device, not active device. Tested it with my cpu graphics card and amd graphics card on arch linux. I'll edit this section once I'm back on my PC. (Away right now).
- 主要语言
- Python
- 星标
- 422
- 派生
- 63
- PR 合并指标
- 30 天内没有已合并 PR
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
arrayfire/arrayfire-python 的其他 Issue
-
难度 5/5 一周以上 新手友好度 25/100
arrayfire/arrayfire-python#270 ·
-
难度 4/5 3-5 天 新手友好度 35/100
arrayfire/arrayfire-python#269 ·
-
难度 4/5 3-5 天 新手友好度 38/100
arrayfire/arrayfire-python#268 · 1 条评论 ·
-
难度 3/5 1-2 天 新手友好度 48/100
arrayfire/arrayfire-python#267 · 1 条评论 · 1 个 reaction ·
-
难度 3/5 1-2 天 新手友好度 45/100
arrayfire/arrayfire-python#266 ·
查看 arrayfire/arrayfire-python 的全部 Issue
相似的 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 90/100
learningequality/ricecooker#747 ·
-
难度 2/5 1-3 小时 新手友好度 68/100
BSData/horus-heresy-3rd-edition#3171 ·
-
enhancement
难度 2/5 1-3 小时 新手友好度 72/100
-
难度 2/5 1-3 小时 新手友好度 76/100
run-llama/llama_index#23199 ·
-
难度 2/5 1-3 小时 新手友好度 84/100
KhronosGroup/glTF-Blender-IO#2769 ·