[Bug] QueryMessage ignores the request's pagination fields and echoes a scroll_id it never issues

未关闭
  • 哪里不对？
#11,369 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

@iloveeyjafjalla 已经在做这个了。

开始于 2026年10月12日。

  • #11370 来自 @iloveeyjafjalla —— 未关闭

评估

难度
1/5
预计耗时
1-3 小时
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
停滞
技术栈
java
领域
api

调研方向

Read the QueryMessage implementation and the ListMessageRequest and ListMessageResponse proto fields cited in the issue, then check §8 in docs/proxy-admin.md and docs/proxy-admin-zh.md. Reproduce with page_size: 1 and a second-page request. Done means the supported page-size cap is honored, unsupported page numbers and scroll IDs return BAD_REQUEST without echoing a cursor, and both docs describe the boundary.

由索引模型根据 Issue 内容生成。

描述

Before Creating the Bug Report
  • I found a bug, not just asking a question, which should be created in GitHub Discussions.
  • I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.
  • I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.
Runtime platform environment

OS: any (proxy module, admin gRPC surface)

RocketMQ version

branch: develop
Git commit id: 9ea2ccdc2b41445aee5e177e14e501d606f5a1ed (2026-10-08)

JDK Version

Compiler: Temurin 1.8.0_504 (target 1.8, same as CI)

Describe the Bug

QueryMessage accepts the request's pagination fields and then ignores them, while answering OK.

The proto declares page-style pagination and a cursor:

// ListMessageRequest
// Page-style pagination parameters.
optional int32 page_num = 8;
optional int32 page_size = 9;
...
// ListMessageResponse
// Cursor to be passed back to fetch the next page.
optional string scroll_id = 3;

The implementation reads none of them: only max_message_nums is honored (defaulting to 32), and the response echoes the
request's scroll_id back:

int maxNums = request.getMaxMessageNums() > 0 ? request.getMaxMessageNums() : DEFAULT_MAX_MESSAGE_NUMS;
...
ListMessageResponse.Builder builder = ListMessageResponse.newBuilder().setStatus(ok());
if (request.hasScrollId()) {
    builder.setScrollId(request.getScrollId());
}

Consequences:

  • a caller that sets only page_size = 10 receives up to 32 messages (the default cap) instead of its page size;
  • a caller that asks for page_num = 2, or that passes the scroll_id from the previous response back, receives the same
    first page again with OK — there is no ordering or cursor behind it, so a paging client loops on the same data;
  • the echoed scroll_id claims a continuation exists that the proxy never issues.
Steps to Reproduce
  1. Run a proxy with grpcAdminServerEnable=true on a topic with more than one page of messages for a key.
  2. Call QueryMessage{message_key, page_size:1} — more than one message comes back.
  3. Call it again with page_num:2 (or with the scroll_id of the first response) — the same first page comes back with OK.
Expected behavior

The fields that can be honored are honored (a page_size acts as the result cap), and the ones the open-source broker cannot
serve — page_num beyond the first page and scroll_id, which both need a cursor the broker does not provide — are refused
with an explicit status instead of silently returning an unscoped page. scroll_id is not echoed back as if a cursor existed.

This is the rule the same RPC already applies to its unsupported search_key variants (subscription / lite_topic /
SEARCHKEY_NOT_SET → BAD_REQUEST) and the documented surface rule in docs/proxy-admin.md §8.

Actual behavior

OK with an unscoped first page; page_size ignored; a scroll_id that cannot fetch anything echoed back.

Additional context

Fix: cap the result by page_size when it is set, refuse page_num > 1 and any scroll_id with BAD_REQUEST, and document
the boundary in docs/proxy-admin.md / docs/proxy-admin-zh.md §8.

主要语言
Java
星标
22.7k
派生
12k
平均合并
3 天 18 小时
30 天内合并 PR
17

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

apache/rocketmq 的其他 Issue

查看 apache/rocketmq 的全部 Issue

相似的 Issue

更多 Java Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。