[Feature] Split the table hierarchy and materialize the store a table is served by
维护者通常 3 天内回复
评估
调研方向
The issue describes changes across Table, FileStoreTable, FormatTable, SystemTable, RestCatalog::GetTable, and the table scan/read paths, but names no source files or tests. Start by locating those definitions and the existing table hierarchy, then read the open pull request #447 to understand the work already underway. Done means the hierarchy and file system behavior match the described solution and the affected tests pass.
由索引模型根据 Issue 内容生成。
描述
Search before asking
- I searched in the issues and found nothing similar.
Motivation
A single Table class dispatched everything: the differences between managed, format, and system tables lived in if branches inside one 1400-line table.cpp, every operator call (NewScan/NewRead/NewWrite/NewCommit) re-merged a fresh options map and re-parsed CoreOptions — the state Java Paimon's AbstractFileStore parses exactly once — and the file system a table is served by was resolved before the schema's access configuration was even known.
The ambiguity produced real defects:
RestCatalog::GetTable(Identifier("sys", "tables"))returned the read-only schema of a global system table but still passed it to the managed-table load, which statically cast it toTableSchemaand calledPrimaryKeys()on it — undefined behavior.- The operator factory path built the file system from the context options alone; a schema carrying remote backend and credentials (delivered through
SetTableSchema()) was therefore served by the default local backend, and reading its data failed. - The
$roand$audit_logviews built their underlying scans and reads from the context's file system, ignoring the one their table was opened with; a context that also carried a file-system scheme map was then refused outright (WithFileSystem()andWithFileSystemSchemeToIdentifierMap() cannot be used together). FileStoreTable::Copyhalf-applied abranchoption: it was written into the copy's schema options but never moved the copy's branch, so the consistency check reported the branch actually served as a conflict and let a mismatched one through.- An option conflict between a context and a held table was reported with both raw values in the error message, leaking credentials into logs.
- With REST data tokens enabled, the system tables a
GetTable()call returned were bound to the catalog-wide file system, so$snapshotsand friends read the data table's files without the table-level credentials and failed.
Solution
- Split the hierarchy:
Tablebecomes an abstract base (NewXxxpure virtual, a new virtualCopy(dynamic_options)), implemented byFileStoreTable— withAppendOnlyFileStoreTable/PrimaryKeyFileStoreTablesubclasses — byFormatTable(which now derives fromTableand owns its own assembly, absorbingformat_table_loader), and by theSystemTablefamily. - Introduce a
FileStore(the counterpart of Java'sAbstractFileStore) that materializesCoreOptionsonce at construction, resolves the served file system after the options are known (schema-carried access configuration names its own backend; the caller's explicit file system wins over it), carries the file-system scheme map, and hosts the operator factories (NewPathFactory,NewSnapshotManager,NewManifestList, ...).FileStoreTableholds its schema/snapshot managers and its branch;SwitchToBranchderives a table of another branch. - Give context options one clear place to speak: the load. A factory-path load (
TableScan::Create(ctx)etc.) merges the context options over the schema's throughTable::Copy()— a table is the product of its load — whileNewXxxon a held table refuses a contradicting option (option 'X' is 'A' in the context but 'B' on the table, values redacted).Copynever half-appliestypeorbranch; managers are handed over unless a file-system option among the copy's changes the resolution, in which case fresh ones are built. - Fix the surrounding defects:
RestCatalog::GetTableservessys-database global system tables locally and binds per-table system tables toGetTableFileSystem();$ro/$audit_log/$binlogprefer the context's file system and fall back to the table's only when the context names neither a file system nor a scheme map; the scan-fallback read context merges the load's dynamic options so the fallback reader recognises what the main one does.
Anything else?
- Options a schema carries that do not parse now fail at table-build time rather than at the first operator; a table opened with neither a schema-carried backend nor a caller file system is served by the default local one instead of holding a null one.
- No storage format or protocol change. Public API changes:
Tableis abstract (constructor protected,Name/FullName/NewXxx/Copyvirtual,Table::CurrentBranch()replaced byFileStoreTable::CurrentBranch()),FormatTablederives fromTable(staticFormatTable::Copy(table, options)becomes the virtualTable::Copy(options),GetLocation()becomesGetRootPath()), andFileStoreTable::SwitchToBranchis new.
Are you willing to submit a PR?
- I'm willing to submit a PR!
- 主要语言
- C++
- 星标
- 70
- 派生
- 36
- 平均合并
- 3 天 16 小时
- 30 天内合并 PR
- 38
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
apache/paimon-cpp 的其他 Issue
-
bug
难度 4/5 3-5 天 新手友好度 57/100
apache/paimon-cpp#454 ·
维护者通常 3 天内回复
-
enhancement
难度 5/5 一周以上 新手友好度 35/100
apache/paimon-cpp#452 ·
维护者通常 3 天内回复
-
难度 5/5 一周以上 新手友好度 8/100
apache/paimon-cpp#435 · 2 条评论 ·
维护者通常 3 天内回复
-
enhancement
难度 5/5 一周以上 新手友好度 35/100
apache/paimon-cpp#410 ·
维护者通常 3 天内回复
-
enhancement
难度 5/5 一周以上 新手友好度 25/100
apache/paimon-cpp#409 ·
维护者通常 3 天内回复
查看 apache/paimon-cpp 的全部 Issue
相似的 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 76/100
aristocratos/btop#1945 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 79/100
boykopovar/AnyPS5#11291 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
k2-fsa/sherpa-onnx#4100 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
Mod: Part Design Topic: User Interface
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 1 天内回复