AbstractConfiguration#initialize - making two passes generates invalid configuration - no check if initialization has already been performed
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
从 AbstractConfiguration#initialize 和 Configuration#doConfigure 开始，然后查看报告中提到的现有 Configurator1Test 用例。复现先执行 builder.build()、再执行 config.initialize() 的顺序，并验证第二次初始化不会丢弃已配置的 CONSOLE 和 RollingFile appenders 或其他嵌套配置。
由索引模型根据 Issue 内容生成。
描述
Log4j 2.24.3
Repeated calls to the Configuration#doConfigure method discard appenders (and maybe other inforrmation).
In my example, I have a configuration with two defined appenders ("CONSOLE" and "RollingFile").
Taken from another test case, lets assume I use a BuiltConfiguration with a ConfigurationBuilder and create the and initialized configuration and then initialize it again (the first initialization happens in the build method if I don't call builder.build(false). (Admittedly, this is redundant and strictly incorrect; however, it is possible and I found an instance of this in the Configurator1Test unit-test.)
final Configuration config = builder.build();
config.initialize();
In the first pass, the rootNode tree is processed and through a call to PluginElementVisitor#visit(....) all nested nodes are removed and the top level child node is assigned an built object.
If a second pass is made, the config.initialize() method performs no check to see if it has already been initialized (State.INITIALIZED or later). This results in another runthrough of doConfigure() and now the child nodes are missing because they have been visited and removed,
Here before the 2nd-pass of createConfigurationon the "Appenders" node:
Now however, due to the missing child information, the object list of configured appenders is empty and the two previously defined appenders are gone.
So the second configure cleared the previous run's appenders (and possibly other nested configuration).
I think the easy solution would be to test the state in the initialize method and if not INITIALIZING just log and return; however, I don't know if that would have other side-efffects.
- 主要语言
- Java
- 星标
- 3.6k
- 派生
- 1.8k
- 平均合并
- 5 天 6 小时
- 30 天内合并 PR
- 24
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
apache/logging-log4j2 的其他 Issue
-
waiting-for-maintainer
难度 2/5 1-3 小时 新手友好度 63/100
apache/logging-log4j2#4475 ·
维护者通常 1 天内回复
-
Migrate `log4j-api-test` tests to JUnit 5可能重新可做 关联的 PR 已关闭且未合并。 未关闭api priority: P3 tests waiting-for-maintainer
难度 2/5 1-3 小时 新手友好度 68/100
apache/logging-log4j2#4430 · 1 条评论 ·
维护者通常 1 天内回复
-
`Rfc5424Layout` does not escape the `newLineEscape` replacement in SD-PARAM-VALUE可能已有人在做 @lunarbae628 于 5 天前认领。 未关闭bug layouts priority: P3
apache/logging-log4j2#4464 · 2 条评论 · 已指派 1 人 ·
维护者通常 1 天内回复
-
configuration enhancement layouts
难度 4/5 3-5 天 新手友好度 55/100
apache/logging-log4j2#4463 ·
维护者通常 1 天内回复
-
`evaluateOnStartup="true"` saves logs under wrong file names after missing scheduled roll可能重新可做 关联的 PR 已关闭且未合并。 未关闭appenders:Rolling bug priority: P1 waiting-for-maintainer
难度 3/5 1-2 天 新手友好度 30/100
apache/logging-log4j2#4449 ·
维护者通常 1 天内回复
查看 apache/logging-log4j2 的全部 Issue
相似的 Issue
-
[Bug]: Nullable implicit operator on string extensible enums still throws for a null string可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭bug emitter:client:csharp
难度 2/5 1-3 小时 新手友好度 84/100
microsoft/typespec#12572 · 1 条评论 · 1 个 reaction ·
维护者通常 1 天内回复
-
[BUG]: Java SDK MountRequest always sends update-optional fields, resetting stored mount settings未关闭bug
难度 2/5 1-3 小时 新手友好度 75/100
维护者通常 1 天内回复
-
GCC 15.2: -Wcast-qual warning - cast discards const qualifier from pointer target type (H5trace.c)未关闭
难度 2/5 1-3 小时 新手友好度 73/100
维护者通常 1 天内回复
-
[Bug] RemotingHelper.connect swaps the socket send and receive buffer configuration可能已有人在做 @amalsaidov 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
needs-area-label
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 2 天内回复