Make manifest records schema-aware to avoid field mismatches across format versions
@kevinjqliu 已经在做这个了。
开始于 2026年9月12日。
评估
这个 Issue 还没有评估数据。
描述
Apache Iceberg version
main (development), commit 308768d99
Please describe the bug 🐞
Manifest records do not retain their schema, and their property getters use hard-coded field positions. When the in-memory record layout differs from the file schema, this can cause incorrect field access or silent data loss during serialization.
For example, referenced_data_file has field ID 143 in both v2 and v3, but its zero-based position differs:
| Field | v2 position | v3 position |
|---|---|---|
first_row_id |
Not present | 16 |
referenced_data_file |
16 | 17 |
This causes two problems:
- Writing a v3 record to a v2 file:
DataFile.from_args()defaults to the v3 layout. When writing it throughAvroOutputFilewith a v2 file schema, omittingrecord_schemamakes the writer read position 16 instead of 17 forreferenced_data_file. Iffirst_row_idis null, a non-null reference is silently written as null. Explicitly supplying the v3 record schema enables the existing field-ID projection and preserves the value. - Accessing a v2 record:
DataFile.from_args(_table_format_version=2, ...)stores the reference at position 16, but the getters still assume v3 positions. Consequently,first_row_idreturns the reference path andreferenced_data_fileraisesIndexError. Reading a v2 file intoDataFilewithout projecting to v3 has the same mismatch.
The normal manifest read/write helpers already supply the v3 projection. However, correctness still depends on callers separately tracking the in-memory layout and supplying the matching schema.
Proposed behavior
Records should keep the schema that describes their in-memory layout. Getters should use field IDs, not assume a particular version’s field positions.
When reading, use the schema from the file. If the read projects into another schema, retain that schema on the resulting record.
When writing, callers should only need to specify the target format version, or file_schema when using AvroOutputFile. IO should determine the input layout from the record and handle the conversion before encoding. This needs to account for nested records and partition fields, not just the top-level record.
We shouldn’t need to pass record_schema just to prevent a field from being read at the wrong position. Keep it supported for callers that explicitly provide it.
For the example above, writing a default v3 record to a v2 file should preserve referenced_data_file without passing record_schema. If a conversion isn’t supported, raise an error rather than silently writing the wrong value.
Willingness to contribute
N/A
- 主要语言
- Python
- 星标
- 1.1k
- 派生
- 589
- 平均合并
- 2 天 2 小时
- 30 天内合并 PR
- 70
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
apache/iceberg-python 的其他 Issue
-
kind:bug
难度 1/5 1 小时以内 新手友好度 92/100
apache/iceberg-python#4006 ·
-
难度 2/5 1-3 小时 新手友好度 78/100
apache/iceberg-python#3996 ·
-
bug
难度 2/5 1-3 小时 新手友好度 72/100
apache/iceberg-python#3979 ·
-
难度 2/5 1-3 小时 新手友好度 78/100
apache/iceberg-python#3885 ·
-
[Bug] PyArrowFileIO fails to propagate s3.ssl.ca-cert to pyarrow.fs.S3FileSystem tls_ca_file_path 未关闭
难度 2/5 1-3 小时 新手友好度 76/100
apache/iceberg-python#3866 · 1 条评论 ·
查看 apache/iceberg-python 的全部 Issue
相似的 Issue
-
enhancement
难度 2/5 1-3 小时 新手友好度 70/100
canonical/paas-charm#368 · 1 条评论 ·
-
难度 2/5 1-3 小时 新手友好度 75/100
-
tech debt
难度 2/5 1-3 小时 新手友好度 75/100
-
难度 1/5 1 小时以内 新手友好度 90/100
StevenBlack/hosts#3256 ·
-
难度 1/5 1 小时以内 新手友好度 90/100
qualcomm/qai-appbuilder#275 ·