[Build] Add ASF license headers to config files that allow comments

未关闭 适合新手
#4,124 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

@Swatantra-66 已经在做这个了。

开始于 2026年10月6日。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
72/100
Issue 类型
功能
描述清晰度
描述清楚
活跃度
活跃
技术栈
java, javascript, yaml

调研方向

从列出的七个配置文件和 Mockito 插件文件开始,检查它们现有的内容以及仓库的标准 ASF 头部格式。将头部添加到这些文件中,并保持列出的 NOTICE、第三方、生成文件和无注释文件不变。运行加载 inline mock maker 的测试,确认 # 行会被跳过。

由索引模型根据 Issue 内容生成。

描述

enhancement
Feature Request

Some files in the repo have no ASF license header, even though their formats allow # comments. korandoru/hawkeye doesn't flag them in CI because it has no comment-style mapping for these files. It lists them as "unknown files" and skips them. This came up while verifying the 1.7.7-rc1 source release.

Files that could have the standard ASF header added (checked against main):

  • .yamllint
  • .prettierignore
  • javascript/.prettierignore
  • javascript/.npmrc
  • .github/CODEOWNERS
  • java/fory-core/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker
  • java/fory-latest-jdk-tests/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker

ASF policy does not require headers on trivial config files like these, so this is a consistency improvement, not a release blocker. Mockito skips # lines in plugin files, but the tests that load the inline mock maker should be run after the change to confirm it.

Files that should stay without an ASF header

For reference, the other unheaded files that hawkeye skips fall into these groups:

  • NOTICE files (NOTICE, dart/packages/fory/NOTICE, java/*/src/main/resources/META-INF/NOTICE)
  • Third-party code that keeps its original header (bazel/cython_library.bzl, which LICENSE lists)
  • Formats without comment syntax: javascript/.prettierrc, swift/.swift-format (both JSON), swift/Package.resolved (generated by SwiftPM), and .bazelversion (read as a bare version string)
Is your feature request related to a problem? Please describe

Not a problem as such. Adding headers where the format allows makes header coverage consistent.

主要语言
Java
星标
4.6k
派生
470
平均合并
9 小时 28 分钟
30 天内合并 PR
33

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

apache/fory 的其他 Issue

查看 apache/fory 的全部 Issue

相似的 Issue

更多 Java Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。