[Bug][jenkins] Incremental collection skips the stages of builds that finish after the next sync
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start in backend/plugins/jenkins/tasks/stage_collector.go and inspect the incremental filters in both the single-job and multi-branch collectors. Reproduce a build that spans two collections, then verify that an incremental run finds its stages and that full and incremental collections produce the same stage records.
由索引模型根据 Issue 内容生成。
描述
Search before asking
- I had searched in the issues and found no similar issues.
What happened
With incremental collection, collectApiStages never collects the stages of a Jenkins build that started before the previous collection and finished after it. Those builds end up in _tool_jenkins_builds with a result, but with no rows in _raw_jenkins_api_stages / _tool_jenkins_stages, so their deployment stages never become cicd_tasks and the deployments are missing from DORA.
Cause (backend/plugins/jenkins/tasks/stage_collector.go, both the single-job and the multi-branch collectors):
if apiCollector.IsIncremental() && apiCollector.GetSince() != nil {
clauses = append(clauses, dal.Where(`tjb.start_time >= ?`, apiCollector.GetSince()))
}
The build collectors skip builds that are still running (buildObj["result"] != nil), so a build is stored the first time it is collected finished. For a build that started before since and finished after it, that happens in a later run, and the stage collector filters it out by start_time in that run and in every run after it. Nothing reports it.
This is common in pipelines that wait on an input step, e.g. a "rollback?" or "deploy to production?" approval left open for hours or days after the deploy.
Evidence from our instance (v1.0.3-beta15, 190 multi-branch scopes, daily collection):
| Build duration | Builds with stages, first (full) collection | Builds with stages, incremental runs since |
|---|---|---|
| < 6 h | 508 / 561 | 680 / 711 |
| 6–24 h | 25 / 25 | 5 / 68 |
| > 24 h | 698 / 814 | 13 / 389 |
For example, front-channel/master#111 (SUCCESS, 148 h) is in _tool_jenkins_builds and has no row in _raw_jenkins_api_stages. The collector is unchanged on main.
What do you expect to happen
An incremental run collects the stages of every build that became available since the previous run, i.e. every build that finished since then, whenever it started. A full and an incremental collection should produce the same stages.
How to reproduce
- Jenkins scope with incremental collection (any sync after the first).
- Start a pipeline build that waits on an
inputstep, and let a collection run while it waits. - Answer the input after that collection so the build finishes, then run another collection.
- The build is in
_tool_jenkins_builds, but_tool_jenkins_stageshas no rows for it.
Anything else
Proposed fix, PR to follow: filter on the finish time, tjb.timestamp + tjb.duration >= since. Both columns are milliseconds, so it is plain arithmetic on MySQL and PostgreSQL, no dialect-specific date functions. It is a superset of the current condition (duration ≥ 0).
Version
v1.0.3-beta15 (collector unchanged on main)
Are you willing to submit PR?
- Yes I am willing to submit a PR!
Code of Conduct
- I agree to follow this project's Code of Conduct
- 主要语言
- Go
- 星标
- 3.1k
- 派生
- 812
- 平均合并
- 2 天 8 小时
- 30 天内合并 PR
- 50
环境准备
我们还没有检查这个项目的环境配置文件。先看它的 README,通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
apache/devlake 的其他 Issue
-
type/bug
难度 1/5 1 小时以内 新手友好度 95/100
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 68/100
维护者通常 1 天内回复
-
type/bug
难度 4/5 3-5 天 新手友好度 68/100
维护者通常 1 天内回复
-
[Feature][Plugins] Add YouTrack plugin可能已有人在做 @tpam28 于 3 天前认领。 未关闭
难度 5/5 一周以上 新手友好度 32/100
apache/devlake#9168 · 1 条评论 · 已指派 1 人 ·
维护者通常 1 天内回复
-
[Bug][Jira/DORA] Extra JQL does not isolate projects sharing the same Jira board可能已有人在做 @veetmoradiya3628 于 8 天前认领。 未关闭
难度 5/5 一周以上 新手友好度 35/100
apache/devlake#9151 · 2 条评论 · 已指派 1 人 ·
维护者通常 1 天内回复
相似的 Issue
-
area: global bug dx priority: low
难度 2/5 1-3 小时 新手友好度 88/100
维护者通常 1 天内回复
-
enhancement
难度 2/5 1-3 小时 新手友好度 68/100
grafana/mcp-grafana#1267 ·
维护者通常 1 天内回复
-
automation models
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
coverage-gap good-first-pattern help wanted
难度 2/5 1-3 小时 新手友好度 78/100
GoogleCloudPlatform/k8s-aibom#114 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
txn2/mcp-data-platform#1984 ·
维护者通常 1 天内回复