Expose get_composite_estimate() on hll_sketch in the Python binding
还没有人认领这个 Issue。
评估
调研方向
从 src/hll_wrapper.cpp 开始,查找 get_estimate() 如何在 hll_sketch 上公开;将该绑定与 hll/include/hll.hpp 以及所引用的 Java HllSketch API 进行比较。当 Python 调用方可以调用 get_composite_estimate(),并且绑定的相关检查确认该方法可用且返回底层的复合估计值时,工作即告完成。
由索引模型根据 Issue 内容生成。
描述
Request
The Python binding exposes get_estimate() only. Both reference implementations additionally expose the estimator that gives an order-independent result, and we would like it available from Python:
get_composite_estimate()— public in C++ (hll/include/hll.hpp,hll_sketch_alloc::get_composite_estimate()) and in Java (HllSketch.getCompositeEstimate(), "This is less accurate than the getEstimate() method and is automatically used when the sketch has gone through union operations where the more accurate HIP estimator cannot be used.")
This is the only method we are asking for as binding parity, since it is the only one of the three discussed below that is public in both C++ and Java.
Use case, and why it matters from Python specifically
In datasketches-cpp#374 a maintainer explains that HLL carries two estimators — HIP, which is more accurate but order-dependent, and the composite estimator, which is order-independent — and that:
The choice of estimator here lets you make a trade-off between accuracy and order-independence.
with getCompositeEstimate() named as the way to take the order-independent side. That guidance is clear and we would like to follow it.
From Python we currently cannot. On datasketches==5.2.0, dir(hll_sketch) returns 18 public methods, none of which selects an estimator, and src/hll_wrapper.cpp on main binds no such method. So a Python caller who needs reproducibility across merge orders has no supported way to ask for it, while the same program in C++ or Java does.
Minimal illustration — one sketch, one fixed multiset of 3,000 distinct strings, four insertion orders, no union anywhere:
datasketches 5.2.0 · lg_k=12 · HLL_8
sorted est=2993.822394 HipAccum=2993.82 KxQ0=2616.65 NumAtCurMin=1972
shuffle(1) est=2982.892501 HipAccum=2982.89 KxQ0=2616.65 NumAtCurMin=1972
shuffle(2) est=2995.259277 HipAccum=2995.26 KxQ0=2616.65 NumAtCurMin=1972
shuffle(3) est=2965.637291 HipAccum=2965.64 KxQ0=2616.65 NumAtCurMin=1972
from datasketches import hll_sketch, tgt_hll_type
items = [f"item-{i}" for i in range(3000)]
def build(order):
s = hll_sketch(12, tgt_hll_type.HLL_8)
for x in order: s.update(x)
return s
# same multiset, different insertion order -> different get_estimate()
Register state (KxQ0, NumAtCurMin, read from to_string()) is identical across all four; the reported estimate tracks HipAccum. Same-order runs are byte-for-byte deterministic across fresh processes. This is the documented HIP behaviour and we are not reporting it as a defect — it is simply the use case for wanting the other estimator.
Two related observations, offered separately
-
get_hip_estimate()— mentioned in #374, but it does not appear in the current public C++ or Java API, so we are not requesting it as parity. Noting it only so the omission is deliberate rather than an oversight in this request. -
Out-of-order state —
is_out_of_order_flag()is private in C++ and absent from the Java public API, so this is a new-API question rather than parity. It would nonetheless be useful to a caller: it is the only way to know whether a returnedget_estimate()is currently order-dependent. Today it is reachable from Python only by string-matchingto_string(). Entirely at your discretion, and happy to drop it.
A documentation question, if it's welcome here
The Sketch Criteria page lists as a required property:
Order Insensitive: Results independent of item presentation order
Read literally, that is difficult to reconcile with #374 in the case where getEstimate() returns HIP — including for a single sketch fed raw input, as above, with no union involved. Would it be worth qualifying that wording for HLL when the HIP estimator is in use? Happy to open this separately if it would be better tracked on its own.
Environment
datasketches 5.2.0 (current release) · Python 3.12 · lg_k=12 · HLL_8
- 主要语言
- Jupyter Notebook
- 星标
- 46
- 派生
- 9
- PR 合并指标
- 30 天内没有已合并 PR
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
apache/datasketches-python 的其他 Issue
-
难度 3/5 1-2 天 新手友好度 35/100
apache/datasketches-python#65 · 3 个 reaction ·
-
难度 3/5 1-2 天 新手友好度 45/100
apache/datasketches-python#63 · 2 条评论 ·
-
难度 1/5 1 小时以内 新手友好度 55/100
apache/datasketches-python#46 · 2 条评论 ·
-
难度 5/5 一周以上 新手友好度 25/100
apache/datasketches-python#21 · 2 条评论 ·
查看 apache/datasketches-python 的全部 Issue
相似的 Issue
-
bug CLI custom-model
难度 2/5 1-3 小时 新手友好度 75/100
-
bug confirmed issue
难度 2/5 1-3 小时 新手友好度 75/100
open-webui/open-webui#30750 · 1 条评论 ·
-
VerificationGate: ATTRIBUTION quote guard never matches a normal quotation (\b around the quote) 未关闭
难度 2/5 1-3 小时 新手友好度 75/100
danielmiessler/LifeOS#2234 ·
-
难度 2/5 1-3 小时 新手友好度 65/100
-
bug
难度 2/5 1-3 小时 新手友好度 75/100