Parser: target module layout for splitting src/parser/mod.rs

未关闭
  • 哪里不对？
#2,650 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
35/100
Issue 类型
重构
描述清晰度
基本清楚
活跃度
活跃
技术栈
rust
领域
backend

调研方向

Start with src/parser/mod.rs and compare its structure with src/ast/; the proposed module layout and migration order are listed in this issue. Read the parent issue #2591 and inspect the existing parser files named in the layout to understand shared helpers and module boundaries. Done means the parser is split into the proposed modules in the listed order, with parsing behavior preserved.

由索引模型根据 Issue 内容生成。

描述

Part of #2591, scoped to the parser only.

#2591 agreed on a series of pure-move PRs but did not fix the target layout. #944 and #1581 both went per-statement (~35 files, one per top-level keyword). #1581 stalled as one large
PR, and its author noted that shared helpers ended up placed arbitrarily.

Proposed layout

A flat layout mirroring src/ast/, so a struct in ast/ddl.rs is parsed in parser/ddl.rs:

src/parser/
  mod.rs        Parser struct, token cursor, errors, identifiers, lists, statement dispatch
  expr.rs       precedence climbing, prefix/infix, function calls, literals
  query.rs      SELECT, set ops, CTEs, FROM/joins, windows
  data_type.rs
  ddl.rs        CREATE TABLE, columns, constraints, DROP   (existing create.rs, alter.rs stay beside)
  dml.rs        INSERT / UPDATE / DELETE                   (existing merge.rs stays beside)
  dcl.rs        GRANT / REVOKE / roles / policies
  statement.rs  SHOW / SET / DECLARE / transactions / EXPLAIN / misc

Order

Smallest conflict surface first:

  • dcl
  • dml
  • data_type
  • statement
  • ddl
  • query
  • expr

@alamb @LucaCappelletti94 wdyt?

主要语言
Rust
星标
3.5k
派生
805
平均合并
2 天 3 小时
30 天内合并 PR
116

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 有 Pull Request 模板
  • 没有贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

apache/datafusion-sqlparser-rs 的其他 Issue

查看 apache/datafusion-sqlparser-rs 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。