Implement Spark-compatible `schema_of_variant_agg`
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start by reading the existing schema_of_variant implementation for the type lattice, mergeSchema and the Spark-type printer, since this aggregate must share them; then look at how other UDAFs are registered under crates/spark/src/function/aggregate/ or the planned variant/ module. The work is blocked in practice on the VARIANT Arrow representation proposed in the parse_json issue, so confirm that landed before starting. Reproduce the listed SQL examples and the VariantEndToEndSuite grouping cases in a new crates/sqllogictest/test_files/variant/schema_of_variant_agg.slt, and document the function with #[user_doc].
由索引模型根据 Issue 内容生成。
描述
Part of #273 and apache/datafusion-comet#7300.
What the function does
schema_of_variant_agg(v) is an aggregate. It merges the schemas of all non-NULL VARIANT values in the group and
returns the result as a STRING. The output format is the same as schema_of_variant: Spark SQL type syntax with
OBJECT<...> for objects. The argument must be VARIANT. The result is non-nullable and uses the default string
type. Added in Spark 4.0.0.
The buffer starts as VOID (NullType). Each row merges SchemaOfVariant.schemaOf(v) into it with
SchemaOfVariant.mergeSchema, and partial buffers are combined the same way. SQL NULL rows are skipped. The merge
and print rules are the ones in the schema_of_variant issue, so the two should share code.
Examples
SELECT schema_of_variant_agg(parse_json(j)) FROM VALUES ('1'), ('2'), ('3') AS tab(j);
-- BIGINT
SELECT schema_of_variant_agg(parse_json(j)) FROM VALUES ('{"a": 1}'), ('{"b": true}'), ('{"c": 1.23}') AS tab(j);
-- OBJECT<a: BIGINT, b: BOOLEAN, c: DECIMAL(3,2)>
SELECT schema_of_variant_agg(parse_json('{"a": [1, 2, 3]}'));
-- OBJECT<a: ARRAY<BIGINT>>
SELECT schema_of_variant_agg(parse_json(j)) FROM VALUES ('{"a": [1, 2, 3]}'), ('{"a": "banana"}') AS tab(j);
-- OBJECT<a: VARIANT>
SELECT schema_of_variant_agg(parse_json(j)) FROM VALUES ('{"a": "banana"}'), ('{"b": "apple"}') AS tab(j);
-- OBJECT<a: STRING, b: STRING>
SELECT schema_of_variant_agg(parse_json(j)) FROM VALUES ('{"a": "data"}'), (null) AS tab(j);
-- OBJECT<a: STRING>
SELECT schema_of_variant_agg(parse_json(j)) FROM VALUES (null), (null) AS tab(j);
-- VOID
SELECT schema_of_variant_agg(parse_json(j)) FROM VALUES ('{"a": null}'), ('{"a": null}') AS tab(j);
-- OBJECT<a: VOID>
SELECT schema_of_variant_agg(parse_json(j)) FROM VALUES
('{"hi":[]}'), ('{"hi":[{},{}]}'), ('{"hi":[{"it''s":[{"me":[{"a": 1}]}]}]}') AS tab(j);
-- OBJECT<hi: ARRAY<OBJECT<`it's`: ARRAY<OBJECT<me: ARRAY<OBJECT<a: BIGINT>>>>>>>
These come from the ExpressionDescription and VariantEndToEndSuite."schema_of_variant_agg". The suite builds
the inputs as DataFrames, and the queries above are the equivalent SQL.
Edge cases to test
- Grouping.
VariantEndToEndSuiteuses rowsidin 0..100 with{"a": [id]}whenid % 4 == 0and
{"a": ["id"]}otherwise:GROUP BY id % 2givesOBJECT<a: ARRAY<STRING>>andOBJECT<a: ARRAY<VARIANT>>;% 3givesOBJECT<a: ARRAY<VARIANT>>three times;% 4givesOBJECT<a: ARRAY<STRING>>three times andOBJECT<a: ARRAY<BIGINT>>once.
These exercise the multi-partition merge path.
- If every input is NULL the result is
VOID. With no input rows the buffer is never updated, so by code reading
the result is alsoVOID, not NULL, because the function is non-nullable. - A merge across rows behaves like a merge across array elements. For example,
BIGINTwithDOUBLEgives
DOUBLE, objects are unioned with sorted field names, and incompatible types giveVARIANT. See the full table
in theschema_of_variantissue. - Order independence: decimal widening, struct union and
VOIDabsorption are commutative. One exception, by code
reading, is struct merging throughfindTightestCommonType, which keeps the first field name when names are
equal case-insensitively (spark.sql.caseSensitive=false). The result could depend on the order of rows or
partitions, so do not test that case for determinism. - Field-name quoting with backticks follows
QuotingUtils.quoteIfNeeded. For example,!special!is quoted and
STRUCTis not. - Malformed input raises
MALFORMED_VARIANT(unsorted object fields) orUNKNOWN_PRIMITIVE_TYPE_IN_VARIANT, the
same asschema_of_variant. - Test a literal argument, a column argument,
GROUP BY, and use as a window aggregate if datafusion-spark
supports that for UDAFs.
Differences across Spark versions
- 3.x has no VARIANT.
- No differences between 4.0.4, 4.1.3 and 4.2.0.
Implementation notes
- Spark:
SchemaOfVariantAgg(aTypedImperativeAggregate[DataType]) in
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/variant/variantExpressions.scala. Spark
serializes the buffer asDataType.json, which is internal. - In DataFusion, write an
AggregateUDFImpl/Accumulatorwhose state is the in-progress Spark type tree. The
state can be a singleUtf8field, with the type serialized in any internal form.merge_batchapplies the same
mergeSchemaasupdate_batch. Reuse the type lattice and printer fromschema_of_variant. - DataFusion core and arrow-rs have no equivalent. Use
parquet_variant::Variantto decode values. This depends on
the VARIANT Arrow representation proposed in theparse_jsonissue. - apache/datafusion-comet#5438 tracks native Variant support in Comet.
- Put it under
crates/spark/src/function/aggregate/or the newvariant/module. Add
crates/sqllogictest/test_files/variant/schema_of_variant_agg.sltand document the function with#[user_doc].
This issue was generated by an LLM (Claude) from the Apache Spark source code and tests. Examples come from Spark's ExpressionDescription examples, test suites and .sql.out golden files, but please verify them against Spark before relying on them.
- 主要语言
- Rust
- 星标
- 7
- 派生
- 15
- 平均合并
- 16 小时 43 分钟
- 30 天内合并 PR
- 26
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
apache/datafusion-spark 的其他 Issue
-
enhancement
难度 2/5 1-3 小时 新手友好度 70/100
apache/datafusion-spark#287 ·
维护者通常 1 天内回复
-
enhancement good first issue
难度 2/5 1-3 小时 新手友好度 80/100
apache/datafusion-spark#266 ·
维护者通常 1 天内回复
-
[Bug] make_dt_interval returns NULL for more than about 1.49 million days, Spark returns the interval可能已有人在做 @Subodh-17 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 78/100
apache/datafusion-spark#109 ·
维护者通常 1 天内回复
-
enhancement
难度 5/5 一周以上 新手友好度 18/100
apache/datafusion-spark#299 ·
维护者通常 1 天内回复
-
enhancement
难度 4/5 3-5 天 新手友好度 35/100
apache/datafusion-spark#298 ·
维护者通常 1 天内回复
查看 apache/datafusion-spark 的全部 Issue
相似的 Issue
-
comp-rbac
难度 2/5 1-3 小时 新手友好度 68/100
ClickHouse/ClickHouse#131875 ·
维护者通常 1 天内回复
-
bug(python): read_transaction raises TypeError on a Rewrite with rewritten indices可能已有人在做 @Borg93 今天认领。 未关闭bug
难度 2/5 1-3 小时 新手友好度 75/100
lance-format/lance#11117 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 70/100
storytold/photocraft#15232 · 1 条评论 ·
维护者通常 1 天内回复
-
forge: fork preflight reads still send `requireCanonical: false`, which Rootstock rejects (-32603)可能已有人在做 @Ynyesto 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 72/100
foundry-rs/foundry#18485 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 70/100
bondybondbond/rushcut#238 · 1 条评论 ·