Implement Spark-compatible `bround`
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Read crates/spark/src/function/math/round.rs first, then compare with Spark's BRound/RoundBase in mathExpressions.scala. Generalise the existing integer and decimal helpers over the rounding mode, add the float shortest-decimal path, and wire ANSI overflow via datafusion.execution.enable_ansi_mode. Enable and extend the commented queries in crates/sqllogictest/test_files/math/bround.slt; done means that suite passes for the listed edge cases and the function carries #[user_doc].
由索引模型根据 Issue 内容生成。
描述
Part of #174 and apache/datafusion-comet#7300.
What the function does
bround(expr[, d]) rounds expr to d decimal places (default 0) using HALF_EVEN ("banker's") rounding. A negative d rounds to the left of the decimal point. It is BRound, a RoundBase with RoundingMode.HALF_EVEN, the same code as round except for the rounding mode. Available since 2.0.0.
expr accepts any numeric type and d is implicitly cast to INT and must be foldable (DATATYPE_MISMATCH.NON_FOLDABLE_INPUT otherwise). The result type equals the input type for TINYINT, SMALLINT, INT, BIGINT, FLOAT and DOUBLE. For DECIMAL(p, s) it is DECIMAL(min(p - s + 1 + min(s, d), 38), min(s, d)) when d >= 0 and DECIMAL(min(max(p - s + 1, -d + 1), 38), 0) when d < 0. The result is always nullable; a NULL d returns NULL without evaluating expr.
Examples
SELECT bround(2.5, 0);
-- 2 decimal(2,0)
SELECT bround(25, -1);
-- 20
SELECT bround(525s, -1);
-- 520 smallint
SELECT bround(525L, -3);
-- 1000 bigint
SELECT bround(25y, -2);
-- 0 tinyint
SELECT bround(2147483647, -1);
-- error ARITHMETIC_OVERFLOW (ANSI on)
-- -2147483646 (ANSI off)
SELECT bround(-128y, -1);
-- error ARITHMETIC_OVERFLOW (ANSI on)
-- 126 (ANSI off)
MathExpressionsSuite asserts bround(2.5D, 0) = 2.0, bround(3.5D, 0) = 4.0, bround(-2.5D, 0) = -2.0, bround(-0.35D, 1) = -0.4, bround(-35, -1) = -40 and bround(45.00BD, -1) = 40 (where round gives 50).
Edge cases to test
- NULL
expr, NULLd(literal), non-foldabled(analysis errorDATATYPE_MISMATCH.NON_FOLDABLE_INPUT). - Ties in both directions and at several scales: 0.5, 1.5, 2.5, -2.5, 0.125 with
d = 2, 25/35/45 withd = -1. - Integer types with negative
d: result stays the same integer type; overflow with ANSI on fails withARITHMETIC_OVERFLOW(SQLSTATE 22003, messageOverflow, configspark.sql.ansi.enabled), with ANSI off it wraps (goldennonansi/math.sql.out:bround(32767s, -1)is -32766,bround(-9223372036854775808L, -1)is 9223372036854775806). Very negativedreturns 0 (bround(25y, -3)is 0). - Integer types with
d >= 0return the input unchanged. - FLOAT / DOUBLE: Spark converts with
BigDecimal.valueOf(double)(the decimal string fromDouble.toString), rounds HALF_EVEN, then converts back. Sobround(2.675D, 2)rounds the decimal 2.675 and gives 2.68, while(x * 100).round_ties_even() / 100gives 2.67 because 2.675 * 100 is 267.49999999999997 in binary. FLOAT is widened to DOUBLE first (bround(3.1415f, 4)is3.1415f). - NaN and +/-Infinity are returned unchanged. -0.0 and negative values that round to zero (
bround(-0.4D, 0)) return0.0, not-0.0, becauseBigDecimalhas no negative zero. - Very large
d(e.g. 400) on DOUBLE leaves the value unchanged; very negativedgives 0.0. - DECIMAL: result precision/scale per the formula above, including the cap at 38.
dlarger than the scale returns the value unchanged with the input scale. On the negative-dpath, a result that needs 39 digits throwsNUMERIC_VALUE_OUT_OF_RANGE.WITHOUT_SUGGESTIONfromDecimal.set(derived from code). - Column
exprwith scalard, and a scalarexpr.
Differences across Spark versions
- 4.0: ANSI on by default, so integer overflow now errors by default (
ARITHMETIC_OVERFLOW); it wraps in 3.x defaults. - 3.4: the decimal positive-scale path used the value's precision in
toPrecision(decimal.precision, s, mode); 3.5+ uses the result type precision. NON_FOLDABLE_INPUTinputNameisscalein 3.x and`scale`in 4.0+.Double.toStringchanged in JDK 19 to always produce the shortest repr; on older JDKs a few doubles have a longer digit string, which can change a HALF_EVEN tie. This applies whenever Spark runs on JDK 17 or older.
Implementation notes
- Spark:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala,BRoundandRoundBase(dataType,nullSafeEval,doGenCode). - DataFusion core has no
bround; itsroundrounds half away from zero and keeps floating-point arithmetic. datafusion-sparkhascrates/spark/src/function/math/round.rs(HALF_UP). Generalise its integer and decimal helpers over the rounding mode and reuse them, but note two known gaps there thatbroundshould not inherit: decimal results keep the input scale instead of Spark's reduced scale (apache/datafusion-spark#37), and floating-point rounding multiplies by10^dinstead of rounding the shortest decimal representation (Rust's{}formatting off64gives the shortest round-trip digits, which can be fed to a decimal rounding routine). Usedatafusion.execution.enable_ansi_modefor the overflow behaviour and raiseARITHMETIC_OVERFLOW.- Tests: the placeholder
crates/sqllogictest/test_files/math/bround.sltexists with commented-out queries; enable and extend it. Document with#[user_doc].
This issue was generated by an LLM (Claude) from the Apache Spark source code and tests. Examples come from Spark's ExpressionDescription examples, test suites and .sql.out golden files, but please verify them against Spark before relying on them.
- 主要语言
- Rust
- 星标
- 7
- 派生
- 15
- 平均合并
- 16 小时 43 分钟
- 30 天内合并 PR
- 26
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
apache/datafusion-spark 的其他 Issue
-
enhancement
难度 2/5 1-3 小时 新手友好度 70/100
apache/datafusion-spark#287 ·
维护者通常 1 天内回复
-
enhancement good first issue
难度 2/5 1-3 小时 新手友好度 80/100
apache/datafusion-spark#266 ·
维护者通常 1 天内回复
-
[Bug] make_dt_interval returns NULL for more than about 1.49 million days, Spark returns the interval可能已有人在做 @Subodh-17 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 78/100
apache/datafusion-spark#109 ·
维护者通常 1 天内回复
-
enhancement
难度 5/5 一周以上 新手友好度 18/100
apache/datafusion-spark#299 ·
维护者通常 1 天内回复
-
enhancement
难度 4/5 3-5 天 新手友好度 35/100
apache/datafusion-spark#298 ·
维护者通常 1 天内回复
查看 apache/datafusion-spark 的全部 Issue
相似的 Issue
-
comp-rbac
难度 2/5 1-3 小时 新手友好度 68/100
ClickHouse/ClickHouse#131875 ·
维护者通常 1 天内回复
-
bug(python): read_transaction raises TypeError on a Rewrite with rewritten indices可能已有人在做 @Borg93 今天认领。 未关闭bug
难度 2/5 1-3 小时 新手友好度 75/100
lance-format/lance#11117 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 70/100
storytold/photocraft#15232 · 1 条评论 ·
维护者通常 1 天内回复
-
forge: fork preflight reads still send `requireCanonical: false`, which Rootstock rejects (-32603)可能已有人在做 @Ynyesto 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 72/100
foundry-rs/foundry#18485 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 70/100
bondybondbond/rushcut#238 · 1 条评论 ·