Implement Spark-compatible `split`
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start by reading the existing string functions under crates/spark/src/function/string/ to see the registration and #[user_doc] pattern, then check whether the Java-regex compatibility helper from the rlike work exists yet — this issue depends on it. Read Spark's StringSplit and UTF8String.split for the leading-empty and limit rules, since Regex::split cannot be used directly. Done means split.slt under crates/sqllogictest/test_files/string/ passes the NULL, limit, empty-regex and column-argument cases listed here.
由索引模型根据 Issue 内容生成。
描述
Part of #174 and apache/datafusion-comet#7300.
What the function does
split(str, regex[, limit]) splits str around matches of the Java regular expression regex and returns an array. limit (default -1) controls how many times the regex is applied: if limit > 0 the array has at most limit elements and the last one holds the rest of the input; if limit <= 0 the regex is applied as many times as possible and trailing empty strings are kept (Spark maps limit = 0 to -1 to avoid Java's trailing-empty removal). Available since 1.5.0.
str and regex are implicitly cast to STRING and limit to INT (limit may be a column). Result type is ARRAY<STRING> with containsNull = false (element type follows str's collation in 4.0+). NULL if any argument is NULL. An empty regex is special-cased in UTF8String.split: it splits into individual characters (code points) without the trailing empty element.
Examples
SELECT split('oneAtwoBthreeC', '[ABC]');
-- ["one","two","three",""]
SELECT split('oneAtwoBthreeC', '[ABC]', -1);
-- ["one","two","three",""]
SELECT split('oneAtwoBthreeC', '[ABC]', 2);
-- ["one","twoBthreeC"]
SELECT split('aa1cc2ee3', '[1-9]+', 2);
-- ["aa","cc2ee3"]
SELECT split('hello', '');
-- ["h","e","l","l","o"]
SELECT split('hello', '', 1);
-- ["hello"]
SELECT split('hello', '', 3);
-- ["h","e","llo"] (4.1+; ["h","e","l"] in 3.4 to 4.0)
SELECT split('', '');
-- [""]
SELECT split('abc', null);
-- NULL
Edge cases to test
- NULL
str,regexorlimit, literal and column: NULL. limitof 0, negative, 1, exactly the number of pieces, and larger.split('aacbbcddc', 'c', 0)is["aa","bb","dd",""](RegexpExpressionsSuite), same as with -1;split('aa2bb3cc4', '[1-9]+', -2)is["aa","bb","cc",""](StringFunctionsSuite).- Empty
regex:split('hello', '', 5)andsplit('hello', '', 100)are["h","e","l","l","o"];split('', '', n)is[""]for everyn. Splitting is per code point (UTF-8 lead byte), so a supplementary character stays whole. - Empty
strwith a non-empty regex:split('', ',')is[""](JavaString.splitreturns the input when nothing matches). - Leading empties follow Java
String.split: a positive-width match at the start produces a leading""(split(',a', ',')is["","a"]), but a zero-width match at the start does not.split('abc', 'x*')is["a","b","c",""]in Spark, while theregexcrate'ssplityields a leading""(["","a","b","c",""]). - Empty matches after a non-empty match are reported by Java but not by the
regexcrate (itstestdata/empty.toml:b|onabcgives 3 matches, Java 4), so splits on patterns that can match empty differ. - Invalid regex:
splitdoes not wrap the error. Spark throws the rawjava.util.regex.PatternSyntaxException(no error condition), unlike the other regex functions which useINVALID_PARAMETER_VALUE.PATTERN. Implementations should still raise an error. - Column
regexand columnlimit(SPARK-47845test inStringFunctionsSuite). spark.sql.parser.escapedStringLiterals(default false) only affects parsing of SQL literals before the function. In.slt, DataFusion keeps backslashes literal, sosplit(s, '\.')splits on a dot.- Java vs Rust divergences to decline or test: single-character literal patterns take Java's fast path but match the same as regex; lookaround / backreferences / atomic / possessive (Java only); ASCII
\d\w\sin Java vs Unicode in Rust (split('a\u3000b', '\\s'), U+3000 IDEOGRAPHIC SPACE, returns a single element in Spark and two in Rust);.excludes\r,\u0085,\u2028,\u2029in Java;$matches before a final line terminator in Java;(?i)ASCII-only in Java; inline flag lettersU/u/d; Java-only\Q..\E(commonly used to split on a literal string),\h,\R,\Z; Rust-only(?P<n>),\<,[[:alpha:]]. UTF8_LCASEcollation (4.0+) prefixes the regex with(?ui).
Differences across Spark versions
- 4.1.0 (SPARK-49968): with an empty regex and
0 < limit < length, the last element now holds the remainder (split('abcd', '', 2)is["a","bcd"]). The old behaviour (["a","b"], dropping the rest) is restored by the internal configspark.sql.legacy.truncateForEmptyRegexSplit(default false). 3.4 to 4.0 always truncate. - 4.0: collation-aware input types; element type follows
str.
Implementation notes
- Spark:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala,StringSplit, which callsUTF8String.split/splitLegacyTruncate(common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java) and thenjava.lang.String.split(regex, limit). - DataFusion core has no regex split.
string_to_array/split_partsplit on a literal delimiter.datafusion-sparkhas neithersplitnor a regex helper today. - Use the shared Java-regex compatibility helper proposed for
rlike(verified subset, decline otherwise, decided at planning time for a literal regex). Implement JavaString.splitsemantics directly (leading empty rule,limithandling, keep trailing empties) instead of usingRegex::split/splitn. A literal regex with no metacharacters can be split as a plain substring. - Belongs in
crates/spark/src/function/string/. Addcrates/sqllogictest/test_files/string/split.sltand document with#[user_doc].
This issue was generated by an LLM (Claude) from the Apache Spark source code and tests. Examples come from Spark's ExpressionDescription examples, test suites and .sql.out golden files, but please verify them against Spark before relying on them.
- 主要语言
- Rust
- 星标
- 7
- 派生
- 15
- 平均合并
- 16 小时 43 分钟
- 30 天内合并 PR
- 26
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
apache/datafusion-spark 的其他 Issue
-
enhancement
难度 2/5 1-3 小时 新手友好度 70/100
apache/datafusion-spark#287 ·
维护者通常 1 天内回复
-
enhancement good first issue
难度 2/5 1-3 小时 新手友好度 80/100
apache/datafusion-spark#266 ·
维护者通常 1 天内回复
-
[Bug] make_dt_interval returns NULL for more than about 1.49 million days, Spark returns the interval可能已有人在做 @Subodh-17 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 78/100
apache/datafusion-spark#109 ·
维护者通常 1 天内回复
-
enhancement
难度 5/5 一周以上 新手友好度 18/100
apache/datafusion-spark#299 ·
维护者通常 1 天内回复
-
enhancement
难度 4/5 3-5 天 新手友好度 35/100
apache/datafusion-spark#298 ·
维护者通常 1 天内回复
查看 apache/datafusion-spark 的全部 Issue
相似的 Issue
-
comp-rbac
难度 2/5 1-3 小时 新手友好度 68/100
ClickHouse/ClickHouse#131875 ·
维护者通常 1 天内回复
-
bug(python): read_transaction raises TypeError on a Rewrite with rewritten indices可能已有人在做 @Borg93 今天认领。 未关闭bug
难度 2/5 1-3 小时 新手友好度 75/100
lance-format/lance#11117 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 70/100
storytold/photocraft#15232 · 1 条评论 ·
维护者通常 1 天内回复
-
forge: fork preflight reads still send `requireCanonical: false`, which Rootstock rejects (-32603)可能已有人在做 @Ynyesto 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 72/100
foundry-rs/foundry#18485 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 70/100
bondybondbond/rushcut#238 · 1 条评论 ·