Implement Spark-compatible `transform_keys` (higher-order map function)
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start by reading datafusion/expr/src/higher_order_function.rs to see how HigherOrderUDFImpl and LambdaArgument are evaluated, then inspect crates/spark/src/function/map/utils.rs for the existing dedup and NULL_MAP_KEY handling. Registration runs through crates/spark/src/function/lambda/mod.rs, currently an empty placeholder, so add the HigherOrderUDF list and register_higher_order_function wiring. Done when crates/sqllogictest/test_files/lambda/transform_keys.slt covers the examples and edge cases and the function has #[user_doc].
由索引模型根据 Issue 内容生成。
描述
Part of #176 and apache/datafusion-comet#7300.
What the function does
transform_keys(expr, func) returns a map whose keys are func(k, v) for each entry of the map expr. The values
are unchanged. The result type is MAP<func.dataType, valueType> with the input's valueContainsNull. A NULL map
gives NULL, and the result is nullable if the input is. The lambda takes exactly 2 parameters: k (non-null) and
v (nullable when valueContainsNull is true).
The new key type must be a valid map key, so checkInputDataTypes uses TypeUtils.checkForMapKeyType. A key type
that is or contains a MAP fails with DATATYPE_MISMATCH.INVALID_MAP_KEY_TYPE. expr must be a MAP. A
non-lambda func is wrapped in a hidden lambda. Available since Spark 3.0.0. No aliases.
The result is built with ArrayBasedMapBuilder, which means:
- a NULL produced key fails with
NULL_MAP_KEY; - duplicate produced keys follow
spark.sql.mapKeyDedupPolicy. The defaultEXCEPTIONfails with
DUPLICATED_MAP_KEY(key,mapKeyDedupPolicyparameters). UnderLAST_WINthe key keeps the position of its
first occurrence and takes the value of its last occurrence; - from 4.0, float and double keys are normalized (
-0.0becomes0.0, and NaN values are unified) unless
spark.sql.legacy.disableMapKeyNormalization=true.
Examples
SELECT transform_keys(map_from_arrays(array(1, 2, 3), array(1, 2, 3)), (k, v) -> k + 1);
-- {2:1,3:2,4:3}
SELECT transform_keys(map_from_arrays(array(1, 2, 3), array(1, 2, 3)), (k, v) -> k + v);
-- {2:1,4:2,6:3}
SELECT transform_keys(map('a', 1, 'b', 2), 42);
-- error DUPLICATED_MAP_KEY
SELECT transform_keys(map('a', 1, 'b', 2), map('new', 'key'));
-- error DATATYPE_MISMATCH.INVALID_MAP_KEY_TYPE
SELECT transform_keys(map('a', null), (k, v) -> v);
-- error NULL_MAP_KEY
These come from the ExpressionDescription, higher-order-functions.sql.out and DataFrameFunctionsSuite.
HigherOrderFunctionsSuite adds:
| map | lambda | result |
|---|---|---|
{1:1, 2:2, 3:3, 4:4} |
k % 3 |
DUPLICATED_MAP_KEY (key 1) |
{1:1, 2:2, 3:3, 4:4} |
k % 3, LAST_WIN |
{1:4, 2:2, 0:3} |
{1:1, 2:null, 3:3} |
k + 1 |
{2:1, 3:null, 4:3} |
{"a":"xy", "bb":"yz", "ccc":null} |
length(k) + 1 |
{2:"xy", 3:"yz", 4:null} |
{} |
any | {} |
| NULL | any | NULL |
Edge cases to test
- A NULL map gives NULL. An empty map gives
{}, and no error is possible. - A lambda that returns NULL for any entry gives
NULL_MAP_KEY, even underLAST_WIN. - Duplicate produced keys under both
spark.sql.mapKeyDedupPolicyvalues. Check the error parameters
("key" -> "1","mapKeyDedupPolicy" -> "\"spark.sql.mapKeyDedupPolicy\""). UnderLAST_WIN, check both the
position and the value:{1:4, 2:2, 0:3}above. The datafusion-spark config is
datafusion.spark.map_key_dedup_policy. - Float and double produced keys, for example
(k, v) -> if(k = 1, 0.0D, -0.0D)on a two-entry map. By code
reading, 4.0+ normalization makes0.0and-0.0collide, so the dedup policy applies (DUPLICATED_MAP_KEYby
default). In 3.4 and 3.5 they are distinct keys. Also testNaN. - Chained calls:
transform_keys(transform_keys(m, (k, v) -> k + 1), (k, v) -> k + v)gives{3:1, 5:2, 7:3, 9:4}
for{1:1, 2:2, 3:3, 4:4}. - Key-type change (string to int, as in the table above). Struct and array keys are allowed. Map keys are rejected
at analysis time. - Lambda arity:
k -> kfails withINVALID_LAMBDA_FUNCTION_CALL.NUM_ARGS_MISMATCH(expected 1, actual 2), and so
does(k, v, x) -> .... DataFusion's planner allows a lambda to declare fewer parameters than offered, so this check
has to be explicit. - Captured outer columns, nondeterministic key expressions, and ANSI errors inside the lambda. With ANSI on,
k + 1can overflow and raiseARITHMETIC_OVERFLOW. - A non-map argument (
transform_keys(array(...), ...)) fails withDATATYPE_MISMATCH.UNEXPECTED_INPUT_TYPE.
Differences across Spark versions
- 4.0 adds float and double key normalization to
ArrayBasedMapBuilder(spark.sql.legacy.disableMapKeyNormalization,
default false). - 3.5 marks
TransformKeysasstateful, because the map builder is reused. This is internal only. - ANSI mode is on by default from 4.0.
Implementation notes
- Spark:
TransformKeysinsql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala.
The builder issql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayBasedMapBuilder.scala. - Infrastructure. DataFusion's higher-order function framework (
HigherOrderUDFImplin
datafusion/expr/src/higher_order_function.rs, andLambdaArgument::evaluatewithspread_capturesfor captured
columns, withconfig_optionsavailable inHigherOrderFunctionArgs) is onbranch-56, which this crate uses. - DataFusion core has no higher-order map functions. Evaluate the lambda once over the flattened keys and values of
theMapArrayentries, then rebuild the map with deduplication. - In this crate,
crates/spark/src/function/map/utils.rsalready implements Spark's dedup policy
(map_from_keys_values_offsets_nulls/map_deduplicate_keys, which raise[DUPLICATED_MAP_KEY]or keep the last
value). It is wired todatafusion.spark.map_key_dedup_policyand used bymap_from_arrays,
map_from_entriesandstr_to_map. Reuse it, and check that it also enforcesNULL_MAP_KEYand the 4.0+ float
normalization. crates/spark/src/function/lambda/mod.rsis an emptyScalarUDFplaceholder. It needs aHigherOrderUDFlist and
registration throughregister_higher_order_function/SessionStateBuilder::higher_order_functions.- Add
crates/sqllogictest/test_files/lambda/transform_keys.sltand document the function with#[user_doc].
This issue was generated by an LLM (Claude) from the Apache Spark source code and tests. Examples come from Spark's ExpressionDescription examples, test suites and .sql.out golden files, but please verify them against Spark before relying on them.
- 主要语言
- Rust
- 星标
- 7
- 派生
- 15
- 平均合并
- 16 小时 43 分钟
- 30 天内合并 PR
- 26
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
apache/datafusion-spark 的其他 Issue
-
enhancement
难度 2/5 1-3 小时 新手友好度 70/100
apache/datafusion-spark#287 ·
维护者通常 1 天内回复
-
enhancement good first issue
难度 2/5 1-3 小时 新手友好度 80/100
apache/datafusion-spark#266 ·
维护者通常 1 天内回复
-
[Bug] make_dt_interval returns NULL for more than about 1.49 million days, Spark returns the interval可能已有人在做 @Subodh-17 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 78/100
apache/datafusion-spark#109 ·
维护者通常 1 天内回复
-
enhancement
难度 5/5 一周以上 新手友好度 18/100
apache/datafusion-spark#299 ·
维护者通常 1 天内回复
-
enhancement
难度 4/5 3-5 天 新手友好度 35/100
apache/datafusion-spark#298 ·
维护者通常 1 天内回复
查看 apache/datafusion-spark 的全部 Issue
相似的 Issue
-
comp-rbac
难度 2/5 1-3 小时 新手友好度 68/100
ClickHouse/ClickHouse#131875 ·
维护者通常 1 天内回复
-
bug(python): read_transaction raises TypeError on a Rewrite with rewritten indices可能已有人在做 @Borg93 今天认领。 未关闭bug
难度 2/5 1-3 小时 新手友好度 75/100
lance-format/lance#11117 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 70/100
storytold/photocraft#15232 · 1 条评论 ·
维护者通常 1 天内回复
-
forge: fork preflight reads still send `requireCanonical: false`, which Rootstock rejects (-32603)可能已有人在做 @Ynyesto 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 72/100
foundry-rs/foundry#18485 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 70/100
bondybondbond/rushcut#238 · 1 条评论 ·