Support the proposed DictionaryEncoding.custom_metadata (format 1.6) for dictionaries of extension types in IPC
维护者通常 1 天内回复
评估
调研方向
Start by reading ArrowStreamWriter.GetFieldMetadataOffset and MessageSerializer.FieldFromFlatbuffer, then inspect the generated FlatBuffers types and the existing IPC tests. Implement the format 1.6 dictionary value metadata handling in the writer and reader, preserving field metadata for the whole dictionary type. Add the .NET archery dictionary_extension integration case and verify the new behavior against the proposed semantics; the issue notes this work depends on the format vote passing.
由索引模型根据 Issue 内容生成。
描述
Describe the enhancement requested
In IPC, a dictionary-encoded field has no separate schema node for its value type, so dictionary<values=extension<X>> and extension<X, storage=dictionary<...>> serialize identically, with ARROW:extension:name in Field.custom_metadata. This is tracked upstream as apache/arrow#49704. A format change proposed in apache/arrow#53994 (format version 1.6) adds an optional DictionaryEncoding.custom_metadata that holds the dictionary value type's metadata. That's the IPC counterpart of ArrowSchema.dictionary->metadata in the C Data Interface. Field.custom_metadata keeps describing the whole dictionary type.
The format change is a draft pending a [VOTE] on dev@. Companion PRs: apache/arrow-go#1381, apache/arrow-rs#11622, apache/arrow-nanoarrow#972. This issue is to implement it in Apache.Arrow once the vote passes.
Current Apache.Arrow behavior
- Writer:
ArrowStreamWriter.GetFieldMetadataOffsetputs a dictionary value type's extension keys inField.custom_metadata, which is the same encoding as an extension over a dictionary. - Reader:
MessageSerializer.FieldFromFlatbufferresolvesField.custom_metadataagainst the value type before wrapping it in aDictionaryType, so it reads field-level keys as describing the values. That's the opposite of Arrow C++ and of the proposed spec. As a result:- an extension over a dictionary written by Arrow C++ doesn't resolve;
- Arrow C++ can't read a
dictionary<int32, arrow.uuid>written by Apache.Arrow (Invalid storage type for UuidType: dictionary<...>); it can't read the one it writes itself today either.
Proposed work (after the vote)
- Regenerate the flatbuffers code for the new
DictionaryEncoding.custom_metadatamember. - Writer: put a value extension type's
ARROW:extension:*keys inDictionaryEncoding.custom_metadatainstead ofField.custom_metadata. An extension over a dictionary keeps its keys on the field. - Reader: apply
DictionaryEncoding.custom_metadatato the value type before wrapping it in the dictionary type, then applyField.custom_metadatato the whole dictionary type. - Add the archery
dictionary_extensionintegration case for .NET.
Decision: field-level keys on a dictionary follow the spec, with no fallback
Field.custom_metadata on a dictionary-encoded field describes only the whole dictionary type, as in Arrow C++ and arrow-go, and the reader won't retry it against the value type. Breaking change: dictionary<extension> files written by earlier Apache.Arrow versions (and by every writer before 1.6) will read as a plain dictionary of the storage type, so this needs a release note. #474 makes the same choice for C Data import.
The C Data side is aligned with these semantics in #474.
Component(s)
C#
- 主要语言
- C#
- 星标
- 42
- 派生
- 32
- 平均合并
- 1 天 3 小时
- 30 天内合并 PR
- 25
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
apache/arrow-dotnet 的其他 Issue
-
难度 1/5 1-3 小时 新手友好度 88/100
apache/arrow-dotnet#410 · 4 条评论 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 38/100
apache/arrow-dotnet#409 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 5/5 一周以上 新手友好度 35/100
apache/arrow-dotnet#397 · 2 条评论 ·
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 55/100
apache/arrow-dotnet#378 ·
维护者通常 1 天内回复
-
Add compute kernels (Sum/Min/Max/Mean) using System.Numerics.Tensors (TensorPrimitives) and Tensor<T> support可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭
难度 5/5 一周以上 新手友好度 32/100
apache/arrow-dotnet#375 · 1 条评论 ·
维护者通常 1 天内回复
查看 apache/arrow-dotnet 的全部 Issue
相似的 Issue
-
dev/release: verify-release-candidate.sh runs 0 Java tests with Debian's Maven可能已有人在做 @kou 今天认领。 未关闭Type: bug
难度 2/5 1-3 小时 新手友好度 72/100
apache/arrow-adbc#4947 ·
维护者通常 1 天内回复
-
:watch: Not Triaged CAC
难度 2/5 1-3 小时 新手友好度 78/100
dotnet/AspNetCore.Docs#38001 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
Nimblesite/SharpLsp#468 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 88/100
elastic/ecs-dotnet#575 ·
-
alerts bug effort:S P2
难度 2/5 1-3 小时 新手友好度 76/100
nightscout/nocturne#2511 ·
维护者通常 1 天内回复