Vite migration (3/3): check-ui guards and small follow-ups
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 55/100
- Issue 类型
- 功能
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- css, javascript, vite
- 领域
- build-system, frontend, testing
调研方向
从 make check-ui 开始,并检查 script/check-built-assets.sh、ui/scripts/check-locale-resolution.js、ui/scripts/check-plugin-i18n-order.js 和 ui/scripts/locale-probe.js。检查 Comment/index.scss 的声明顺序和 pages/403 路由,然后在 dev 上运行三个检查以及步骤 1 和 2。完成标准是 make check-ui 通过,并且 ./script/check-built-assets.sh --self-check 报告每个 fixture 都按预期失败。
由索引模型根据 Issue 内容生成。
描述
Part of #1578. Depends on #1580. Not required to boot.
Change. Three guard checks for behaviour a successful build does not demonstrate, wired as make check-ui: script/check-built-assets.sh builds the frontend, runs TestGetStyleResolvesBuiltAssets, and under --self-check rewrites the built index.html into shapes the server cannot use and asserts the check fails on each; ui/scripts/check-locale-resolution.js starts the real dev server and requires a non-default language to resolve through the module graph and to be fetchable over HTTP; ui/scripts/check-plugin-i18n-order.js registers a plugin translation bundle before and after i18next initialises and asserts the translations land. All three fail closed: preset failure, bounded server create, listen and close, a whole-run watchdog. Plus ui/scripts/locale-probe.js, the small CSS fix (Comment/index.scss declaration order) and the pages/403 route repoint. The one-line Editor/index.scss custom-property fix that #1567 also carried is not here: the new CSS minifier rejects the invalid declaration outright and fails the build, so it had to ride in step 2.
Done when. make check-ui is green on all three targets on dev plus steps 1 and 2 plus this change, and ./script/check-built-assets.sh --self-check reports every fixture failing as intended.
- 主要语言
- Go
- 星标
- 15.7k
- 派生
- 1.4k
- 平均合并
- 1 天 20 小时
- 30 天内合并 PR
- 6
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
apache/answer 的其他 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 65/100
-
Hardening: cap the invite_user list size in UpdateQuestionInviteUser to bound notification fan-out 未关闭
难度 2/5 1-3 小时 新手友好度 72/100
-
难度 2/5 1-3 小时 新手友好度 84/100
-
难度 2/5 1-3 小时 新手友好度 88/100
-
Gravatar hash is computed from the un-lowercased email, so mixed-case accounts render an identicon 未关闭
难度 2/5 1-3 小时 新手友好度 85/100
相似的 Issue
-
bug github_actions
难度 2/5 1-3 小时 新手友好度 75/100
registrystack/registry-stack#1393 ·
-
难度 2/5 1-3 小时 新手友好度 75/100
JakeChampion/lang#10213 ·
-
难度 2/5 1-3 小时 新手友好度 70/100
oasisprotocol/oasis-sdk#2523 ·
-
难度 2/5 1-3 小时 新手友好度 75/100
-
难度 2/5 1-3 小时 新手友好度 70/100