[Bug]: Bitnami Helm chart helpers bundled in charts/ are not attributed in LICENSE

未关闭 适合新手
#4,476 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 2 天内回复

还没有人认领这个 Issue。

评估

难度
1/5
预计耗时
1 小时以内
新手友好度
82/100
Issue 类型
文档
描述清晰度
描述清楚
活跃度
活跃
技术栈
helm
领域
documentation

调研方向

阅读根目录 LICENSE 中标题为“This product bundles various third-party components also under the Apache Software License 2.0”的部分,并检查 charts/amoro/templates/common/ 下受影响的五个文件。在其中添加 Bitnami charts common 2.11.1 的归属信息,包括 VMware 版权声明和 Apache License 2.0。根目录 LICENSE 列出全部五个捆绑的 helper 及其来源后,即为完成。

由索引模型根据 Issue 内容生成。

描述

What happened?

The source release bundles five Helm template helpers copied from the Bitnami charts common library chart (Copyright VMware, Inc., Apache-2.0, not an ASF project), but the root LICENSE does not mention them.

Found while reviewing apache-amoro-0.9.0-incubating-src.tar.gz (RC14, tag v0.9.0-rc14, commit 18d12b99d5297dbd0bb4eb72517c4855d75210f6). The same files were also present, unattributed, in 0.8.1-incubating.

Affected files:

  • charts/amoro/templates/common/_capabilities.tpl
  • charts/amoro/templates/common/_ingress.tpl
  • charts/amoro/templates/common/_labels.tpl
  • charts/amoro/templates/common/_names.tpl
  • charts/amoro/templates/common/_tplvalues.tpl

Each file correctly keeps its upstream header:

Copyright VMware, Inc.
SPDX-License-Identifier: APACHE-2.0

// This file under the http://www.apache.org/licenses/LICENSE-2.0, copied from
// https://github.com/bitnami/charts/blob/common/2.11.1/bitnami/common/templates/<file>.tpl

However, grep -n -i 'bitnami\|vmware\|charts/' LICENSE returns nothing. Per the ASF third-party licensing guidance, bundled third-party code should be listed in LICENSE.

Suggested fix

Add an entry to the root LICENSE, in the existing "This product bundles various third-party components also under the Apache Software License 2.0" section, listing the five files above as from Bitnami charts common 2.11.1 (https://github.com/bitnami/charts), Copyright VMware, Inc., Apache License 2.0.

If the Helm chart is ever packaged and distributed on its own, it should also carry this attribution.

Affects Versions

0.9.0-incubating (RC14), 0.8.1-incubating

How to reproduce
tar xzf apache-amoro-0.9.0-incubating-src.tar.gz && cd amoro-0.9.0-incubating
head -7 charts/amoro/templates/common/_names.tpl
grep -n -i 'bitnami\|vmware' LICENSE   # no output
主要语言
Java
星标
1.2k
派生
398
平均合并
3 天 13 小时
30 天内合并 PR
14

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

apache/amoro 的其他 Issue

查看 apache/amoro 的全部 Issue

相似的 Issue

更多 Java Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。