Eleven wrapped callbacks and remote-config `isSupported` hold the app unstable until something that may never happen
维护者通常 3 天内回复
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 48/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- angular, firebase, typescript
调研方向
Start with the ɵzoneWrap configuration and the generation rules in tools/build.ts, then compare the wrapped callbacks and remote-config isSupported with the existing onMessage and analytics or messaging entries. Check generated exports and tests for callback task handling and isSupported; done means the listed callbacks no longer block stability when their first event is not guaranteed, while callbacks still run in Angular context, and remote-config isSupported is generated with blockUntilFirst: false.
由索引模型根据 Issue 内容生成。
描述
Version info
Angular: 22.2
Firebase: 12.19.0
AngularFire: 22.0.0-rc.0, and main
Description
ɵzoneWrap registers an Angular pending task as soon as a wrapped function is passed a callback, and releases it only when that callback first runs or the returned unsubscribe is called.
That is right for onValue, onSnapshotsInSync and onAuthStateChanged, which deliver a first value on attach. Eleven wrapped calls take a callback that a normal page load may never run, in which case ApplicationRef.isStable would stay false for good:
onLogfrom@angular/fire/app: never stable until some Firebase SDK logs, which a quiet app never does. It returnsvoid, so no unsubscribe can release the task either.onTokenChangedfrom@angular/fire/app-check: never stable until a token is obtained. With the setupdocs/app-check.mdshows (noisTokenAutoRefreshEnabled), a first visit that makes no protected request never obtains one.onChildAddedfrom@angular/fire/database: never stable on an empty node. A new listener's initial events are onlychild_added, one per existing child, andvalue.onChildChanged,onChildMoved,onChildRemovedfrom@angular/fire/database: never stable until someone changes, moves or removes a child. None of them fires on attach.off(query, eventType, callback)from@angular/fire/database: never stable. It never calls the callback it is given and returnsvoid.enableLogging(fn)from@angular/fire/database: never stable until the database SDK logs something.fromRefon a child event, andstateChangesandauditTrailwith their default events, from@angular/fire/database: never stable on an empty node. They emit only on child events, so the taskpendingUntilEventregistered is never released.
isSupported from @angular/fire/remote-config is a twelfth case with a different cause:
- Its promise settles when an IndexedDB check answers, so a browser that never answers holds the app for good.
- #3613 added
isSupported: { blockUntilFirst: false }for it, matching the analytics and messaging copies, but in therxfire/remote-configblock oftools/build.ts, which exports noisSupported. The generator ignored the entry and remote-config shippedtrue. - #3759 deleted the dead entry and left the move for a follow-up.
How to reproduce these conditions
On a fresh Angular 22 app with @angular/fire@next, wrap each real function with ɵzoneWrap at true (the generated line), call it the way a constructor does, inside the Angular zone and an injection context, against the Database and Firestore emulators, and record every ApplicationRef.isStable emission:
onLog,onTokenChanged(provider with no token, no auto refresh),onChildAddedon an empty node,onChildChanged,onChildMovedandonChildRemovedon a node with three children: unstable from 0 ms, still unstable at 3 seconds, callback never ran. Same in a zone.js app and a zoneless one.onChildAddedon a node with three children,onValue,onSnapshotsInSync,onTokenChangedwith auto refresh on: unstable from 0 ms, stable again within 2 to 23 ms when the callback ran.- With
false: no task registered, and inside the callbackinject()still works and, under zone.js,NgZone.isInAngularZone()is still true.
A fresh Angular 22 SSR app that registers an onLog handler inside provideAppInitializer: with onLog imported from @angular/fire/app, ng build fails after about 30 seconds, the route extractor's timeout, with Routes extraction was aborted. TimeoutError: The operation was aborted due to timeout. With the identical file importing from firebase/app, it builds in about 2 seconds. That is the failure #3748 reported for beforeAuthStateChanged.
For isSupported: true holds the app unstable until the IndexedDB check answers, and for the whole window when indexedDB.open is stubbed to never fire. false registers no task. Inside the caller's .then, inject() throws and the zone is the one that attached the .then, at both values.
Expected behavior
A wrapped call whose first callback is not guaranteed by subscribing does not hold the application unstable, as onMessage, onRegistered, onUnregistered and beforeAuthStateChanged already do not. isSupported from @angular/fire/remote-config is wrapped like the analytics and messaging copies.
Actual behavior
All twelve are wrapped with blockUntilFirst true.
- 主要语言
- TypeScript
- 星标
- 7.8k
- 派生
- 2.2k
- 平均合并
- 2 天 12 小时
- 30 天内合并 PR
- 24
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
angular/angularfire 的其他 Issue
-
Document the 22.0.0-rc.1 changes可能已有人在做 @armando-navarro 于 2 天前认领。 未关闭comp: docs type: chore
难度 3/5 半天 新手友好度 18/100
angular/angularfire#3834 ·
维护者通常 3 天内回复
-
comp: compat comp: ssr comp: zones type: feature version: current (v17+)
难度 3/5 1-2 天 新手友好度 74/100
angular/angularfire#3832 ·
维护者通常 3 天内回复
-
Accept firebase 13 in @angular/fire 22可能已有人在做 @armando-navarro 于 3 天前认领。 未关闭comp: core comp: schematics type: feature
难度 4/5 3-5 天 新手友好度 25/100
angular/angularfire#3830 ·
维护者通常 3 天内回复
-
`ɵzoneWrap` ignores a handler passed as an observer object, and holds a wrapped promise forever once its injector is destroyed可能已有人在做 @armando-navarro 于 3 天前认领。 未关闭comp: app-check comp: core comp: firestore comp: remote-config comp: zones type: bug version: current (v17+)
难度 4/5 3-5 天 新手友好度 25/100
angular/angularfire#3828 ·
维护者通常 3 天内回复
-
comp: compat comp: firestore comp: storage type: chore
难度 4/5 3-5 天 新手友好度 48/100
angular/angularfire#3822 ·
维护者通常 3 天内回复
查看 angular/angularfire 的全部 Issue
相似的 Issue
-
🐛 bug
难度 2/5 1-3 小时 新手友好度 68/100
LibreChat-AI/LibreChat#17733 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 70/100
TypeStrong/typedoc#3150 ·
-
accessibility bug good first issue
难度 2/5 1-3 小时 新手友好度 85/100
维护者通常 1 天内回复
-
Normalize image-source MIME types before SVG dispatch可能已有人在做 @HarsH-1877 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 75/100
tscircuit/image-utils#58 · 1 条评论 ·
-
难度 1/5 1 小时以内 新手友好度 74/100
维护者通常 2 天内回复