Enrich prod-errors in Signals with specific problem

未关闭
#71,390 0 条评论 3 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
45/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
领域
backend

调研方向

The report points to packages/core/primitives/signals/src/computed.ts and the computed/linkedSignal error paths; read the cited code and the existing RuntimeError implementation first. Check how production error codes are assigned and surfaced, then define completion as distinguishing these signal errors with useful codes in production while preserving the intended development behavior.

由索引模型根据 Issue 内容生成。

描述

area: core
Which @angular/* package(s) are relevant/related to the feature request?

core

Description

Hey team. Currently, errors occurring within computed/linkedSignal lack any information about the nature of the error itself in the prod: https://github.com/angular/angular/blob/92e5aa8f154096a756757d0e295cde4299788650/packages/core/primitives/signals/src/computed.ts#L136
As a result, the error signature in Sentry is uninformative, making it impossible to determine where an error originated without examining the stack traces:

Image

Furthermore, when errors arise from different locations (for instance, from computed and linkedSignal) it becomes difficult to distinguish between them in Sentry’s error lists (though Sentry’s built-in grouping mechanism does at least separate them), which complicates the process of locating and debugging errors.

Proposed solution

For each error, add a code instead of a message, as has already been done for RuntimeError

Alternatives considered

I know why it has been done, but maybe it is possible to simplify (shorten) error messages in all modes and remove the ngDevMode at all.

主要语言
TypeScript
星标
101k
派生
28.2k
平均合并
2 天 45 分钟
30 天内合并 PR
373

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

angular/angular 的其他 Issue

查看 angular/angular 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。