Internal headers (`crypto`, `internal` and `prov`) in `zig-out/include`

未关闭 适合新手
#7 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
64/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
冷清
技术栈
zig
领域
build-system

调研方向

从 build.zig 大约第 1255 行开始,这里 issue 指出了 OpenSSL 头文件的安装位置。将软件包已安装的 include 树与上游 OpenSSL include 树进行比较,并检查 consumer 是否需要 crypto、internal 或 prov。完成的标准是确认预期导出的头文件,并验证最终的 zig-out/include 布局。

由索引模型根据 Issue 内容生成。

描述

Hi,
I'm new to Zig (2 days now) and I'm working on making https://github.com/kubernetes-client/c/ working with Zig as I'd like to rewrite some of my scripts into Zig as learning projects.

But the library depends on OpenSSL and it imports it in its public header files so when not using system's OpenSSL I do

b.installArtifact(openssl_lib);

so that the library is distributed in a working state when using vendored OpenSSL.

However the OpenSSL library installs some internal include directories, as far as I understand, which I don't think should be installed.

zig-out/include/
├── crypto
├── curl
├── internal
├── kubernetes
├── openssl
└── prov

7 directories, 0 files

The directories have some generic names and as far as my research goes these headers are internal and upstream only exports the openssl directory

/nix/store/dy64cxaygvmjfznysgxk501yds8jij6s-openssl-3.6.1-dev/include
└── openssl

2 directories

So is there a reason why

https://github.com/allyourcodebase/openssl/blob/6b318b447c8ff7529e3a2337a1df2a9b4816fee2/build.zig#L1255

isn't

lib.installHeadersDirectory(b.path("include/openssl"), "openssl", .{});

I'm opening an issue and not a PR as I'm not sure whether I'm missing something. If there are no requirements for those extra directories to be installed I'll gladly open a PR to make that change.

主要语言
Assembly
星标
28
派生
18
PR 合并指标
30 天内没有已合并 PR

贡献指南

这个仓库没有索引到贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

allyourcodebase/openssl 的其他 Issue

查看 allyourcodebase/openssl 的全部 Issue

相似的 Issue

更多 Build System Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。