fix(cli): plugin update skips Cursor silently and leaves renamed hook scripts behind

未关闭
#1,180 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
53/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
typescript
领域
cli, tooling

调研方向

Start with plugin-update-use-case.ts, plugin-add-use-case.ts, and install-ai-tool-use-case.ts; trace how updates select installed tools and how replace handles previously tracked files. Add tests for a renamed hook through plugin update, replacement, and Cursor setup, checking that edited files are preserved. Done means updates report or reach Cursor, obsolete unchanged files are removed on replacement, and the tests pass.

由索引模型根据 Issue 内容生成。

描述

Description

After the plugin renames a hook script (here hooks/aidd-context/update_memory.js → memory.cjs), updating does not reach every installed tool, and nothing says so.

  1. Cursor is skipped by aidd plugin update. Cursor plugins are recorded with scope user; PluginUpdateUseCase.updatePluginsForTool filters them out when no plugin name is given. The command prints "Updated" for the other tools only. The project's .cursor/hooks.json keeps calling the old script until aidd setup runs again. Naming the plugin fails: Tool 'cursor' does not support scope 'project'.
  2. opencode and Kilo keep orphan files on a reinstall. aidd setup / a reinstall goes through replace: true (install-ai-tool-use-case.ts:128); dropExistingPlugin (plugin-add-use-case.ts) drops the manifest record but never deletes the previously tracked files the new version no longer ships. They are inert (the bridge spawns only current hooks) but stay on disk, untracked, so clean misses them. plugin update itself removes them through deleteOldFiles.
  3. No test covers a renamed hook script through plugin update, through replace, or through Cursor setup again.
Affected file(s)

cli/src/contexts/framework/application/plugin/plugin-update-use-case.ts, cli/src/contexts/framework/application/plugin/plugin-add-use-case.ts, cli/src/contexts/framework/application/install/install-ai-tool-use-case.ts

Expected behaviour
  • An update reaches every installed tool, or names the tool it skipped and the command that updates it.
  • A replaced install removes the files the new version no longer ships, hash-checked like removeObsoleteScripts, so a user-edited file is kept.
Observed behaviour

Measured with the CLI built from a scratch copy: install from origin/next, bump aidd-context, marketplace refresh then plugin update, and separately setup again.

  • Cursor: stays on the old version; .cursor/hooks.json still runs update_memory.js on every sessionStart.
  • opencode / Kilo after setup again: .opencode/hooks/aidd-context/update_memory.js and the .kilo copy remain beside memory.cjs.
  • No case of two memory writers running at once was found.
AI tool

Cursor, OpenCode, Kilo

Additional context

Smallest fixes:

  • Cursor: warn after plugin update that Cursor needs plugin update --scope user then aidd setup, or drive that sequence from the default update.
  • opencode / Kilo: capture the previous record's plugin.files in prepareForInstall (next to prevHooksMap) and delete those absent from the new set on replace, with the same hash check as removeObsoleteScripts.
  • Tests: a rename (update_memory.js → memory.cjs) through plugin update, through replace, and through Cursor setup again.

Unverified: Codex and Copilot host loading (host registration failed in the sandbox); Cursor projects installed before hook provenance records.

主要语言
TypeScript
星标
481
派生
45
平均合并
1 天 13 小时
30 天内合并 PR
91

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

ai-driven-dev/framework 的其他 Issue

查看 ai-driven-dev/framework 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。