Requesting team as reviewer doesn't respect auto assignment upon PR creation
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 38/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 停滞
- 技术栈
- github, github-actions, javascript
调研方向
Start with the workflow's github.rest.pulls.requestReviewers entry point and reproduce the behavior for pull_request opened and reopened events using the documented team auto-assignment setup. Compare the resulting reviewers and determine whether the GitHub API or event timing causes the difference; the issue is done when an opened PR assigns the configured team members rather than leaving the team as reviewer.
由索引模型根据 Issue 内容生成。
描述
Describe the bug
My team has auto-assignment enabled. However, when requesting team as reviewer in a workflow step, it doesn't behave as documented.
When you enable auto assignment, any time your team has been requested to review a pull request, the team is removed as a reviewer and a specified subset of team members are assigned in the team's place.
github.rest.pulls.requestReviewers({
owner: context.repo.owner,
repo: context.repo.repo,
pull_number: context.payload.pull_request.number,
team_reviewers: ["awesomeTeamSlug"]
});
To Reproduce
Steps to reproduce the behavior:
- Enable auto-assignment with Round Robin strategy for your team on Github
- Create a workflow file that requests your team as reviewer when a PR is created in a repo
name: Sample workflow
on:
pull_request:
types:
- opened
- reopened
permissions:
pull-requests: write
jobs:
assign:
runs-on: ubuntu-latest
steps:
- name: Set team as reviewer
uses: actions/github-script@v6
with:
github-token: ${{inputs.custom-github-token}} # need a PAT to add team as reviewer
script: |
github.rest.pulls.requestReviewers({
owner: context.repo.owner,
repo: context.repo.repo,
pull_number: context.payload.pull_request.number,
team_reviewers: ["awesomeTeamSlug"]
});
- Make any change and open a PR
- Observe that the team as an entity is assigned to the PR instead of a specified subset of team member.
Expected behavior
- "the team is removed as a reviewer and a specified subset of team members are assigned in the team's place"
Additional context
This bug/odd behavior seems to only occur when PR is initially created. If I configure the workflow to run upon PR reopened, it works as expected.
- 主要语言
- TypeScript
- 星标
- 5k
- 派生
- 586
- PR 合并指标
- 30 天内没有已合并 PR
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
actions/github-script 的其他 Issue
-
难度 3/5 1-2 天 新手友好度 48/100
actions/github-script#728 ·
-
难度 3/5 1-2 天 新手友好度 52/100
actions/github-script#727 · 1 个 reaction ·
-
{ 未关闭
难度 5/5 一周以上 新手友好度 10/100
actions/github-script#724 ·
-
难度 3/5 1-2 天 新手友好度 55/100
actions/github-script#723 · 1 条评论 ·
-
难度 3/5 1-2 天 新手友好度 55/100
actions/github-script#714 · 1 条评论 · 4 个 reaction ·
查看 actions/github-script 的全部 Issue
相似的 Issue
-
blocklist removal
难度 2/5 1-3 小时 新手友好度 65/100
MetaMask/eth-phishing-detect#296544 ·
-
难度 2/5 1-3 小时 新手友好度 70/100
pastelsky/bundlephobia#1122 ·
-
难度 2/5 1-3 小时 新手友好度 70/100
-
category/development priority/P2 scope/file-operations scope/testing type/enhancement
难度 2/5 1-3 小时 新手友好度 75/100
-
难度 2/5 1-3 小时 新手友好度 75/100