S benchmark doing 2x work
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 35/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 停滞
- 技术栈
- javascript
- 领域
- performance, testing
调研方向
Locate the benchmark source referenced in the issue and compare the S implementation with the other signal implementations. Check the node creation and batching setup, then update the benchmark results after correcting those differences; the issue does not name a specific file or test command.
由索引模型根据 Issue 内容生成。
描述
Hi Andrea --
I've seen this benchmark used in a couple other signal implementations but haven't traced down the source. Do you know where it comes from? It has some weird pieces in the S implementation. For instance, this line ...
S(props.a), S(props.b), S(props.c), S(props.d);
... means that S is actually creating 2 nodes in every place where the other libraries are creating only 1. So S is doing twice the work of the others.
It also disables batching for S but no other library, which seems weird. S should have:
const run = BATCHED ? S.freeze : (fn) => fn();
Would you mind fixing those in your copy and updating the results?
Other than those issues specific to S, this is almost the worst possible benchmark if you're trying to improve actual application performance. All it tests is update speed of deep intermediate nodes, which happens rarely to never. It doesn't test creation time or memory usage at all, even though those are the biggest factors in app performance.
Overall, though, it's cool to see other fast signals implementations come out. I'm reading through usignal, neat stuff!
-- Adam
- 主要语言
- JavaScript
- 星标
- 268
- 派生
- 15
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 68/100
NCAR/music-box-interactive#628 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 68/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 65/100
remotion-dev/remotion#11847 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 86/100
phoenixframework/phoenix_live_view#4456 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 88/100
AllTheMods/ATM-10#4436 ·
维护者通常 5 天内回复