Spec interpreter/implementation discrepancy - a local with an invalid type and 0 count

未关闭
#2,258 4 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
需要澄清
活跃度
活跃
技术栈
wasm
领域
compilers

调研方向

Start with the linked code-section specification and the reference interpreter, then reproduce the behavior using foo.wasm and compare it with V8, SpiderMonkey, and Wasmtime. Determine whether a zero-count local's type should be validated or discarded, and document the agreed specification or implementation outcome.

由索引模型根据 Issue 内容生成。

描述

My understanding of the definition of the code section in the online specification is that if an entry in locals has n=0 count that it's discarded and not represented in the AST of a module. This means that the corresponding local's type is parsed, but not validated. The reference interpreter implements this behavior and for this input:

(module binary
  "\00asm\01\00\00\00"

  "\01\04\01\60\00\00"       ;; Type section: 1 type
  "\03\02\01\00"             ;; Function section: 1 function

  "\0a\07"                 ;; code section, 7 bytes
  "\01"                    ;;   1 function body
  "\05"                    ;;   body size, 5 bytes
  "\01"                    ;;     1 locals entry
  "\00"                    ;;       count: 0
  "\63\01"                 ;;       type: (ref null 1) -- not a valid type index
  "\0b"                    ;;     end
)

the spec interpreter passes. This same module (foo.wasm) does not validate in V8, SpiderMonkey, or Wasmtime, however. These engines all validate the local's type and reject the module saying that it's out-of-bounds.

I wanted to raise this as an issue to see if others have thoughts about this. I don't have a preference for how exactly to go here myself.

主要语言
WebAssembly
星标
3.5k
派生
543
平均合并
1 天 28 分钟
30 天内合并 PR
35

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

WebAssembly/spec 的其他 Issue

查看 WebAssembly/spec 的全部 Issue

相似的 Issue

更多 Compilers Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。