Add a pass to relax nullabilities of definitions
维护者通常 1 天内回复
评估
这个 Issue 还没有评估数据。
描述
As a form of generalization, we can make all definitions nullable (e.g. globals, locals, function params, struct fields, arrays, tags), and insert ref.as_non_null as needed for cases that can't be relaxed (e.g. imported/exported functions, public structs). This transformation is valid since it only introduces ref.as_non_nulls that are no-ops.
The benefits of this are:
- When --traps-never-happen is enabled, it allows us to remove the majority of ref.as_non_null instructions with --strip-refining-casts
- It exposes more opportunities for locals to share a declaration group
- It also exposes more opportunities for type merging by causing more function and struct types to be identical
TypeGeneralizing (which is WIP) may also relax nullability, however it would never 'overgeneralize' and allow something to be nullable that would require inserting ref.as_non_null. So this pass may still be useful even alongside TypeGeneralizing.
In a prototype of this pass, I found that this pass reduces the size of a Google Wasm binary by ~3 percent (both in gzipped and uncompressed size).
Implementation plan:
- RelaxNullability for locals and params (#9349)
- Relax private struct/array fields
- Relax private functions even if they may be called indirectly
- Handle multi-value returns
- Double-check if relaxing return values is worth it
- 主要语言
- WebAssembly
- 星标
- 8.7k
- 派生
- 905
- 平均合并
- 1 天 23 小时
- 30 天内合并 PR
- 86
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
WebAssembly/binaryen 的其他 Issue
-
难度 1/5 1 小时以内 新手友好度 88/100
WebAssembly/binaryen#9135 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 半天 新手友好度 76/100
WebAssembly/binaryen#9018 · 3 条评论 ·
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 68/100
WebAssembly/binaryen#9366 ·
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 68/100
WebAssembly/binaryen#9365 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 45/100
WebAssembly/binaryen#9307 · 2 条评论 ·
维护者通常 1 天内回复