[AArch64] Always Branch patch on tbnz still broken in 6.0.10905 (regression of #6613/#7280)

未关闭
#8,696 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 2 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
58/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
cpp

调研方向

The issue identifies the AArch64 tbnz instruction and the Patch → Always Branch action; it does not name an implementation file or test. Start by locating the AArch64 patch logic for Always Branch and compare its behavior with Invert Branch and Never Branch on the provided instruction word, 0x37000108. Done means Always Branch produces the unconditional b target encoding 0x14000008 while the other two actions retain their reported behavior.

由索引模型根据 Issue 内容生成。

描述

Arch: ARM64

Version and Platform (required):

  • Binary Ninja Version: 6.0.10905 Personal (fe7968aa)
  • Edition: Non-Commercial
  • OS: macOS
  • OS Version: 27.0.1 (26A434)
  • CPU Architecture: M4

Bug Description:
On AArch64, "Patch → Always Branch" applied to a tbnz produces an invalid instruction instead of an unconditional branch. Regression of #6613 / #7280 (both closed) — still reproducible on current stable.

Steps To Reproduce:

  1. Open an arm64 Mach-O containing tbnz w8, #0, target (word 0x37000108)
  2. Right-click the tbnz → Patch → Always Branch

Expected Behavior:
b target = 14000008

Actual:
tbz w15, #0, target = 3600010f — condition inverted (tbnz→tbz) AND register changed (w8→w15), so the branch is still conditional and tests an unrelated register. Patch silently does nothing useful.

"Invert Branch" (→ tbz w8) and "Never Branch" (→ nop) work correctly on the same instruction; only Always Branch is broken.

Reproduced on a tiny Rust debug build (if input.trim() == "1"), instruction at offset 0x17fc. Happy to attach the binary if useful.

Screenshots/Video Recording:
Image

Binary:
ceramic spring optimizes quantitatively

主要语言
C++
星标
1.3k
派生
304
平均合并
2 天 20 小时
30 天内合并 PR
10

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

Vector35/binaryninja-api 的其他 Issue

查看 Vector35/binaryninja-api 的全部 Issue

相似的 Issue

更多 C++ Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。