`__attr` attributes on pointer types are lost on save/load

未关闭
#8,687 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 2 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
55/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
cpp, python
领域
backend, databases

调研方向

Start with the Python reproducer in the issue: parse int * __attr("key", "val"), add the type to a TypeArchive, and compare it before and after retrieving it. Trace how pointer and reference type attributes are serialized and restored, then find the relevant tests for type archives. Done means the archived type retains its __attr and the reproducer passes.

由索引模型根据 Issue 内容生成。

描述

Version and Platform (required):

  • Binary Ninja Version: 6.1.10984-dev
  • Edition: Commercial
  • OS: macOS
  • OS Version: 27.0.1 (26A434)
  • CPU Architecture: arm64

Bug Description:
In various cases when saving and loading, __attr attributes are lost on pointer and reference types.

Steps To Reproduce:
Run the following reproducer. (This uses a TypeArchive for simplicity, but the same behavior occurs when when defining a type in a database and saving and loading.)

from binaryninja import Platform, TypeParser, TypeArchive
platform = Platform['linux-x86_64']
(qnt, ty), errors = TypeParser.default.parse_type_string('int * __attr("key", "val")', platform)
assert len(errors) == 0
archive = TypeArchive.create('test.bnta', platform)
archive.add_type('test', ty)
print('before archive:', ty)
print('after archive:', archive.get_type_by_name('test'))

Output:

before archive: int32_t* __attr("key", "val")
after archive: int32_t*

Expected Behavior:
The __attr should still be there after archiving.

Additional Information:

  • The bug doesn't occur if you replace int * with, say, int (or apparently any type other than a pointer or reference).

  • This bug was discovered by AI but I vouch for the report.

主要语言
C++
星标
1.3k
派生
304
平均合并
2 天 20 小时
30 天内合并 PR
10

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

Vector35/binaryninja-api 的其他 Issue

查看 Vector35/binaryninja-api 的全部 Issue

相似的 Issue

更多 C++ Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。