Native ICE TURN failover fails when the servers use different credentials
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 半天
- 新手友好度
- 66/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 领域
- networking
调研方向
Start at STUNRequestCallback_AllocateRelay in src/ice.cpp and trace where m_strTURNRealm, m_strTURNNonce and m_arrTURNKey are set during the 401 challenge and read when building the next Allocate. First fix is resetting those members before advancing to the next server; done means a second TURN server with different realm/credentials is reached with its own key after the first times out. Then evaluate the second part of the report: whether non-timeout error responses should also advance the server list instead of marking relay failed, and check existing TURN/ICE tests or a two-server repro for coverage.
由索引模型根据 Issue 内容生成。
描述
I think I found a problem with TURN failover in the native ICE client.
If the first TURN server answers the Allocate with a 401 and then stops responding, the client times out and moves on to the second server. But it seems to keep the realm, nonce and key from the first server (m_strTURNRealm, m_strTURNNonce, m_arrTURNKey), so the request to the second server has the right username but the wrong realm and key. The second server answers 401, the client treats that as wrong credentials, and relay is marked as failed.
To reproduce, configure two TURN servers with different credentials or realms, where the first one answers the initial 401 challenge but drops the authenticated Allocate. With peers that can only connect through a relay, the connection fails. If the first server never answers at all, failover works fine.
Clearing m_strTURNRealm and m_strTURNNonce before trying the next server in STUNRequestCallback_AllocateRelay fixed it for me.
Related: the second server is only tried after a timeout. If the first server rejects the request, for example because of a wrong password, relay is marked as failed and the second server is never contacted. That means a backup server only helps when the first one is down, not when it is up and refusing us. Shouldn't an error response also fall through to the next server?
- 主要语言
- C++
- 星标
- 10k
- 派生
- 747
- 平均合并
- 5 天 19 小时
- 30 天内合并 PR
- 1
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
ValveSoftware/GameNetworkingSockets 的其他 Issue
-
Native ICE resolves STUN/TURN hostnames under the global lock可能已有人在做 @tintinhamans 于 13 天前认领。 未关闭
难度 4/5 3-5 天 新手友好度 55/100
-
WebRTC ICE keeps an idle thread per STUN/TURN hostname lookup可能已有人在做 @tintinhamans 于 13 天前认领。 未关闭
难度 3/5 1-2 天 新手友好度 68/100
ValveSoftware/GameNetworkingSockets#439 · 1 条评论 ·
-
难度 5/5 一周以上 新手友好度 25/100
ValveSoftware/GameNetworkingSockets#425 · 7 条评论 ·
-
难度 4/5 3-5 天 新手友好度 38/100
-
steamworks
难度 4/5 3-5 天 新手友好度 35/100
ValveSoftware/GameNetworkingSockets#386 · 2 条评论 ·
查看 ValveSoftware/GameNetworkingSockets 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 1 天内回复
-
(S1 - Need confirmation)
难度 2/5 1-3 小时 新手友好度 62/100
CleverRaven/Cataclysm-DDA#88974 ·
维护者通常 1 天内回复
-
comp-mysql
难度 2/5 1-3 小时 新手友好度 68/100
ClickHouse/ClickHouse#124749 ·
维护者通常 1 天内回复
-
Status: Needs confirmation Status: Needs triage
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 79/100
维护者通常 1 天内回复