Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

The last question's answers can be lost when a quiz ends

未关闭
  • 哪里不对？
#177 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
58/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
node.js, postgresql, typescript
领域
backend, database

调研方向

Start with apps/ws-server/src/utils/answerQueue.ts, focusing on flushSession, drainSession, and the insert-then-score-update sequence. Trace the quiz:end and end-of-questions callers, then locate the existing answer-queue tests and add coverage for an in-flight flush. Done means all buffered answers are written before the leaderboard is read, and answer persistence plus score updates are atomic or fully retryable.

由索引模型根据 Issue 内容生成。

描述

Backend first issue bug help wanted

Answers are buffered in apps/ws-server/src/utils/answerQueue.ts and written in batches. Two paths in that file can lose a batch.

1. drainSession does not actually wait for an in-flight flush
export async function flushSession(sessionId: string): Promise<void> {
    if (flushing.has(sessionId)) return;     // resolves immediately
    ...
}

export async function drainSession(sessionId: string): Promise<void> {
    ...
    try {
        await flushSession(sessionId);       // a no-op if a flush is already running
    } catch { }
    ...
    buffers.delete(sessionId);               // deletes answers regardless
}

If a flush is already running, await flushSession() returns straight away without waiting for it, and drainSession goes on to delete the buffer. Two losses follow:

  • Answers that arrived during the in-flight write are still in buffers and are deleted unwritten.
  • If that in-flight flush then fails, its catch requeues into buffers.get(sessionId) — a map that was just deleted — so the requeue silently does nothing.

This fires on the hot path: drainSession runs at quiz:end and at end-of-questions, immediately after the final question closes, which is exactly when a flush is most likely to be in flight.

Impact: the final question's answers are missing from the leaderboard everyone finishes on, and there is no error anywhere.

2. A failed score update is never retried correctly

The flush inserts answers and then increments scores in two sequential awaits. If the insert succeeds and the score transaction fails, the whole batch is requeued — but on retry the rows already exist, skipDuplicates drops them all, and the returned set is empty. The score increments are skipped and never happen.

Result: ParticipantAnswer rows exist with the right points, while Participant.score was never incremented. The retry looks like a success. The leaderboard sorts on score, so the rankings stay wrong for the rest of the quiz.

What a fix looks like
  • Have flushSession return the in-flight promise rather than undefined, so callers can genuinely await it, and loop in drainSession until the buffer is empty before deleting.
  • Make the insert and the score increments atomic, or derive score from SUM(points) instead of incrementing — the data to reconcile is already in ParticipantAnswer.points.
Definition of done
  • Ending a quiz writes every buffered answer before the final leaderboard is read
  • A failed flush either fully applies or fully retries; no state where answers exist but scores do not
  • A test covering "flush in flight when the quiz ends"
主要语言
TypeScript
星标
21
派生
7
平均合并
4 小时 13 分钟
30 天内合并 PR
20

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

TheCodeHeist-Coder/Rexial 的其他 Issue

查看 TheCodeHeist-Coder/Rexial 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。