Vinext 1.4.3/1.4.4 support: adapter gate rejects versions whose required corrections are already upstream

未关闭
#164 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
55/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
typescript, vite

调研方向

Start by reading the /vinext adapter’s version gate and the two capability checks that guard its source corrections, then inspect the CI configuration for the existing Vinext matrix. Update support for Vinext 1.3.x and 1.4.x while keeping unknown source shapes fail closed, and add 1.4.3 and 1.4.4 to CI. Done means the demo build and CI cover the requested versions.

由索引模型根据 Issue 内容生成。

描述

The /vinext adapter currently rejects every Vinext version except exactly 1.3.0:

if (pkg.version !== '1.3.0') throw new Error(...)

Reproduction

In this repository:

pnpm --filter vinext-demo add [email protected]
pnpm --filter vinext-demo build
# Error: Redact Vinext integration supports vinext 1.3.0; found 1.4.3.

Compatibility evidence

The adapter's two source corrections are guarded by capability checks. I checked Vinext 1.4.3 and 1.4.4: both contain the corrected implementations, so Redact's transforms should be no-ops for those versions.

In a scratch install, I changed only the installed Redact /vinext adapter's version check to let the newer Vinext versions pass. With that local gate change, vinext-demo builds on 1.3.0, 1.4.3, and 1.4.4. These are build checks; the requested CI matrix will provide repeatable coverage.

Requested change

Accept Vinext 1.3.x and 1.4.x, while warning on other version families. Keep the source-shape checks as the safety boundary: skip corrections when the installed Vinext code already has the corrected form, and fail closed when its shape is unknown. Add the Vinext versions above to the CI matrix.

The client instrumentation API request is tracked separately in cloudflare/vinext#4579; it does not cover the app-rsc-handler correction or Flight timing. @cloudflare/vite-plugin 2.x remains out of scope.

I can open a PR with the gate change and CI coverage.

主要语言
TypeScript
星标
537
派生
22
平均合并
10 小时 27 分钟
30 天内合并 PR
40

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

TanStack/redact 的其他 Issue

查看 TanStack/redact 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。