Error boundary with a lazy fallback blanks the Suspense boundary when a child throws during hydration (0.3.0)

未关闭
#154 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
56/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
react, typescript

调研方向

Start by tracing hydration and Suspense error handling in Redact; the report identifies RenderSuspenseCapture when an error boundary renders a lazy fallback. Reproduce the case with the supplied server and client entries, then compare the DOM and page errors with React. Done means hydration preserves or renders the fallback without an unhandled rejection.

由索引模型根据 Issue 内容生成。

描述

Summary

If a component throws during hydration and the error boundary's fallback is a lazy component, Redact empties the enclosing Suspense boundary and reports an unhandled RenderSuspenseCapture. The fallback never appears, even after the lazy component resolves. React keeps the server-rendered content and shows the fallback.

With a synchronous fallback, the same tree works correctly in Redact.

Reproduction

shared.jsx

import { Component, Suspense, lazy } from 'react'

const isServer = typeof document === 'undefined'

class Boundary extends Component {
  state = { error: null }
  static getDerivedStateFromError(error) {
    return { error }
  }
  render() {
    return this.state.error ? <LazyFallback /> : this.props.children
  }
}

function Fallback() {
  return <section>something went wrong</section>
}

const LazyFallback = lazy(async () => ({ default: Fallback }))

function Route() {
  if (isServer) return <Fallback />
  throw new Error('boom')
}

export function App() {
  return (
    <main>
      <Suspense fallback={<p>loading</p>}>
        <Boundary>
          <Route />
        </Boundary>
      </Suspense>
    </main>
  )
}

server.jsx

import { renderToString } from 'react-dom/server'
import { App } from './shared.jsx'

export const render = () => renderToString(<App />)

client.jsx

import { hydrateRoot } from 'react-dom/client'
import { App } from './shared.jsx'

hydrateRoot(document.getElementById('root'), <App />)

Build the server and client entries with and without the redact() plugin, put render()'s output in #root, load the client bundle and wait a moment.

Runtime #root after hydration Page errors
React 19.3.1 <main><section>something went wrong</section></main> None
Redact 0.3.0 <main><!--$0--><!--/$--></main> RenderSuspenseCapture (unhandled rejection)
Why this comes up in real apps

Route above copies what TanStack Router's MatchInner does for a route whose loader failed: the server renders the errorComponent directly, and the client throws match.error so the CatchBoundary catches it. When the errorComponent is code-split, the fallback is lazy.

In a TanStack Start app, the server correctly sends the error page with a 500. Hydration then removes it and leaves an empty <main>, so the visitor sees a blank page where the error and its retry action should be. Stopping the router from code-splitting errorComponent avoids the problem.

Possibly related

#137 also involves RenderSuspenseCapture during hydration, but its trigger is different: a boundary suspending again while retrying hydration. Its proposed fix may or may not cover this case, as I have not tested it. #43 changes how errors thrown by a fallback propagate, whereas here the fallback suspends.

Environment
  • @tanstack/redact 0.3.0 (also 0.2.5), default redact() preset
  • React 19.3.1 (control)
  • Vite 7.3.7, @vitejs/plugin-react 5.2.0
  • Chromium 156 (Playwright), Node 26
主要语言
TypeScript
星标
581
派生
28
平均合并
13 小时 48 分钟
30 天内合并 PR
45

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

TanStack/redact 的其他 Issue

查看 TanStack/redact 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。