Evaluate signed-zero equality for QueryObserver snapshots
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 25/100
- Issue 类型
- 功能
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- react, typescript
调研方向
Start with the signed-zero regression case in packages/query-core/src/__tests__/queryObserver.test.tsx, then read the result comparison in packages/query-core/src/queryObserver.ts and shallowEqualObjects in packages/query-core/src/utils.ts. This issue asks maintainers to decide the intended equality semantics, including effects on notifications, NaN, and snapshot caching; it is design work rather than a scoped first contribution. Done means the behavior is documented and, if changed, regression tests cover the optimistic result, current snapshot, and affected equality and notification behavior.
由索引模型根据 Issue 内容生成。
描述
Summary
Evaluate whether QueryObserver snapshots should distinguish -0 from 0 when selected placeholder data changes. This is a follow-up for maintainers to decide the desired equality semantics; it does not assume that a global equality change is required.
Reproduction and current behavior
In the signed-zero regression case in packages/query-core/src/__tests__/queryObserver.test.tsx, create an observer with enabled: false, placeholderData: 1, structuralSharing: false, and a selector returning -0. Update the options to use a selector returning 0, then call getOptimisticResult with the updated options.
The PR author verified that the optimistic result contains 0, while getCurrentResult().data still contains -0. The shallow comparison treats these values as equal and preserves the current snapshot. The useQuery render in this case uses the optimistic result.
Decision and affected areas
Review the observer result comparison and update behavior in packages/query-core/src/queryObserver.ts and shallowEqualObjects in packages/query-core/src/utils.ts. Consider whether signed zeros should count as different, and whether any change should be local to observer results or use Object.is semantics more broadly. Assess effects on notifications, render optimizations, other equality cases such as NaN, and the useSyncExternalStore snapshot caching contract.
Acceptance criteria
- Maintainers decide and document the intended signed-zero behavior for observer snapshots.
- If a change is warranted, implement the chosen behavior without breaking snapshot stability or notification semantics.
- If a change is made, add regression coverage for the chosen behavior, including the optimistic result and current snapshot, and cover any affected equality and notification behavior.
Context
- Pull request: https://github.com/TanStack/query/pull/12564
- Review discussion: https://github.com/TanStack/query/pull/12564#discussion_r4509388878
- Requested by: @brennanbutler01
- 主要语言
- TypeScript
- 星标
- 50.6k
- 派生
- 4.2k
- 平均合并
- 8 小时 37 分钟
- 30 天内合并 PR
- 450
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
TanStack/query 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 78/100
TanStack/query#12466 · 1 条评论 ·
维护者通常 1 天内回复
-
solid-query: STRICT_READ_UNTRACKED on Solid 2 — client()/options() read in component body (useMutation, useBaseQuery)可能重新可做 @LeonxLJX 于 74 天前认领,目前没有进行中的 PR。 未关闭
难度 2/5 1-3 小时 新手友好度 84/100
TanStack/query#11358 · 2 条评论 · 1 个 reaction ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 25/100
维护者通常 1 天内回复
-
Infinite render loop when select maps keepPreviousData to undefined in v5.105.2+可能已有人在做 @mooxl 于 6 天前认领。 未关闭
难度 3/5 1-2 天 新手友好度 35/100
TanStack/query#12574 · 1 条评论 ·
维护者通常 1 天内回复
-
infiniteQuery throws "getNextPageParam is not a function" when 2+ stale pages are cached可能已有人在做 @abu-tahir-0 于 7 天前认领。 未关闭
难度 3/5 1-2 天 新手友好度 42/100
维护者通常 1 天内回复
相似的 Issue
-
bot:ai-assisted component:platform-js status:untriaged
难度 1/5 1 小时以内 新手友好度 74/100
midnightntwrk/platform-js#38 ·
-
难度 2/5 1-3 小时 新手友好度 68/100
ranxianglei/billion-context#7068 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
mybigday/whisper.rn#348 ·
-
enhancement severity:low
难度 2/5 1-3 小时 新手友好度 82/100
Battle-Cattle/BCUK-Bot-4#1075 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 67/100
ilan-pinto/roaring-lions#1552 ·
维护者通常 1 天内回复