Windows: an unsupervised gap run can leave child processes running (no process tree kill)

未关闭
#74 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
领域
cli, devtools

调研方向

The gap is in the unsupervised win32 run path, which the issue says has no process group supervisor, so start there and find where child processes are spawned and where stop and exit are handled. Compare that path with the supervised one to see what cleanup it lacks. Done means a stopped or finished run leaves no node.exe child under its PID tree, shown by a Windows acceptance test. The fix needs Windows process-tree knowledge (Job Objects or taskkill /T), so it is not a good first pick.

由索引模型根据 Issue 内容生成。

描述

Found in the review of #58 (F4e). An unsupervised win32 run, the one without a supervisor (Windows has no process groups), is exempt from "no process outlives the CLI": a Vitest worker or a browser driver a test starts can outlive the CLI there. This predates #58.

Proposed fix: kill the process tree on win32 with Job Objects (a job with kill-on-close, assigned at start) or with taskkill /T /F /PID <pid> on stop and at exit. Acceptance: a hooked or real stop leaves no node.exe child running under the run's PID tree.

主要语言
JavaScript
星标
5
派生
1
平均合并
8 小时 31 分钟
30 天内合并 PR
60

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

TanStack/oracles 的其他 Issue

查看 TanStack/oracles 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。