daemon inputs: appends, partial and failed writes hide a file's earlier content; the runner-file rule matches users' paths

未关闭
#154 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
48/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
领域
testing, tooling

调研方向

Start with inputs.mjs and trace how appendFile*, r+, and open flags are recorded; check the CLI's inject path for passing the session pid and home to the harness. Use the described appendGate oracle, where file b appends to tests/gate.json and parses the whole file. Done when prior file content remains an input for append and r+, failed writes do not count as writes, and the runner-file rule matches the session's real pid and home.

由索引模型根据 Issue 内容生成。

描述

Findings (review of #133, F9 and F10; both plausible, LOW).

F9. An append, a partial write, or a failed write hides a file's earlier content.

  • inputs.mjs counts appendFile* as a write and records the write before the call.
  • So in these cases the rest of the file is an input that is never recorded:
    • a test appends to a fixture that already exists, then reads it;
    • a test writes with { flag: 'r+' };
    • a test catches a failed write (to a read-only file), then reads the existing file.
  • Plan:
    • Record a read first for an append and for r+.
    • Record the write only after the call succeeds; for the async forms, when its promise or callback resolves.
    • The same applies to #141's open-flag rule (a keeps the earlier content, so it is a read too).
    • Oracle: a gate kind appendGate, in which file b appends to tests/gate.json and parses the whole file. The edit changes the part that was already there.

F10. The runner-file rule matches users' paths.

  • /\/\.oracle-gaps-\d+[-/]/ also matches a user's file named .oracle-gaps-<digits>-….
  • The fix matches the session's real pid and home, which the CLI already knows and can pass to the harness through inject.

Authority: R46, G42, I8 (v21.2), and M 2026-11-17 "Own writes aren't inputs", whose scope is the writer's own output only.

主要语言
JavaScript
星标
5
派生
1
平均合并
11 小时 18 分钟
30 天内合并 PR
66

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

TanStack/oracles 的其他 Issue

查看 TanStack/oracles 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。