SQLite persistence silently serializes Temporal values as {}, breaking hydration and subset queries
维护者通常 1 天内回复
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 50/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- sqlite, typescript
- 领域
- databases
调研方向
Start by reading the shared serializer in @tanstack/db-sqlite-persistence-core and tracing how SQLiteCorePersistenceAdapter.applyCommittedTx writes and restores values. Run the standalone reproduction linked in the issue with Node 22.13 or newer to confirm the failing cases. Done means Temporal values retain their types and values through rows, metadata, and replay, and the listed subset queries return the expected keys.
由索引模型根据 Issue 内容生成。
描述
- I've validated the bug against the latest version of DB packages
Describe the bug
@tanstack/db-sqlite-persistence-core silently stores Temporal.Instant and Temporal.PlainDate as {}. After reopening the SQLite database, the original values and types are lost. This also affects nested values, row metadata, collection metadata, and transaction replay payloads.
We encountered this in an Expo application. The reproduction uses the shared core with real SQLite on Node, so it requires no application code or Expo setup.
To reproduce
Reproduction: standalone test and instructions, on branch codex/repro-temporal-persistence in robertf224/db.
git clone --branch codex/repro-temporal-persistence https://github.com/robertf224/db.git
cd db/reproductions/temporal-persistence
pnpm install --frozen-lockfile
pnpm test
Use Node 22.13 or newer. The reproduction writes two different dates using SQLiteCorePersistenceAdapter.applyCommittedTx, closes and reopens the SQLite file, then checks hydration, metadata, replay, and subset queries. The command intentionally exits 1 because its assertions describe the expected behavior.
The persisted row JSON includes:
{
"instant": {},
"plainDate": {},
"nested": { "dates": [{}] }
}
For rows early (2026-01-02) and late (2026-01-03):
| Query | Expected keys | Actual keys |
|---|---|---|
plainDate = Temporal.PlainDate.from('2026-01-02') |
['early'] |
[] |
plainDate > Temporal.PlainDate.from('2026-01-02') |
['late'] |
[] |
ORDER BY plainDate ASC LIMIT 1 |
['early'] |
['late'] |
These results occur both without and with a persisted expression index installed. The query failures follow value corruption; this does not establish a separate compiler defect on correctly encoded Temporal values.
Verified result: 3 passing controls, 10 failing cases. Date round-tripping, a Date range predicate, and ISO string preservation pass. Temporal's own JSON.stringify returns ISO strings, so the {} loss occurs in persistence's recursive encoding before JSON serialization.
Expected behavior
Supported Temporal values should preserve their type and value across persistence, including nested values and metadata. Subset predicates, sorting, pagination, and persisted index expressions should agree with those values. If Temporal is unsupported, an explicit error would be preferable to silently destroying the data.
Environment
- macOS, Node 24.19.0, pnpm 11.19.0
@tanstack/db0.11.3@tanstack/db-sqlite-persistence-core0.4.3 (npm latest checked October 5, 2026)temporal-polyfill0.3.2- No patches; real file-backed SQLite through
node:sqlite
Additional context
The shared serializer recursively enumerates objects but has no Temporal handling. These Temporal instances have no enumerable own state, so different values collapse to the same empty object.
@tanstack/offline-transactions 1.0.61 already preserves these Temporal values when global constructors are registered; the reproduction includes that as a passing control. This report concerns the remaining SQLite persistence gap.
Native Temporal support or an extensible codec would help. A codec contract would need to cover row values, metadata, replay, query literals, and compatible index/comparison semantics. We currently wrap writes and reads in an application codec, but already-corrupted {} timestamps need cache invalidation or refetching.
- 主要语言
- TypeScript
- 星标
- 3.9k
- 派生
- 268
- 平均合并
- 1 天 3 小时
- 30 天内合并 PR
- 193
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
TanStack/db 的其他 Issue
-
难度 3/5 1-2 天 新手友好度 72/100
维护者通常 1 天内回复
-
Debounce and throttle paced mutations allow concurrent persistence despite the documented single-flight contract可能已有人在做 @KyleAMathews 今天认领。 未关闭
难度 4/5 3-5 天 新手友好度 35/100
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 68/100
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 48/100
维护者通常 1 天内回复
-
难度 5/5 一周以上 新手友好度 45/100
维护者通常 1 天内回复
相似的 Issue
-
triage
难度 2/5 1-3 小时 新手友好度 75/100
维护者通常 1 天内回复
-
agent-ready area: config area: skills type: chore upstream: brain-kit
难度 1/5 1 小时以内 新手友好度 95/100
-
enhancement priority:low ready-for-dev
难度 2/5 1-3 小时 新手友好度 75/100
维护者通常 1 天内回复
-
bug escritorio mapa
难度 2/5 1-3 小时 新手友好度 72/100
marcosferr/reporte-ciudadano#4 · 1 条评论 ·
-
area: material/sort gemini-triaged needs triage
难度 2/5 1-3 小时 新手友好度 70/100
angular/components#33933 ·
维护者通常 1 天内回复