Activity events that a chat middleware emits are streamed but never recorded or persisted
维护者通常 1 天内回复
评估
这个 Issue 还没有评估数据。
描述
TanStack AI version
@tanstack/ai 0.69.0, @tanstack/ai-persistence 0.9.0 (the same behavior is on main at 85c2956)
Framework/Library version
Node 26.3.1, server only (no UI framework involved)
Describe the bug and the steps to reproduce it
An ACTIVITY_SNAPSHOT (or ACTIVITY_DELTA) that a chat middleware returns from onChunk reaches the client live, but the engine does not record it in ctx.activities. withPersistence therefore never saves it, and reconstructChat returns no activity row for it after a reload. The same event yielded by the adapter is recorded, saved and restored.
Activity rows and the activities store came in #1323 (issue #1286).
The cause is the order in the chat engine. In packages/ai/src/activities/chat/index.ts, each adapter chunk goes through handleStreamChunk(raw) before middleware runs. handleStreamChunk is the only place that applies ACTIVITY_SNAPSHOT / ACTIVITY_DELTA to the activity records (setActivities). Chunks that middleware adds go through emitPublicChunks, which normalizes and yields them but does not apply activity events. withPersistence saves ctx.activities, so it only ever sees adapter activity.
This is about the activity store (stores.activities, which withPersistence writes from ctx.activities and reconstructChat reads). It is not about the durability log, the delivery stream that toServerSentEventsResponse({ durability }) appends to. From the code, the middleware chunk is on the public stream, so I expect the durability log to carry it like any other chunk. I did not test that. The gap is that reconstructChat has no row for it.
The docs in docs/persistence/chat-persistence.md ("AG-UI activity rows on reload") present activity rows as the place for "a search progress card", and say withPersistence and reconstructChat "save and restore the rows when stores.activities is set". docs/advanced/middleware.md documents that onChunk can return StreamChunk[] to add chunks. A progress card is often made by middleware (for example, middleware that wraps a search tool), not by the provider adapter, so the two documented features do not work together today.
Steps:
- Install
@tanstack/[email protected]and@tanstack/[email protected]. - Save the script below as
repro.mjsin an ESM package and runnode repro.mjs.
repro.mjs:
import { chat, defineChatMiddleware } from '@tanstack/ai'
import { memoryPersistence, reconstructChat, withPersistence } from '@tanstack/ai-persistence'
const progress = {
type: 'ACTIVITY_SNAPSHOT',
messageId: 'search-1',
activityType: 'search',
content: { status: 'done', hits: 3 },
timestamp: Date.now(),
}
function adapter(withActivity) {
return {
kind: 'text',
name: 'fixed',
model: 'test-model',
'~types': {},
async *chatStream({ threadId, runId }) {
const t = Date.now()
yield { type: 'RUN_STARTED', threadId, runId, timestamp: t }
if (withActivity) yield progress
yield { type: 'TEXT_MESSAGE_START', messageId: 'msg-1', role: 'assistant', timestamp: t }
yield { type: 'TEXT_MESSAGE_CONTENT', messageId: 'msg-1', delta: 'answer', timestamp: t }
yield { type: 'TEXT_MESSAGE_END', messageId: 'msg-1', timestamp: t }
yield { type: 'RUN_FINISHED', threadId, runId, finishReason: 'stop', timestamp: t }
},
}
}
// The same activity, produced by a middleware instead of the adapter.
const searchProgress = defineChatMiddleware({
name: 'search-progress',
onChunk(ctx, chunk) {
if (chunk.type === 'TEXT_MESSAGE_START') return [progress, chunk]
},
})
async function run(label, fromMiddleware) {
const persistence = memoryPersistence()
const threadId = `thread-${label}`
const stream = chat({
adapter: adapter(!fromMiddleware),
messages: [{ role: 'user', content: 'search' }],
threadId,
runId: `run-${label}`,
middleware: [
withPersistence(persistence),
...(fromMiddleware ? [searchProgress] : []),
],
})
const wire = []
for await (const chunk of stream) wire.push(chunk.type)
const stored = await persistence.stores.activities.loadActivities(threadId)
const res = await reconstructChat(persistence, new Request(`https://x/chat?threadId=${threadId}`))
const roles = (await res.json()).messages.map((m) => m.role)
console.log(label)
console.log(' ACTIVITY_SNAPSHOT on the stream:', wire.includes('ACTIVITY_SNAPSHOT'))
console.log(' stored activities:', JSON.stringify(stored))
console.log(' reconstructChat roles:', JSON.stringify(roles))
}
await run('from adapter', false)
await run('from middleware', true)
Expected
The activity row is stored and restored in both runs:
from adapter
ACTIVITY_SNAPSHOT on the stream: true
stored activities: [{"id":"search-1","activityType":"search","content":{"status":"done","hits":3},"index":1}]
reconstructChat roles: ["user","activity","assistant"]
from middleware
ACTIVITY_SNAPSHOT on the stream: true
stored activities: [{"id":"search-1", ...}]
reconstructChat roles: ["user","activity","assistant"]
Actual
from adapter
ACTIVITY_SNAPSHOT on the stream: true
stored activities: [{"id":"search-1","activityType":"search","content":{"status":"done","hits":3},"index":1}]
reconstructChat roles: ["user","activity","assistant"]
from middleware
ACTIVITY_SNAPSHOT on the stream: true
stored activities: []
reconstructChat roles: ["user","assistant"]
The expected contract, from the docs above, is that an activity event on the stream is saved and restored no matter which layer added it. A possible fix is to apply ACTIVITY_SNAPSHOT / ACTIVITY_DELTA to ctx.activities for middleware output in emitPublicChunks too. If activity rows are meant to come only from adapters, the activity docs should say so.
Your Minimal, Reproducible Example - (Sandbox Highly Recommended)
Inline above. Plain Node script, no network, no model.
Screenshots or Videos (Optional)
None.
Do you intend to try to help solve this bug with your own PR?
Maybe, I'll investigate and start debugging
Terms & Code of Conduct
- I agree to follow this project's Code of Conduct
- I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
- 主要语言
- TypeScript
- 星标
- 3.2k
- 派生
- 365
- 平均合并
- 1 天 11 小时
- 30 天内合并 PR
- 278
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
TanStack/ai 的其他 Issue
-
Maintainer sweep: assign a PR to the assignee of the issue it closes可能已有人在做 @tombeckenham 于 1 天前认领。 未关闭
维护者通常 1 天内回复
-
Durable resume through withPersistence never fills ctx.inputResponse for mcp_input interrupts可能已有人在做 @tombeckenham 于 1 天前认领。 未关闭waiting-on: maintainer
维护者通常 1 天内回复
-
ai, ai-persistence: a nested subagent that waits runs again from the start under withPersistence可能已有人在做 @tombeckenham 于 1 天前认领。 未关闭waiting-on: maintainer
维护者通常 1 天内回复
-
ai-ollama: streamed chat() reports finishReason "stop" when done_reason is "length"可能已有人在做 @AlemTuzlak 于 2 天前认领。 未关闭waiting-on: maintainer
维护者通常 1 天内回复
-
Discriminate status-dependent record and option types (RunRecord, SessionIndexEntry, InputState, durable-only options)可能已有人在做 @jherr 于 8 天前认领。 未关闭enhancement waiting-on: maintainer
维护者通常 1 天内回复
相似的 Issue
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P3
难度 2/5 1-3 小时 新手友好度 73/100
openclaw/openclaw#182077 · 1 条评论 · 1 个 reaction ·
维护者通常 1 天内回复
-
aikido high security
难度 2/5 1-3 小时 新手友好度 75/100
dequelabs/axe-linter-action#161 ·
-
[Feature Request] Update the DimCode agent icon to the 45:32 brand mark可能已有人在做 @eric8810 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 66/100
lyswhut/lx-music-desktop#3026 ·
-
难度 2/5 1-3 小时 新手友好度 76/100
abhigyanpatwari/GitNexus#3704 ·
维护者通常 1 天内回复