MCP clients need a long-lived credential that works only on the MCP routes (a login token dies in 15 minutes)
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 35/100
- Issue 类型
- 功能
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- github-actions, typescript
- 领域
- api, authentication, backend, devops, documentation, security
调研方向
Start by reviewing auth/jwt.ts, auth/authorize.ts, worker.ts, routes/admin.ts, and the listed authorization and audit tests. Confirm the owner decisions on lifetime, caller-only minting, secret rotation, and endpoint scope before implementing the planned changes. Done means scoped tokens work only on the MCP routes, existing access tokens still work there, invalid tokens are rejected elsewhere, audit and startup-safety tests pass, workflows and documentation are updated, and the audit checks remain consistent.
由索引模型根据 Issue 内容生成。
描述
Problem
Claude Desktop reaches WorkWell's MCP server through mcp-remote with a fixed Authorization: Bearer <JWT> header (docs/MCP.md). The only bearer token the backend issues is the login access token: 900 s (createJwt default, backend-ts/src/auth/jwt.ts), and mcp-remote cannot refresh a fixed header. So the connection dies 15 minutes after each mint, and Claude Desktop reports the WorkWell MCP server as disconnected on every launch.
Verified 2026-09-24:
- No route accepts anything but that access token.
extractPrincipal(auth/authorize.ts) verifies onlyWORKWELL_AUTH_JWT_SECRETaccess tokens; there is no API key or service credential anywhere inbackend-ts/src. - The 30-day
WORKWELL_AUTH_ACCESS_TTL_SECONDSthat once covered this was read only by the Java backend; the TypeScript port never wired it, and #703 removes it from the workflows. - Making every access token long-lived is rejected: access tokens are stateless and unrevocable, so a 30-day one outlives logout for every browser user (and undoes #688's revocation).
ROLE_MCP_CLIENTalso opens/cds-services/**and/$cql(auth/authorize.ts), so a new credential must not simply reuse the role gate.
Workaround until this ships: disable the workwell entry in Claude Desktop's MCP settings, or re-mint a token from /api/auth/login per session.
Design
A separate token that is long-lived and accepted only on /sse and /mcp/**.
- Own secret: signed with
WORKWELL_MCP_TOKEN_SECRET, neverWORKWELL_AUTH_JWT_SECRET. The ordinary verifier therefore cannot accept an MCP token even if the route check is wrong, and rotating the MCP secret revokes every MCP token without signing anyone out of the app. Unset secret = feature off. - Claims:
{ sub, role, scope: "mcp", jti, iat, exp }.sub/roleare the minting user's, so the audit actor (MCP_TOOL_CALLED), the demo-account profile refusal and the per-tool role gates inmcp/dispatch.tsbehave exactly as today. The tools stay read-only. - Route scope: the MCP verifier is consulted only when the path is
/sseor/mcp/**. Everywhere else, including/cds-services/**,/$cql,/api/**and/api/auth/*, an MCP token is an unauthenticated request. The MCP routes keep accepting a normal access token. - Minting:
POST /api/admin/mcp-tokens{ ttlDays }(ADMIN, via the existing/api/admin/**rule), for the caller only. Default 30 days, cap 90. Audit-first:MCP_TOKEN_MINTED(subject, role,jti,expiresAt; never the token) is written before the token is returned, once. - No table. Revocation is all-at-once by rotating the secret. That is acceptable on a synthetic-data sandbox with a few MCP users; per-token revocation is the PHI-phase step below.
Plan (one PR, feat/mcp-scoped-token)
auth/jwt.ts: export the HS256 sign/verify helpers (don't copy them); add a smallauth/mcp-token.tsthat issues and verifies the scoped token (rejects a missing or wrongscope, expired, or wrong-secret token).auth/authorize.ts+worker.ts:extractPrincipaltakes the pathname and an optional MCP verifier, used only on/sseand/mcp/**;rebuildAuthIfNeededbuilds it fromWORKWELL_MCP_TOKEN_SECRETand rebuilds when either secret changes.config/startup-safety.ts: when set in production, the MCP secret passes the same strength rule as the JWT secret and must differ from it.- Mint route under
routes/admin.ts, audit-first, added toaudit/audit-order.test.ts. Re-runscripts/audit-order-sweep.pyand keepDATA_MODEL_CONTRACTS.md§4's count in step if it moves. Add to the OpenAPI spec if admin routes are listed there. - Workflows: add
WORKWELL_MCP_TOKEN_SECRETto the three deploy workflows and both reconcilers (mirrored). The owner createsWORKWELL_MCP_TOKEN_SECRET_TWH/_MAUI/_STAGINGin GitHub secrets. - Docs:
MCP.md(mint, configuremcp-remote, rotate to revoke),DEPLOY.mdsecret table, one gap line inPRODUCTION_READINESS_2026-07.md(below),JOURNAL.md.
Tests (each mutation-checked: break the guard, see the test fail)
- An MCP token authenticates
/sseand/mcp/**and is 401 on/api/cases,/api/admin/*,/cds-services/*,/$cql. - A normal access token still works on the MCP routes.
verifyAccessTokenrejects an MCP token (secret separation), and a main-secret token carryingscope: "mcp"is not accepted as an MCP token.- Expired, wrong-scope and tampered MCP tokens are 401.
- Secret unset: the mint route answers 404 and no MCP token verifies.
- A demo account's MCP token is refused on a profile that refuses demo accounts (Maui).
- Mint is audit-first; the event payload never contains the token;
ttlDaysabove 90 or below 1 is a 400. - Startup safety refuses a weak MCP secret, or one equal to the JWT secret, in production.
Decisions for the owner before building
- Lifetime: default 30 days, cap 90?
- Caller-only minting, or may an admin mint for a named service account (e.g. a
ROLE_MCP_CLIENT+ROLE_CASE_MANAGERidentity)? Recommendation: caller-only first. - Revoke by rotating the secret (no DDL) for the sandbox, per-token revocation later? Recommendation: yes.
- Endpoint + documented
curlonly, or also a button on the Admin page? Recommendation: endpoint only first.
Not in scope
- OAuth for
mcp-remote(it supports the MCP authorization flow, but WorkWell would need an authorization server). - Per-token revocation. Before the PHI phase, replace the stateless token with stored, hashed API keys: per-key revocation, last-used time, a list in Admin. That is a table (owner DDL); record it in
PRODUCTION_READINESS_2026-07.mdas part of this PR. /cds-services/**and/$cql. They keep their current credential.
- 主要语言
- TypeScript
- 星标
- 0
- 派生
- 0
- 平均合并
- 4 小时 39 分钟
- 30 天内合并 PR
- 99
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
Taleef7/workwell 的其他 Issue
-
frontend maui-pilot pilot-ask question
难度 2/5 1-3 小时 新手友好度 75/100
维护者通常 1 天内回复
-
documentation owner-ops waiting
难度 1/5 1-3 小时 新手友好度 86/100
维护者通常 1 天内回复
-
owner-ops waiting
难度 1/5 1-3 小时 新手友好度 85/100
维护者通常 1 天内回复
-
backend enhancement
难度 5/5 一周以上 新手友好度 35/100
维护者通常 1 天内回复
-
backend maui-pilot webchart-convergence
难度 4/5 3-5 天 新手友好度 68/100
维护者通常 1 天内回复
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 88/100
openedx/frontend-app-authoring#3274 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 88/100
-
area/documentation status/need-triage
难度 1/5 1 小时以内 新手友好度 95/100
google-gemini/gemini-cli#29548 ·
维护者通常 1 天内回复
-
sdk-typescript vector-store
难度 2/5 半天 新手友好度 82/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复