Replace script-order globals shared between board.js, game.js and drag.js
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 48/100
- Issue 类型
- 重构
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- eslint, javascript, node.js
调研方向
Read docs/ARCHITECTURE.md and .github/CONTRIBUTING.md, then trace the shared state and window accessors in js/board.js, js/game.js, and js/drag.js alongside the globals in eslint.config.js. Start by checking the test bootstrap work in related issue #40 and the existing tests in tests/. Run npm test and npm run lint; done means board rendering no longer reads game variables, missing drag dependencies raise errors, and the per-file globals list shrinks or disappears.
由索引模型根据 Issue 内容生成。
描述
Summary
The seven scripts share one global scope and depend on load order. board.js and game.js read each other's variables, drag.js reaches both through window.* behind typeof guards, and eslint.config.js hand-lists the cross-file globals for every file.
Where
js/board.js:184(readsmoveHistoryfromgame.js),js/game.js:109(readsselectedSquareandpossibleMovesfromboard.js)js/game.js:908-921,js/board.js:252-266(window getters)js/drag.js:97-115,js/drag.js:230-232,js/drag.js:256eslint.config.js:35-155package.json:5("type": "module"while every file uses CommonJS exports)
Impact
Adding or moving a function means editing the source, the ESLint globals list and each test preamble. The typeof guards in drag.js turn a wiring mistake into a silent no-op (a drop that does nothing). The globals list is already stale: drag.js is granted handleBoardClick, which it does not use.
Suggested fix
- Move the shared test bootstrap into one helper (#40); no production change.
- Break the cycle: pass
lastMoveintoupdateBoardVisuals, and giveselectedSquareandpossibleMovesone owning module with accessors. - Replace the
window.*getters with one explicit namespace object and drop thetypeofguards. - Optionally convert to ES modules, which removes the per-file globals lists. ES modules do not load from
file://, so decide first whether openingindex.htmldirectly must keep working.
Acceptance criteria
-
board.jsrenders without readinggame.jsvariables - A missing dependency in
drag.jsraises an error instead of doing nothing - The per-file globals in
eslint.config.jsshrink or disappear
Getting started
- Relevant files:
js/board.js,js/game.js,js/drag.js,eslint.config.js,tests/ - How to run tests:
npm install, thennpm testandnpm run lint - Related docs:
docs/ARCHITECTURE.md,.github/CONTRIBUTING.md
Filed by repo-audit/full-audit at 8a2c86c. Severity: medium. Effort: M. audit-key: tech-debt|js/board.js|window-globals
- 主要语言
- JavaScript
- 星标
- 4
- 派生
- 2
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
TMHSDigital/Static_Chess 的其他 Issue
-
enhancement good first issue severity: medium
难度 2/5 1-3 小时 新手友好度 78/100
TMHSDigital/Static_Chess#53 ·
-
documentation good first issue severity: low
难度 2/5 1-3 小时 新手友好度 72/100
TMHSDigital/Static_Chess#49 ·
-
documentation good first issue severity: low
难度 2/5 1-3 小时 新手友好度 83/100
TMHSDigital/Static_Chess#48 ·
-
documentation severity: medium
难度 2/5 1-3 小时 新手友好度 78/100
TMHSDigital/Static_Chess#47 ·
-
documentation good first issue severity: low
难度 2/5 1-3 小时 新手友好度 82/100
TMHSDigital/Static_Chess#46 ·
查看 TMHSDigital/Static_Chess 的全部 Issue
相似的 Issue
-
good first issue tests
难度 1/5 1-3 小时 新手友好度 68/100
维护者通常 1 天内回复
-
enhancement good first issue
难度 2/5 1-3 小时 新手友好度 90/100
-
1️⃣ phase/under-investigation flaky/confirmed flaky/needs-decision type/bug
难度 2/5 1-3 小时 新手友好度 65/100
growilabs/growi#12246 · 3 条评论 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 72/100
TMHSDigital/Free-Game-Dev-Assets#301 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 79/100