Move trophy definitions next to each game and type trophy ids
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 55/100
- Issue 类型
- 重构
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- typescript, vite
调研方向
Start with shared/achievements.ts and games/registry.json to understand the trophy list and game registry, then read src/hub/trophies-panel.ts for how games without trophies are displayed. The issue proposes four steps, including adding tests despite noting that no test suite exists; first run npm run typecheck and npm run build to establish the baseline. Done means mistyped trophy IDs fail typechecking and adding a game no longer requires editing shared/achievements.ts.
由索引模型根据 Issue 内容生成。
描述
Summary
All 43 trophies live in one hand-maintained list in a shared module, so every new game edits shared code, and the set of games is stated twice (registry and the trophy list). Trophy ids are bare strings at call sites.
Where
shared/achievements.ts:22-76,shared/achievements.ts:110-111,shared/achievements.ts:143-144src/hub/trophies-panel.ts:26-27(games with no trophies are skipped, hiding their stats)
Impact
- A mistyped id in
unlock('...')compiles and silently never unlocks. - A game added without trophies is excluded from the "play every game" trophy and from the stats panel.
shared/achievements.tschanges in every game-add commit.
Suggested fix
Each step leaves the build working:
- Add tests for
unlock,addCounter,recordPlayand a registry consistency test. - Derive a
TrophyIdunion from the list (as const) and typeunlock(id: TrophyId). No behaviour change. - Move each game's rows to
games/<slug>/trophies.tsand build the list withimport.meta.glob(Phaser-free, so the hub still loads it cheaply). - Derive the "play every game" set from the registry, and render a stats-only section for games with no trophies.
Acceptance criteria
- A mistyped trophy id fails typecheck
- Adding a game does not require editing
shared/achievements.ts
Getting started
- Relevant files:
shared/achievements.ts,games/registry.json,src/hub/trophies-panel.ts - Run locally:
npm install, thennpm run dev - Checks:
npm run typecheckandnpm run build(there is no test suite yet) - Related docs:
README.md
Related: #1
Filed by repo-audit/full-audit at b001f5d. Severity: medium. Effort: M. audit-key: tech-debt|shared/achievements.ts|TROPHIES
- 主要语言
- TypeScript
- 星标
- 3
- 派生
- 3
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
TMHSDigital/GH-Arcade 的其他 Issue
-
enhancement good first issue severity: low
难度 2/5 1-3 小时 新手友好度 82/100
TMHSDigital/GH-Arcade#50 ·
-
enhancement good first issue severity: medium
难度 2/5 1-3 小时 新手友好度 86/100
TMHSDigital/GH-Arcade#47 ·
-
documentation good first issue severity: low
难度 2/5 1-3 小时 新手友好度 78/100
TMHSDigital/GH-Arcade#34 ·
-
documentation good first issue severity: low
难度 2/5 1-3 小时 新手友好度 78/100
TMHSDigital/GH-Arcade#33 ·
-
dependencies good first issue severity: low
难度 2/5 1-3 小时 新手友好度 85/100
TMHSDigital/GH-Arcade#27 ·
查看 TMHSDigital/GH-Arcade 的全部 Issue
相似的 Issue
-
automated-triage type/bug type/ci
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
📦 expo-router Android contributor: external needs review sdk-58 severity: medium
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
documentation good first issue
难度 2/5 1-3 小时 新手友好度 84/100
asasemahmed/openboard#68 ·
维护者通常 1 天内回复
-
bug good first issue
难度 2/5 1-3 小时 新手友好度 72/100
-
Document PowerShell shell semantics and read-only Bash deduplication in Built-in Tools reference未关闭documentation
难度 2/5 1-3 小时 新手友好度 78/100