Add a test runner, a lint step and a pull_request CI check
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 65/100
- Issue 类型
- 功能
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- eslint, github-actions, typescript, vite
- 领域
- build-system, ci-cd, testing
调研方向
Read package.json and .github/workflows/deploy.yml to understand the existing scripts and deployment workflow; check tsconfig.json for the current type-check scope. Add the requested test, lint and pull request checks, keeping deployment gated to main, then run npm test, npm run lint and npm run build. Done when all checks pass and pull requests receive a required check.
由索引模型根据 Issue 内容生成。
描述
Summary
There is no test framework, no linter and no check before code reaches main. The only workflow deploys on push if tsc and vite build pass.
Where
package.json:8-14(scripts: dev, build, preview, typecheck, new-game).github/workflows/deploy.yml:3-6,.github/workflows/deploy.yml:26-27tsconfig.json:17(scripts/new-game.mjsis not type-checked)
Impact
A logic regression in rules code, trophy unlocks or save handling ships with no automated signal, and pull requests get no feedback.
Suggested fix
- Add
vitestwith"test": "vitest run"and a separatevitest.config.tsusingenvironment: 'node', so the PWA plugin and multi-page inputs are not loaded - Add ESLint with typescript-eslint and a
lintscript - Add a
pull_requesttrigger that runs install, lint, test and build only (deploy stays gated to main) - Run
npm testbeforenpm run buildin the deploy workflow
Acceptance criteria
-
npm testandnpm run lintexist and pass - Pull requests show a required check
Getting started
- Relevant files:
package.json,.github/workflows/deploy.yml,tsconfig.json - Run locally:
npm install, thennpm run dev - Checks:
npm run typecheckandnpm run build(there is no test suite yet) - Related docs:
README.md
Filed by repo-audit/full-audit at b001f5d. Severity: medium. Effort: M. audit-key: testing|package.json|scripts.test
- 主要语言
- TypeScript
- 星标
- 3
- 派生
- 3
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
TMHSDigital/GH-Arcade 的其他 Issue
-
enhancement good first issue severity: low
难度 2/5 1-3 小时 新手友好度 82/100
TMHSDigital/GH-Arcade#50 ·
-
enhancement good first issue severity: medium
难度 2/5 1-3 小时 新手友好度 86/100
TMHSDigital/GH-Arcade#47 ·
-
documentation good first issue severity: low
难度 2/5 1-3 小时 新手友好度 78/100
TMHSDigital/GH-Arcade#34 ·
-
documentation good first issue severity: low
难度 2/5 1-3 小时 新手友好度 78/100
TMHSDigital/GH-Arcade#33 ·
-
dependencies good first issue severity: low
难度 2/5 1-3 小时 新手友好度 85/100
TMHSDigital/GH-Arcade#27 ·
查看 TMHSDigital/GH-Arcade 的全部 Issue
相似的 Issue
-
automated-triage type/bug type/ci
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
📦 expo-router Android contributor: external needs review sdk-58 severity: medium
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
documentation good first issue
难度 2/5 1-3 小时 新手友好度 84/100
asasemahmed/openboard#68 ·
维护者通常 1 天内回复
-
bug good first issue
难度 2/5 1-3 小时 新手友好度 72/100
-
Document PowerShell shell semantics and read-only Bash deduplication in Built-in Tools reference未关闭documentation
难度 2/5 1-3 小时 新手友好度 78/100