Give needs-review entries a structured open question and surface it

未关闭
#211 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
35/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
领域
tooling

调研方向

Start with the V9 - Deprecated: rule in site/checks.mjs and the age-only sorting in site/lib/reverify.mjs (lines 23-31), then see where needs-review is documented in CONTRIBUTING.md. Done means every needs-review entry carries a - Review: line that the checks enforce, the question appears on the entry page and in data.json, and the monthly re-verify issue lists them. The open decision on grandfathering existing entries needs a maintainer answer before implementing. Run npm run check to verify.

由索引模型根据 Issue 内容生成。

描述

enhancement priority: medium

Summary

43 entries are needs-review, none with a machine-readable statement of what is unresolved. deprecated requires a - Deprecated: line (V9); needs-review has no equivalent. The re-verify batch sorts by age only, so a recently checked needs-review entry waits months and contributors never see its question.

Related: #99

Where

  • CONTRIBUTING.md:16
  • site/lib/reverify.mjs:23-31
  • site/checks.mjs (V9 - Deprecated: rule)

Suggested fix

  • Add a - Review: marker line, enforced the way V9 is.
  • Show it on the entry page and in data.json.
  • Append an "Open questions" section to the monthly re-verify issue.

Open question: grandfather existing entries for one cycle while backfilling?

Acceptance criteria

  • Every needs-review entry states its open question
  • The re-verify issue lists them

Getting started

  • Relevant files: site/checks.mjs, site/lib/reverify.mjs, site/lib/entry-page.mjs
  • How to run tests: npm test (unit tests), npm run check (tests + validate + build). Node 22+, no dependencies.
  • Related docs: site/README.md, CONTRIBUTING.md

Filed by repo-audit/full-audit at 982fcd9. Severity: medium. Effort: M. audit-key: enhancement|site/checks.mjs|needs-review-marker

主要语言
JavaScript
星标
58
派生
15
平均合并
1 天 14 小时
30 天内合并 PR
11

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

TMHSDigital/Free-Game-Dev-Assets 的其他 Issue

查看 TMHSDigital/Free-Game-Dev-Assets 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。