Test data labeled NP1100 has electrode positions inconsistent with NP1100 catalogue geometry
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 25/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 停滞
- 技术栈
- python
- 领域
- data, testing-qa
调研方向
Start with the three NP1100 entries in tests/data/openephys/OE_Neuropix-PXI-NP-Ultra/settings.xml and trace how read_openephys handles their positions and part numbers. Review PR 406 for the work already in progress. The proposed outcome is to surface catalogue-geometry mismatches as errors and remove the inconsistent NP1100 test data, subject to the project's decision.
由索引模型根据 Issue 内容生成。
描述
Three probes in the test dataset OE_Neuropix-PXI-NP-Ultra/settings.xml are labeled probe_part_number="NP1100" (L75, L274, L473), but their electrode positions contradict the NP1100 specification. The XML positions show 48 um vertical spacing across a y range of 0-2256 um. According to the ProbeTable catalogue, NP1100 is a passive probe with only 384 total electrodes at 6 um pitch (y = 0-282 um), a single bank, and no electrode selection. This is an 8x mismatch in vertical spacing and the y range is off by an order of magnitude. Every other probe type in our test data (NP1, NP2, NP2 4-shank, NP-Opto, NP1110, NP1121) matches its catalogue geometry exactly.
I suspect the probe_part_number in the XML is wrong and these are actually NP1110 probes. The positions match NP1110 exactly: NP1110 (datasheet) has 6144 electrodes in an 8x768 grid at 6 um pitch with active electrode selection, and selecting every 8th row produces 48 rows at 48 um effective spacing = 2256 um. NP1110 is the only probe in the NP11xx family with more than 384 electrodes, making it the only one capable of producing the observed positions. The two part numbers differ by a single digit (NP1100 vs NP1110), and NP1100 is listed as non-commercial in the ProbeTable while NP1110 is commercial, so these may have been prototype units with an incorrect part number. Looking at the neuropixels-pxi plugin source, the part number is read directly from the probe's EEPROM chip via readProbePN() and passed through unchanged to the XML, so the mislabel would originate from the chip itself.
I propose that read_openephys raises an error when it encounters any probe whose XML positions don't match the catalogue geometry, and that we remove the NP1100 test data from our test suite. In the case of the NP1100 test data, the mismatch was caused by an incorrect part number on a non-commercial prototype, but in general both possible fallbacks (trusting the XML positions or trusting the catalogue) can be wrong, so I don't feel comfortable silently picking one. By raising an error we surface the problem to users. If this happens more often we can revisit and discuss a proper solution based on the cases reported. I am doing this on: https://github.com/SpikeInterface/probeinterface/pull/406
- 主要语言
- Python
- 星标
- 85
- 派生
- 49
- 平均合并
- 13 小时 47 分钟
- 30 天内合并 PR
- 3
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
SpikeInterface/probeinterface 的其他 Issue
-
难度 4/5 3-5 天 新手友好度 58/100
SpikeInterface/probeinterface#469 · 2 条评论 ·
-
难度 3/5 1-2 天 新手友好度 68/100
SpikeInterface/probeinterface#465 ·
-
难度 5/5 一周以上 新手友好度 48/100
SpikeInterface/probeinterface#452 · 1 条评论 ·
-
question
难度 4/5 3-5 天 新手友好度 45/100
SpikeInterface/probeinterface#449 · 7 条评论 ·
-
难度 5/5 一周以上 新手友好度 30/100
SpikeInterface/probeinterface#447 · 2 条评论 · 1 个 reaction ·
查看 SpikeInterface/probeinterface 的全部 Issue
相似的 Issue
-
area: harness bug status: needs-triage
难度 2/5 1-3 小时 新手友好度 75/100
Human-Agent-Society/reef#625 ·
-
难度 2/5 1-3 小时 新手友好度 70/100
-
难度 1/5 1 小时以内 新手友好度 80/100
learningequality/kolibri#15351 · 2 条评论 ·
-
难度 2/5 1-3 小时 新手友好度 75/100
-
Name consistency 未关闭
难度 2/5 1-3 小时 新手友好度 75/100
eellak/triplestore#65 · 1 条评论 ·