remove --preserve-state on a manifest-less hosted npm project silently restores the pin without the documented hosted_state_not_preservable note
维护者通常 1 天内回复
评估
调研方向
从 crates/socket-patch-cli/src/commands/remove.rs 中的 remove_hosted_only（约第 1337 行）开始，然后将其与约第 770 行的基于 manifest 的 hosted 路径进行比较。在仅 hosted 模式下分别使用和不使用 --json 重现 remove --preserve-state，并将输出与 CLI_CONTRACT.md 和 rollback --preserve-state 进行比较。当 hosted_state_not_preservable 注释在两种受支持的输出模式中都显示时，即表示完成。
由索引模型根据 Issue 内容生成。
描述
[agent] Found by the scheduled npm bug-hunt routine (ledger #302).
Summary
In v5, a project patched by a bare scan (hosted mode) has no .socket/manifest.json. On such a project, socket-patch remove <purl> --preserve-state restores the hosted pin to the upstream registry and deletes the .npmrc. So the patch is gone, even though the user asked to preserve state.
The command never tells the user this. There's no "hosted wiring has no preservable local state" note on stderr, and no warnings[] in --json (the envelope has no warnings key at all). rollback --preserve-state on the same project correctly emits hosted_state_not_preservable.
Severity is low. The behaviour (restoring anyway) is what's documented; only the advisory is missing. But --preserve-state exists so the user can expect to re-apply later, and here it silently doesn't preserve.
Repro (Linux, npm 12.1.0, main 2463257)
A local mock of the patch API serves pkg:npm/[email protected]. SPA="--api-url … --org o --api-token fake --patch-server-url …".
echo '{"name":"t","version":"1.0.0","private":true,"dependencies":{"left-pad":"1.3.0"}}' > package.json
npm install
socket-patch scan $SPA # hosted: package-lock.json + .npmrc rewritten, no .socket/
socket-patch remove pkg:npm/[email protected] --preserve-state $SPA
# The following hosted patch will be unwound and removed:
# - pkg:npm/[email protected]
# Restored pkg:npm/[email protected] to its upstream registry entry
# (no "no preservable local state" note)
socket-patch scan $SPA
socket-patch remove pkg:npm/[email protected] --preserve-state $SPA --json # status success, events[hosted_reverted], no warnings key
socket-patch scan $SPA
socket-patch rollback --preserve-state $SPA --json # warnings: [reinstall_required, hosted_state_not_preservable] <- correct
It reproduces on 2 of 2 runs.
Expected vs actual
- Expected: CLI_CONTRACT.md's warning table, row
hosted_state_not_preservable, says: "rollback--preserve-state(v5.0): hosted pins were restored to upstream anyway … (remove --preserve-stateprints the same note on stderr.)". The--preserve-state (opt-out, both rollback and remove)section says the same: "a preserve run still restores them to upstream — surfaced as thehosted_state_not_preservablewarning". - Actual: the note is printed only on the manifest-backed
removepath. The hosted-only path, which is the default v5 shape, prints nothing.
| Project shape | remove --preserve-state note |
|---|---|
| Hosted-only (no manifest), Linux npm 12.1.0 | missing (stderr and JSON) |
rollback --preserve-state, same project |
present |
Suspect code
crates/socket-patch-cli/src/commands/remove.rs:1337 (remove_hosted_only). Its doc comment says "--preserve-state still unwinds — hosted has no preservable local state". But the Note: hosted wiring has no preservable local state … eprintln only exists in the manifest-backed hosted leg (remove.rs:770).
- 主要语言
- Rust
- 星标
- 8
- 派生
- 0
- 平均合并
- 1 天 1 小时
- 30 天内合并 PR
- 257
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
SocketDev/socket-patch 的其他 Issue
-
agent:triaged bug bughunt pm:npm priority:p1
难度 2/5 1-3 小时 新手友好度 85/100
SocketDev/socket-patch#1127 · 1 条评论 ·
维护者通常 1 天内回复
-
agent:triaged bug bughunt pm:bundler priority:p1
难度 2/5 1-3 小时 新手友好度 75/100
SocketDev/socket-patch#1125 · 1 条评论 ·
维护者通常 1 天内回复
-
agent:triaged bug bughunt pm:pipenv priority:p1
难度 2/5 1 小时以内 新手友好度 85/100
SocketDev/socket-patch#1122 · 1 条评论 ·
维护者通常 1 天内回复
-
agent:triaged bug bughunt pm:npm priority:p1
难度 2/5 1-3 小时 新手友好度 75/100
SocketDev/socket-patch#1072 · 1 条评论 ·
维护者通常 1 天内回复
-
agent:triaged arch-audit bug priority:p3
难度 2/5 1-3 小时 新手友好度 85/100
SocketDev/socket-patch#1062 · 1 条评论 ·
维护者通常 1 天内回复
查看 SocketDev/socket-patch 的全部 Issue
相似的 Issue
-
mxl-compile: пример заполнения ячеек отклоняется Unica可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭
难度 1/5 1-3 小时 新手友好度 91/100
IngvarConsulting/unica#1301 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
-
难度 2/5 1-3 小时 新手友好度 82/100
-
难度 1/5 1 小时以内 新手友好度 75/100
ajeetraina/awesome-docker-sbx#220 ·
-
`helios / deploy`: switch zone wait in `deploy.sh` has almost no headroom over healthy startup times可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭Test Flake
难度 2/5 1-3 小时 新手友好度 74/100
oxidecomputer/omicron#11453 ·
维护者通常 1 天内回复