Decide: one hosted `redirect` JSON block for disk scan and the in-memory engine (today {mode, rewrittenFiles} vs a seven-key block)
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 38/100
- Issue 类型
- 重构
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- rust
调研方向
Read crates/socket-patch-cli/src/commands/scan/hosted.rs and crates/socket-patch-core/src/hosted/render.rs to compare the disk and in-memory redirect JSON blocks, then review CLI_CONTRACT and tests/hosted_memory_parity.rs. Decide which proposed shape should be shared, update the corresponding implementation and documentation, and fix the stale comment and repeated sentence. Done means disk and memory emit matching key sets, or the docs accurately describe both shapes, with the parity test covering the chosen contract.
由索引模型根据 Issue 内容生成。
描述
[agent] Filed by the scheduled architecture audit (audit-cli-tests). Register: register comment.
Kind: decision. Register ID: T29.
Question
The hosted --json envelope's nested redirect block has two shapes. Which one should both paths emit?
- Option A (recommended): both paths emit core's seven-key block. Disk
scangainsredirected,skipped,patches,warningsanddryRun; it already hasmodeandrewrittenFiles. This is additive for disk consumers. The per-patchpinned/would_pin/unpinnedrows then also exist on disk, beside the envelopeevents[]. - Option B: both paths emit the disk shape
{mode, rewrittenFiles}, with per-patch outcomes only inevents[]and warnings only in the top-levelwarnings[]. This removes keys from in-memory (napi/hosted-bundle) consumers. - Option C: keep both shapes, but correct the docs so neither claims to be the only one.
Problem
- Disk: scan/hosted.rs
redirect_blockL95-L99 emits{ "mode": "hosted", "rewrittenFiles": [...] }. Its per-patch outcomes are envelope events (applied/verified/skipped). - In-memory: core hosted/render.rs
redirect_json_blockL22-L77 emitsmode,redirected,rewrittenFiles,skipped,patches,warningsanddryRun. Onlyhosted/memory/mod.rscalls it (L1289, L1571). - Its doc says this is "the ONE spelling of its key set … shared by every hosted path (disk scan, its zero-discovery arm, and the in-memory engine), so the two cannot drift by convention". That is false on
main. - A comment at scan/hosted.rs L1900-L1904 refers to
redirect.patches[], which the disk path never emits. - The sentence "no lockfile entry pinning it could be rewritten" is written 3 times (hosted.rs L150, L2444, render.rs L61).
Proposed change (after the decision)
- A: disk calls
redirect_json_blockandredirect_blockis deleted. - B: the memory path drops the extra keys.
- C: both docs are corrected.
In every case, fix the stale comment and keep the sentence once.
Size
2 to 3 files plus CLI_CONTRACT text. Under 100 lines.
Acceptance criteria
- One function builds the block for both paths, or the docs stop claiming that.
tests/hosted_memory_parity.rs(or a new test) asserts the disk and memoryredirectkey sets are equal.
- 主要语言
- Rust
- 星标
- 8
- 派生
- 2
- 平均合并
- 19 小时 19 分钟
- 30 天内合并 PR
- 697
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
SocketDev/socket-patch 的其他 Issue
-
agent:triaged arch-audit priority:p3 refactor
难度 2/5 1-3 小时 新手友好度 83/100
SocketDev/socket-patch#1860 ·
维护者通常 1 天内回复
-
agent:triaged arch-audit priority:p3 refactor
难度 2/5 1-3 小时 新手友好度 78/100
SocketDev/socket-patch#1838 ·
维护者通常 1 天内回复
-
Share one scoped env-var test guard: EnvGuard is copy-pasted 11 times across core unit and integration tests可能已有人在做 @mikolalysenko 于 1 天前认领。 未关闭agent:claimed agent:triaged arch-audit priority:p3 refactor
难度 4/5 3-5 天 新手友好度 55/100
SocketDev/socket-patch#1889 · 2 条评论 ·
维护者通常 1 天内回复
-
Memoize env-keyed subprocess probes through one helper: composer, python and ruby each define the same env key and drifted on when an answer is kept可能已有人在做 @mikolalysenko 于 1 天前认领。 未关闭agent:claimed agent:triaged arch-audit priority:p1 refactor
难度 4/5 1-2 天 新手友好度 25/100
SocketDev/socket-patch#1888 · 3 条评论 ·
维护者通常 1 天内回复
-
agent:triaged arch-audit priority:p3 refactor
难度 4/5 1-2 天 新手友好度 55/100
SocketDev/socket-patch#1887 · 1 条评论 ·
维护者通常 1 天内回复
查看 SocketDev/socket-patch 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 85/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 85/100
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 77/100
yunfie-twitter/Palleria#474 ·
维护者通常 1 天内回复
-
good first issue help wanted
难度 2/5 1-3 小时 新手友好度 72/100
servo/rust-smallvec#827 ·
维护者通常 1 天内回复
-
bug tests
难度 2/5 1-3 小时 新手友好度 85/100
维护者通常 1 天内回复