ImageSharp 4.1.3 misclassifies linear RGB ICC profiles as sRGB
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
The suspected cause is IsCanonicalSrgbMatrixTrc() in src/ImageSharp/Metadata/Profiles/ICC/IccProfile.SRGB.cs, which compares the red, green and blue curves but not whether they are the sRGB transfer function. Start with the reproduction ZIP linked in the issue and run it in both DEBUG and RELEASE to see the four failing assertions. Done means linear gamma=1 profiles are not classed as sRGB, Convert produces the expected pixel values, and Compact keeps the profile.
由索引模型根据 Issue 内容生成。
描述
Prerequisites
- I have written a descriptive issue title
- I have verified that I am running the latest version of ImageSharp
- I have verified if the problem exist in both
DEBUGandRELEASEmode - I have searched open and closed issues to ensure it has not already been reported
ImageSharp version
4.1.3
Other ImageSharp packages and versions
None
Environment (Operating system, version and so on)
Ubuntu WSL2, Linux x64, .NET SDK 10.0.112
.NET Framework version
.NET 10.0.12
Description
ImageSharp 4.1.3 incorrectly classifies certain linear RGB ICC profiles as canonical sRGB.
When decoding JPEG or PNG images containing a linear RGB ICC profile with sRGB primaries and gamma=1, ColorProfileHandling.Convert removes the ICC profile without converting the pixel values to sRGB.
PNG:
Actual RGB: [32,64,128]
Expected sRGB: [99,137,188]
JPEG:
Actual RGB: [40,80,120]
Expected sRGB: [110,152,182]
The expected values were independently verified using Little CMS 2.17.
ColorProfileHandling.Compact also incorrectly removes the non-sRGB ICC profile while leaving the RGB values unchanged.
The defect occurs immediately after Image.Load returns, before orientation correction, metadata removal or output encoding.
The issue reproduces identically in both DEBUG and RELEASE configurations with .NET 10.
Suspected cause:
The IsCanonicalSrgbMatrixTrc() method checks that the red, green and blue tone reproduction curves match, but does not verify that they implement the actual sRGB transfer function. Therefore, identical linear gamma=1 curves may be incorrectly classified as canonical sRGB.
Impact:
This defect can cause incorrect photographic colors when an ICC profile is removed without performing the necessary color transformation.
Could the maintainers confirm this issue and advise whether a fix or officially supported workaround is available for ImageSharp 4.1.x?
Steps to Reproduce
Steps to reproduce:
-
Use SixLabors.ImageSharp 4.1.3 with .NET 10 on Linux x64 (Ubuntu WSL2).
-
Extract the attached reproduction ZIP into a clean directory and follow its README instructions. Use a valid Six Labors license stored outside the project.
-
Restore the locked NuGet dependencies and compile the reproduction project.
-
Run the reproduction in both DEBUG and RELEASE configurations.
-
The supplied synthetic JPEG and PNG images contain an ICC v4.3 RGB profile with sRGB primaries and linear gamma=1 transfer curves.
-
Load the images using Image.Load with ColorProfileHandling.Convert, Compact and Preserve.
-
Inspect the RGB pixel values and ICC profile immediately after decoding.
-
Compare the results against the expected sRGB values independently verified using Little CMS 2.17.
Expected versus actual results:
PNG Convert:
Expected RGB: [99,137,188]
Actual RGB: [32,64,128]
ICC: Absent in both cases.
JPEG Convert:
Expected RGB: [110,152,182]
Actual RGB: [40,80,120]
ICC: Absent in both cases.
PNG Compact:
Expected RGB: [32,64,128]
Actual RGB: [32,64,128]
Expected ICC: Present
Actual ICC: Absent
JPEG Compact:
Expected RGB: [40,80,120]
Actual RGB: [40,80,120]
Expected ICC: Present
Actual ICC: Absent
Verification:
The defect reproduces identically in DEBUG and RELEASE.
Two Preserve control assertions pass.
Four assertions fail.
Exit code 1 is intentional because the tests detect the defect.
The problem occurs immediately after Image.Load returns, before orientation correction, metadata removal or PNG encoding.
The attached ZIP contains the minimal .NET 10 project, synthetic JPEG/PNG/ICC fixtures, instructions, expected results and SHA-256 hashes.
No license credentials, customer images or proprietary code are included.
Images
- 主要语言
- C#
- 星标
- 8k
- 派生
- 904
- 平均合并
- 15 小时 39 分钟
- 30 天内合并 PR
- 12
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
SixLabors/ImageSharp 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 45/100
SixLabors/ImageSharp#3218 · 3 条评论 ·
维护者通常 1 天内回复
-
难度 4/5 1-2 天 新手友好度 30/100
SixLabors/ImageSharp#3215 · 1 条评论 ·
维护者通常 1 天内回复
-
enhancement metadata:icc
难度 4/5 3-5 天 新手友好度 48/100
SixLabors/ImageSharp#3198 · 1 条评论 ·
维护者通常 1 天内回复
-
bug metadata:icc
难度 4/5 3-5 天 新手友好度 52/100
SixLabors/ImageSharp#3197 ·
维护者通常 1 天内回复
-
formats:exr
难度 5/5 一周以上 新手友好度 35/100
SixLabors/ImageSharp#3116 · 2 条评论 · 1 个 reaction ·
维护者通常 1 天内回复
查看 SixLabors/ImageSharp 的全部 Issue
相似的 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 78/100
ClickHouse/clickhouse-cs#689 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 88/100
维护者通常 7 天内回复
-
难度 1/5 1 小时以内 新手友好度 65/100
vchelaru/FlatRedBall2#1481 ·
维护者通常 1 天内回复
-
ai-chat bug trivial
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
area-signalr
难度 2/5 1-3 小时 新手友好度 75/100
dotnet/aspnetcore#69842 · 1 条评论 ·
维护者通常 1 天内回复