Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

Incompatibility between Connector and SpongeNeo due to RecipeManager missing in ResourceManagerHelperImpl#sort listeners

未关闭
  • 哪里不对？
#238 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
冷清
技术栈
java
领域
backend

调研方向

Start by reading ResourceManagerHelperImpl#sort(List<PreparableReloadListener>) and getWrapperLookup, then compare the reload listener list with and without SpongeNeo on Forge 1.21.1 using Forgified Fabric API. Reproduce with Connector 2.0.0-beta.8 and a Fabric mod such as BetterEnd, and inspect the linked crash log. Done means reloads no longer fail with “No RecipeManager found” while compatibility and tag behavior are checked.

由索引模型根据 Issue 内容生成。

描述

1.21.x bug
Minecraft version

1.21.1

Describe the bug

When running Connector (2.0.0-beta.8) together with SpongeNeo on Forge 1.21.1 using Forgified Fabric API, the server fails resource reloads because ResourceManagerHelperImpl#getWrapperLookup cannot find a RecipeManager in the reload listeners list. This happens because SpongeNeo’s reload listener handling changes the order and contents of the listener list before Connector/FAPI processing, so the vanilla RecipeManager is no longer present when FAPI sorts listeners.

Steps to reproduce
  1. Install connector on a SpongeNeo server
  2. Add some fabric mod such as betterend
  3. Then crashed cause the No RecipeManager found in listeners!

...

Logs

https://gist.github.com/Sam-Chai/308356f2317c3ff77194950dd3956b4f

Additional context

From the begining I found that it seems like connector caused this problem. But when I check the crash-report, I notice that this crash from the FFAPI.
The issue from connector: https://github.com/Sinytra/Connector/issues/1911

Cause
ResourceManagerHelperImpl#sort(List) assumes the provided list always contains a RecipeManager instance (vanilla behavior). SpongeNeo modifies the reload process so that the RecipeManager is not in the list when FAPI’s sort runs. This triggers the IllegalStateException.

Proposed Fix
Add a compatibility patch in Connector that, when SpongeNeo is detected, ensures a RecipeManager is present in the listeners list before FAPI attempts to resolve dependencies.

Suggested Implementation
A minimal Mixin to ResourceManagerHelperImpl#sort(List) with remap=false, inserting the vanilla RecipeManager from the running server if missing:

@Inject(method = "sort(Ljava/util/List;)V", at = @At("HEAD"))
    private void connector$ensureRecipeManagerPresent(List<PreparableReloadListener> listeners, CallbackInfo ci) {
        if (!FMLEnvironment.dist.isDedicatedServer() || !ModList.get().isLoaded("spongeneo")) return;

        for (PreparableReloadListener l : listeners) if (l instanceof RecipeManager) return;

        MinecraftServer server = ServerLifecycleHooks.getCurrentServer();
        if (server == null) return;

        ReloadableServerResources res = server.getServerResources().managers();
        if (res == null) return;

        RecipeManager rm = res.getRecipeManager();
        if (rm == null) return;

        listeners.add(0, rm);
    }

This ensures that:

  • It only runs on a dedicated server.
  • It only triggers when SpongeNeo is loaded.
  • It does nothing if a RecipeManager is already in the list.
  • It adds the RecipeManager at the start of the list to preserve vanilla/FAPI expectations.

Result:
I fixed that. Connector and FFAPI with betterend running on a SpongeNeo server.

Image

But I havn't test too much, and it semms caused some tag problem and I have to fix it.

主要语言
Java
星标
181
派生
41
平均合并
10 天 5 小时
30 天内合并 PR
2

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

Sinytra/ForgifiedFabricAPI 的其他 Issue

查看 Sinytra/ForgifiedFabricAPI 的全部 Issue

相似的 Issue

更多 Java Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。