2W transformer `rating`/`rating_b`/`rating_c`/flows scaled by winding base instead of system base when `SBASE1-2 ≠ SBASE`

已关闭

#74 创建于 2026年10月14日 0 条评论 0 个 reaction 已指派 1 人在 GitHub 查看

维护者通常 3 天内回复

@luke-kiernan 已经在做这个了。

开始于 2026年10月14日。

#75 来自 @luke-kiernan —— 已合并

评估

这个 Issue 还没有评估数据。

描述

Summary

For PSS/E 2-winding transformers whose winding base (SBASE1-2) differs from the system base, the OpenAPI reader produces ratings and initial flows scaled by SBASE1-2 / SBASE. Impedances are correct.

Reproducer

A 100 MVA system with three 2W transformers, each with RATA1 = RATB1 = RATC1 = 55 MVA and impedances given on the system base (CZ = 1), differing only in SBASE1-2 (.raw below):

import PowerSystems as PSY
import PowerFlowFileParser as PFP
import PowerSystemCaseBuilder: system_from_openapi
using PowerSystems.Unitful: @u_str
using InfrastructureSystems.PerUnit

sys = system_from_openapi(PFP.PowerModelsData("transformer_rating_base.raw"); runchecks = false)
for t in PSY.get_components(PSY.TwoWindingTransformer, sys)
    c = PSY.get_circuit(t)
    println(PSY.get_name(t), "  rating = ", PSY.get_rating(c, u"MW"), " MW  x = ", PSY.get_x(c, u"SU"))
end

transformer	SBASE1-2	rating (MW)	expected	x (SU)
XFMR_SB50	50	27.5	55	0.2 ✓
XFMR_SB100	100	55.0	55	0.2 ✓
XFMR_SB200	200	110.0	55	0.2 ✓

(Run against the in-development psy6 branches of PowerSystems.jl and PowerFlowFileParser.jl; their Project.toml versions, 5.10.0 and 0.3.0, have not been bumped yet. The bug is in PFP, so it does not depend on the PSY version.)

transformer_rating_base.raw

0,   100.00, 33, 0, 1, 60.00     / PSS(R)E 33 RAW
TRANSFORMER RATING BASE REPRODUCER
THREE 2W TRANSFORMERS, ALL RATA1 = 55 MVA, SBASE1-2 = 50 / 100 / 200 MVA
     1,'HV138       ', 138.0000,3,   1,   1,   1,1.00000,   0.0000,1.10000,0.90000,1.10000,0.90000
     2,'LV50        ',  13.8000,1,   1,   1,   1,1.00000,   0.0000,1.10000,0.90000,1.10000,0.90000
     3,'LV100       ',  13.8000,1,   1,   1,   1,1.00000,   0.0000,1.10000,0.90000,1.10000,0.90000
     4,'LV200       ',  13.8000,1,   1,   1,   1,1.00000,   0.0000,1.10000,0.90000,1.10000,0.90000
0 / END OF BUS DATA, BEGIN LOAD DATA
     2,'1 ',1,   1,   1,    20.000,     5.000,     0.000,     0.000,     0.000,     0.000,   1,1,0
     3,'1 ',1,   1,   1,    20.000,     5.000,     0.000,     0.000,     0.000,     0.000,   1,1,0
     4,'1 ',1,   1,   1,    20.000,     5.000,     0.000,     0.000,     0.000,     0.000,   1,1,0
0 / END OF LOAD DATA, BEGIN FIXED SHUNT DATA
0 / END OF FIXED SHUNT DATA, BEGIN GENERATOR DATA
     1,'1 ',    60.000,    15.000,   100.000,  -100.000,1.00000,     0,   200.000, 0.00000E+0, 1.00000E+0, 0.00000E+0, 0.00000E+0,1.00000,1,  100.0,   200.000,     0.000,   1,1.0000
0 / END OF GENERATOR DATA, BEGIN BRANCH DATA
0 / END OF BRANCH DATA, BEGIN TRANSFORMER DATA
     1,     2,     0,'1 ',1,1,1, 0.00000E+0, 0.00000E+0,2,'XFMR_SB50   ',1,   1,1.0000,   0,1.0000,   0,1.0000,   0,1.0000,'            '
 1.00000E-2, 2.00000E-1,    50.00
1.00000,   0.000,   0.000,    55.00,    55.00,    55.00, 0,      0, 1.10000, 0.90000, 1.10000, 0.90000,  33, 0, 0.00000, 0.00000,  0.000
1.00000,   0.000
     1,     3,     0,'1 ',1,1,1, 0.00000E+0, 0.00000E+0,2,'XFMR_SB100  ',1,   1,1.0000,   0,1.0000,   0,1.0000,   0,1.0000,'            '
 1.00000E-2, 2.00000E-1,   100.00
1.00000,   0.000,   0.000,    55.00,    55.00,    55.00, 0,      0, 1.10000, 0.90000, 1.10000, 0.90000,  33, 0, 0.00000, 0.00000,  0.000
1.00000,   0.000
     1,     4,     0,'1 ',1,1,1, 0.00000E+0, 0.00000E+0,2,'XFMR_SB200  ',1,   1,1.0000,   0,1.0000,   0,1.0000,   0,1.0000,'            '
 1.00000E-2, 2.00000E-1,   200.00
1.00000,   0.000,   0.000,    55.00,    55.00,    55.00, 0,      0, 1.10000, 0.90000, 1.10000, 0.90000,  33, 0, 0.00000, 0.00000,  0.000
1.00000,   0.000
0 / END OF TRANSFORMER DATA, BEGIN AREA DATA
   1,     1,     0.000,    10.000,'AREA1       '
0 / END OF AREA DATA, BEGIN TWO-TERMINAL DC DATA
0 / END OF TWO-TERMINAL DC DATA, BEGIN VSC DC LINE DATA
0 / END OF VSC DC LINE DATA, BEGIN IMPEDANCE CORRECTION DATA
0 / END OF IMPEDANCE CORRECTION DATA, BEGIN MULTI-TERMINAL DC DATA
0 / END OF MULTI-TERMINAL DC DATA, BEGIN MULTI-SECTION LINE DATA
0 / END OF MULTI-SECTION LINE DATA, BEGIN ZONE DATA
   1,'ZONE1       '
0 / END OF ZONE DATA, BEGIN INTER-AREA TRANSFER DATA
0 / END OF INTER-AREA TRANSFER DATA, BEGIN OWNER DATA
   1,'OWNER1      '
0 / END OF OWNER DATA, BEGIN FACTS DEVICE DATA
0 / END OF FACTS DEVICE DATA, BEGIN SWITCHED SHUNT DATA
0 / END OF SWITCHED SHUNT DATA, BEGIN GNE DATA
0 / END OF GNE DATA, BEGIN INDUCTION MACHINE DATA
0 / END OF INDUCTION MACHINE DATA
Q

Root cause

The header comment in src/openapi/branch.jl (lines 8–18) already describes it:

_make_per_unit! divides rate_a/rate_b/rate_c/pf/qf by baseMVA, which puts them in system-base pu (pm_io/data.jl:403, :415).
psse.jl rebases br_r/br_x/g_fr/b_fr onto the winding base, d["base_power"], which puts them in device-base pu.
The 2W builder converts everything back with the device base:
```
rating = _natural_value(rate_a, base_power),            # branch.jl:435-437, same for rate_b/rate_c
active_power_flow = get(d, "pf", 0.0) * base_power,     # branch.jl:442-443
```
Impedances are correct because they really are device-base. Ratings and flows are system-base, so they pick up a stray base_power / sys_mbase factor.

Lines don't show the bug because their base_power == baseMVA. The 3W path doesn't either, because its ratings come straight from the raw MVA fields and skip _make_per_unit!.

Why it wasn't caught

The header comment says the behavior was deliberately ported from the old PSCB converter (the "oracle") for parity: "this reader reproduces exactly that." It also notes that every fixture on hand, and all MATPOWER input, has winding base equal to system base, "so no real fixture can distinguish them." So parity tests pass by construction, and the bug only appears on real PSS/E cases with non-default SBASE1-2.

Proposed fix

In the 2W builder, convert rate_a/rate_b/rate_c/pf/qf with sys_mbase, as the line builder does (branch.jl:326-330).
Rewrite the header comment so it records the correct convention instead of defending the inherited one.
Add the reproducer above as a regression fixture, since no existing fixture has SBASE1-2 ≠ SBASE.
Decide whether the PSCB oracle should be fixed too, or whether the parity test should stop treating this field as ground truth.
Worth a look: dc_branch.jl:443 notes a similar oracle scaling quirk ("multiplies an already-natural number by sys_mbase") that may be the same kind of copied bug.

The pf/qf part is inferred from the code; the reproducer only checks ratings.

🤖 Generated with Claude Code

主要语言: Julia
星标: 1
派生: 3
平均合并: 4 天 10 小时
30 天内合并 PR: 10

环境准备

没有 Dockerfile 或 Docker Compose 文件
有 Pull Request 模板
阅读贡献指南

从这里开始

先读完整个 Issue，再读项目的贡献指南。
在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
Fork 仓库，在一个分支上完成修改。
提交 Pull Request，并在描述里引用这个 Issue 编号。

Sienna-Platform/PowerFlowFileParser.jl 的其他 Issue

Handling negative resistance
可能已有人在做 @annacasavant 于 1 天前认领。未关闭
- 哪里不对？
Sienna-Platform/PowerFlowFileParser.jl#83 · 已指派 1 人 · 2026年11月5日创建

维护者通常 3 天内回复
parse solver configuration
未关闭
- 哪里不对？
难度 4/5 3-5 天新手友好度 22/100

Sienna-Platform/PowerFlowFileParser.jl#72 · 2026年10月12日创建

维护者通常 3 天内回复
build_openapi_system aborts when two TwoWindingTransformer records share a bus pair and circuit id
未关闭
- 哪里不对？
难度 4/5 3-5 天新手友好度 45/100

Sienna-Platform/PowerFlowFileParser.jl#60 · 2 条评论 · 2026年9月15日创建

维护者通常 3 天内回复
PSY parsing changes post package split
可能已有人在做 @luke-kiernan 于 17 天前认领。未关闭
- 哪里不对？
难度 4/5 3-5 天新手友好度 45/100

Sienna-Platform/PowerFlowFileParser.jl#54 · 已指派 1 人 · 2026年9月4日创建

维护者通常 3 天内回复
Transformers: nominal voltage different from bus voltage
可能已有人在做 @luke-kiernan 于 22 天前认领。未关闭
- 哪里不对？
难度 3/5 1-2 天新手友好度 68/100

Sienna-Platform/PowerFlowFileParser.jl#49 · 已指派 1 人 · 2026年8月25日创建

维护者通常 3 天内回复

查看 Sienna-Platform/PowerFlowFileParser.jl 的全部 Issue

相似的 Issue

`for_each_child` and `@for_each_child` move the cursor but have no `!`
未关闭
- 哪里不对？
难度 2/5 1-3 小时新手友好度 74/100

JuliaData/XML.jl#220 · 2026年11月6日创建

维护者通常 1 天内回复
bench: `readtable` and `writetable` read only the title row of the `xl_*` fixtures
未关闭
- 哪里不对？
难度 2/5 1-3 小时新手友好度 74/100

JuliaData/XLSX.jl#490 · 1 条评论 · 1 个 reaction · 2026年11月6日创建
Defining a local function using the assignment form logs a warning
未关闭
- 哪里不对？
难度 2/5 1-3 小时新手友好度 67/100

JuliaPluto/ExpressionExplorer.jl#40 · 2026年11月6日创建
Names for cantera library in LibCantera.jl don't match built library names, preventing Julia cantera interface from loading
未关闭
- 哪里不对？
难度 2/5 1-3 小时新手友好度 78/100

Cantera/cantera#2192 · 2026年11月5日创建
ABA race in concurrent page-pool sweep
未关闭
- 哪里不对？
backport 1.14 GC

难度 2/5 1-3 小时新手友好度 66/100

JuliaLang/julia#64688 · 2026年11月5日创建

维护者通常 1 天内回复

更多 Julia Issue

2W transformer `rating`/`rating_b`/`rating_c`/flows scaled by winding base instead of system base when `SBASE1-2 ≠ SBASE`

哪里不对？

评估

描述

Summary

Reproducer

Root cause

Why it wasn't caught

Proposed fix

环境准备

从这里开始

Sienna-Platform/PowerFlowFileParser.jl 的其他 Issue

哪里不对？

哪里不对？

哪里不对？

哪里不对？

哪里不对？

相似的 Issue

哪里不对？

哪里不对？

哪里不对？

哪里不对？

哪里不对？

把新 issue 发到你的邮箱